Skip to content

Commit bb609cd

Browse files
committed
Merge remote-tracking branch 'origin/main' into dev_container_build
2 parents 87c1df8 + ad79b8f commit bb609cd

File tree

5 files changed

+34
-13
lines changed

5 files changed

+34
-13
lines changed

.devcontainer/Dockerfile

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,26 @@
11
FROM mcr.microsoft.com/devcontainers/base:ubuntu
22

3-
3+
# provide DOCKER_GID via build args if you need to force group id to match host
4+
ARG DOCKER_GID
45
ARG TARGETARCH
56
ENV TARGETARCH=${TARGETARCH}
67

78
ARG ASDF_VERSION
89
COPY .tool-versions.asdf /tmp/.tool-versions.asdf
910

11+
# specify DOCKER_GID to force container docker group id to match host
12+
RUN if [ -n "${DOCKER_GID}" ]; then \
13+
if ! getent group docker; then \
14+
groupadd -g ${DOCKER_GID} docker; \
15+
else \
16+
groupmod -g ${DOCKER_GID} docker; \
17+
fi && \
18+
usermod -aG docker vscode; \
19+
fi
20+
21+
# Anticipate and resolve potential permission issues with apt
22+
RUN mkdir -p /tmp && chmod 1777 /tmp
23+
1024
RUN apt-get update \
1125
&& export DEBIAN_FRONTEND=noninteractive \
1226
&& apt-get -y dist-upgrade \
@@ -53,16 +67,16 @@ USER vscode
5367
ENV PATH="$PATH:/home/vscode/.asdf/shims/:/workspaces/eps-prescription-tracker-ui/node_modules/.bin:/workspaces/eps-workflow-quality-checks/.venv/bin"
5468

5569
# Install ASDF plugins#
56-
RUN asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git; \
57-
asdf plugin add actionlint; \
58-
asdf plugin add shellcheck https://github.com/luizm/asdf-shellcheck.git; \
59-
asdf plugin add poetry https://github.com/asdf-community/asdf-poetry.git; \
70+
RUN asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git && \
71+
asdf plugin add actionlint && \
72+
asdf plugin add shellcheck https://github.com/luizm/asdf-shellcheck.git && \
73+
asdf plugin add poetry https://github.com/asdf-community/asdf-poetry.git && \
6074
asdf plugin add python
6175

6276
WORKDIR /workspaces/eps-workflow-quality-checks
6377

6478
ADD .tool-versions /workspaces/eps-workflow-quality-checks/.tool-versions
6579
ADD .tool-versions /home/vscode/.tool-versions
6680

67-
RUN asdf install python; \
68-
asdf install;
81+
RUN asdf install python && \
82+
asdf install

.devcontainer/devcontainer.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
"build": {
77
"dockerfile": "Dockerfile",
88
"context": "..",
9-
"args": {}
9+
"args": {
10+
"DOCKER_GID": "${env:DOCKER_GID:}"
11+
}
1012
},
1113
"mounts": [
1214
"source=${env:HOME}${env:USERPROFILE}/.aws,target=/home/vscode/.aws,type=bind",

.github/workflows/pull_request.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,14 @@ jobs:
4747
# echo "commit_id=${{ github.sha }}" >> "$GITHUB_ENV"
4848
echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
4949
echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
50-
50+
dependabot-auto-approve-and-merge:
51+
needs: quality_checks
52+
uses: NHSDigital/eps-workflow-dependabot/.github/workflows/dependabot-auto-approve-and-merge.yml@4b56ed8edd7c5357fd0123a2bd84b3429d3a6b20
53+
secrets:
54+
AUTOMERGE_APP_ID: ${{ secrets.AUTOMERGE_APP_ID }}
55+
AUTOMERGE_PEM: ${{ secrets.AUTOMERGE_PEM }}
5156
pr_title_format_check:
52-
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/pr_title_check.yml@f80157cecce288dd175e61b477a1d2dbe9c88b99
57+
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/pr_title_check.yml@f3d071da30cd01dc0e4472ac0e2d7452db78d1c7
5358
get_asdf_version:
5459
runs-on: ubuntu-22.04
5560
outputs:
@@ -89,7 +94,7 @@ jobs:
8994

9095
tag_release:
9196
needs: [quality_checks, get_asdf_version]
92-
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/tag-release.yml@f80157cecce288dd175e61b477a1d2dbe9c88b99
97+
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/tag-release.yml@f3d071da30cd01dc0e4472ac0e2d7452db78d1c7
9398
with:
9499
dry_run: true
95100
asdfVersion: ${{ needs.get_asdf_version.outputs.asdf_version }}

.github/workflows/quality-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ jobs:
361361
path: cfn_guard_output
362362

363363
- name: Generate and check SBOMs
364-
uses: NHSDigital/eps-action-sbom@efc65411a5d69d617c9ba15d633a18f7b9896859
364+
uses: NHSDigital/eps-action-sbom@ae6916d542c092ec1636f9a0ba14464ba25a97d1
365365

366366
- name: "check is SONAR_TOKEN exists"
367367
env:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
PUSH_IMAGE_ROLE: ${{ secrets.DEV_CONTAINER_PUSH_IMAGE_ROLE }}
6464
tag_release:
6565
needs: [quality_checks, get_asdf_version]
66-
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/tag-release.yml@f80157cecce288dd175e61b477a1d2dbe9c88b99
66+
uses: NHSDigital/eps-workflow-semantic-release/.github/workflows/tag-release.yml@f3d071da30cd01dc0e4472ac0e2d7452db78d1c7
6767
with:
6868
dry_run: false
6969
asdfVersion: ${{ needs.get_asdf_version.outputs.asdf_version }}

0 commit comments

Comments
 (0)