Chore: [AEA-5913] review tsconfig and dependencies (#2368)

tstephen-nhs · web-flow · commit 5aeb0199da6a · 2025-10-30T11:56:41.000Z
## Summary

- 🤖 Operational or Infrastructure Change

### Details

Review tsconfig following some local build problems
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -49,8 +49,8 @@
     "typescript-eslint": "^8.46.2"
   },
   "dependencies": {
-    "@PrescriptionStatusUpdate_common/commonTypes": "^1.0.0",
-    "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0",
+    "@psu-common/commonTypes": "^1.0.0",
+    "@psu-common/middyErrorHandler": "^1.0.0",
     "esbuild": "^0.25.11"
   }
 }
diff --git a/packages/capabilityStatement/package.json b/packages/capabilityStatement/package.json
@@ -21,6 +21,6 @@
     "@nhs/fhir-middy-error-handler": "^2.1.55"
   },
   "devDependencies": {
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0"
+    "@psu-common/testing": "^1.0.0"
   }
 }
diff --git a/packages/capabilityStatement/tests/test-handler.test.ts b/packages/capabilityStatement/tests/test-handler.test.ts
@@ -8,7 +8,7 @@ import {
   jest
 } from "@jest/globals"
 import capabilityStatement from "../src/apim-medicines-prescriptionstatusupdate.json"
-import {mockAPIGatewayProxyEvent, mockContext} from "@PrescriptionStatusUpdate_common/testing"
+import {mockAPIGatewayProxyEvent, mockContext} from "@psu-common/testing"
 
 describe("Unit test for app handler", function () {
   it("verifies successful response with no params", async () => {
diff --git a/packages/checkPrescriptionStatusUpdates/package.json b/packages/checkPrescriptionStatusUpdates/package.json
@@ -21,9 +21,9 @@
     "@middy/core": "^6.4.5",
     "@middy/http-header-normalizer": "^6.4.5",
     "@middy/input-output-logger": "^6.4.5",
-    "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0"
+    "@psu-common/middyErrorHandler": "^1.0.0"
   },
   "devDependencies": {
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0"
+    "@psu-common/testing": "^1.0.0"
   }
 }
diff --git a/packages/checkPrescriptionStatusUpdates/src/checkPrescriptionStatusUpdates.ts b/packages/checkPrescriptionStatusUpdates/src/checkPrescriptionStatusUpdates.ts
@@ -5,7 +5,7 @@ import middy from "@middy/core"
 import inputOutputLogger from "@middy/input-output-logger"
 import httpHeaderNormalizer from "@middy/http-header-normalizer"
 import {getItemStatusUpdates} from "./dynamoDBclient"
-import {MiddyErrorHandler} from "@PrescriptionStatusUpdate_common/middyErrorHandler"
+import {MiddyErrorHandler} from "@psu-common/middyErrorHandler"
 import {InputData} from "./types"
 
 const MIN_RESULTS_RETURNED = parseInt(process.env.MIN_RESULTS_RETURNED) || 5
diff --git a/packages/checkPrescriptionStatusUpdates/tests/testHander.test.ts b/packages/checkPrescriptionStatusUpdates/tests/testHander.test.ts
@@ -7,7 +7,7 @@ import {
 
 import {DynamoDBDocumentClient} from "@aws-sdk/lib-dynamodb"
 import {handler} from "../src/checkPrescriptionStatusUpdates"
-import {mockAPIGatewayProxyEvent, mockContext} from "@PrescriptionStatusUpdate_common/testing"
+import {mockAPIGatewayProxyEvent, mockContext} from "@psu-common/testing"
 
 const defaultItem = {
   ApplicationName: "unknown",
diff --git a/packages/checkPrescriptionStatusUpdates/tsconfig.json b/packages/checkPrescriptionStatusUpdates/tsconfig.json
@@ -7,7 +7,10 @@
     "noEmit": true,
     "strict": false
   },
-  "references": [{"path": "../common/testing"}],
+  "references": [
+    {"path": "../common/testing"},
+    {"path": "../common/middyErrorHandler"}
+  ],
   "include": ["src/**/*", "tests/**/*"],
   "exclude": ["node_modules"]
 }
diff --git a/packages/common/commonTypes/package.json b/packages/common/commonTypes/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@PrescriptionStatusUpdate_common/commonTypes",
+  "name": "@psu-common/commonTypes",
   "version": "1.0.0",
   "description": "Common type resources",
   "author": "NHS Digital",
diff --git a/packages/common/middyErrorHandler/package.json b/packages/common/middyErrorHandler/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@PrescriptionStatusUpdate_common/middyErrorHandler",
+  "name": "@psu-common/middyErrorHandler",
   "version": "1.0.0",
   "description": "Common module for a partial middyErrorHandler",
   "author": "NHS Digital",
@@ -18,6 +18,6 @@
   },
   "devDependencies": {
     "@middy/core": "^6.4.5",
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0"
+    "@psu-common/testing": "^1.0.0"
   }
 }
diff --git a/packages/common/middyErrorHandler/tests/testErrorHandler.test.ts b/packages/common/middyErrorHandler/tests/testErrorHandler.test.ts
@@ -2,7 +2,7 @@
 import {MiddyErrorHandler} from "../src/errorHandler"
 import middy from "@middy/core"
 import {expect, jest} from "@jest/globals"
-import {mockContext} from "@PrescriptionStatusUpdate_common/testing"
+import {mockContext} from "@psu-common/testing"
 
 const mockEvent = {
   foo: "bar"
diff --git a/packages/common/testing/package.json b/packages/common/testing/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@PrescriptionStatusUpdate_common/testing",
+  "name": "@psu-common/testing",
   "version": "1.0.0",
   "description": "Common resources for testing prescription status update",
   "author": "NHS Digital",
diff --git a/packages/gsul/package.json b/packages/gsul/package.json
@@ -22,7 +22,7 @@
     "@middy/core": "^6.4.5",
     "@middy/input-output-logger": "^6.4.5",
     "@middy/validator": "6.4.1",
-    "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0",
+    "@psu-common/middyErrorHandler": "^1.0.0",
     "json-schema-to-ts": "^3.1.1"
   }
 }
diff --git a/packages/gsul/src/getStatusUpdates.ts b/packages/gsul/src/getStatusUpdates.ts
@@ -5,7 +5,7 @@ import middy from "@middy/core"
 import inputOutputLogger from "@middy/input-output-logger"
 import validator from "@middy/validator"
 import {transpileSchema} from "@middy/validator/transpile"
-import {MiddyErrorHandler} from "@PrescriptionStatusUpdate_common/middyErrorHandler"
+import {MiddyErrorHandler} from "@psu-common/middyErrorHandler"
 import {getItemsUpdatesForPrescription} from "./dynamoDBclient.ts"
 import {requestSchema, requestType, inputPrescriptionType} from "./schema/request.ts"
 import {responseType, outputPrescriptionType, itemType} from "./schema/response.ts"
diff --git a/packages/gsul/tsconfig.json b/packages/gsul/tsconfig.json
@@ -7,7 +7,9 @@
     "noEmit": true,
     "strict": false
   },
-  "references": [],
+  "references": [
+    {"path": "../common/middyErrorHandler"}
+  ],
   "include": ["src/**/*", "tests/**/*"],
   "exclude": ["node_modules"]
 }
diff --git a/packages/nhsNotifyLambda/package.json b/packages/nhsNotifyLambda/package.json
@@ -27,7 +27,7 @@
     "nock": "^14.0.10"
   },
   "devDependencies": {
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0",
+    "@psu-common/testing": "^1.0.0",
     "axios-mock-adapter": "^2.1.0"
   }
 }
diff --git a/packages/nhsNotifyLambda/src/utils/dynamo.ts b/packages/nhsNotifyLambda/src/utils/dynamo.ts
@@ -2,7 +2,7 @@ import {DynamoDBClient, QueryCommand} from "@aws-sdk/client-dynamodb"
 import {DynamoDBDocumentClient, PutCommand} from "@aws-sdk/lib-dynamodb"
 import {Logger} from "@aws-lambda-powertools/logger"
 
-import {LastNotificationStateType, NotifyDataItem} from "@PrescriptionStatusUpdate_common/commonTypes"
+import {LastNotificationStateType, NotifyDataItem} from "@psu-common/commonTypes"
 
 import {TTL_DELTA} from "./constants"
 import {NotifyDataItemMessage} from "./types"
diff --git a/packages/nhsNotifyLambda/src/utils/sqs.ts b/packages/nhsNotifyLambda/src/utils/sqs.ts
@@ -7,7 +7,7 @@ import {
 } from "@aws-sdk/client-sqs"
 import {Logger} from "@aws-lambda-powertools/logger"
 
-import {NotifyDataItem} from "@PrescriptionStatusUpdate_common/commonTypes"
+import {NotifyDataItem} from "@psu-common/commonTypes"
 
 import {NotifyDataItemMessage} from "./types"
 import {chunkArray} from "./notify"
diff --git a/packages/nhsNotifyLambda/src/utils/types.ts b/packages/nhsNotifyLambda/src/utils/types.ts
@@ -1,5 +1,5 @@
 import {Message} from "@aws-sdk/client-sqs"
-import {NotifyDataItem} from "@PrescriptionStatusUpdate_common/commonTypes"
+import {NotifyDataItem} from "@psu-common/commonTypes"
 
 // This is an extension of the SQS message interface, which explicitly parses the PSUDataItem
 // and helps track the nhs notify results
diff --git a/packages/nhsNotifyLambda/tests/testHelpers.ts b/packages/nhsNotifyLambda/tests/testHelpers.ts
@@ -2,7 +2,7 @@ import {jest} from "@jest/globals"
 
 import * as sqs from "@aws-sdk/client-sqs"
 
-import {PSUDataItem} from "@PrescriptionStatusUpdate_common/commonTypes"
+import {PSUDataItem} from "@psu-common/commonTypes"
 import {NotifyDataItemMessage} from "../src/utils"
 
 // Similarly mock the SQS client
diff --git a/packages/nhsNotifyLambda/tests/testNhsNotifyLambda.test.ts b/packages/nhsNotifyLambda/tests/testNhsNotifyLambda.test.ts
@@ -57,7 +57,7 @@ beforeAll(async () => {
   ({lambdaHandler} = await import("../src/nhsNotifyLambda"))
 })
 
-import {mockEventBridgeEvent} from "@PrescriptionStatusUpdate_common/testing"
+import {mockEventBridgeEvent} from "@psu-common/testing"
 
 const ORIGINAL_ENV = {...process.env}
 
diff --git a/packages/nhsNotifyLambda/tsconfig.json b/packages/nhsNotifyLambda/tsconfig.json
@@ -4,7 +4,9 @@
     "rootDir": ".",
     "outDir": "lib"
   },
-  "references": [],
+  "references": [
+    {"path": "../common/testing"}
+  ],
   "include": ["src/**/*", "tests/**/*"],
   "exclude": ["node_modules"]
 }
diff --git a/packages/nhsNotifyUpdateCallback/package.json b/packages/nhsNotifyUpdateCallback/package.json
@@ -24,7 +24,7 @@
     "axios": "^1.12.2"
   },
   "devDependencies": {
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0",
+    "@psu-common/testing": "^1.0.0",
     "axios-mock-adapter": "^2.1.0"
   }
 }
diff --git a/packages/nhsNotifyUpdateCallback/src/helpers.ts b/packages/nhsNotifyUpdateCallback/src/helpers.ts
@@ -7,7 +7,7 @@ import {getSecret} from "@aws-lambda-powertools/parameters/secrets"
 
 import {createHmac, timingSafeEqual} from "crypto"
 
-import {LastNotificationStateType, NotificationUpdate} from "@PrescriptionStatusUpdate_common/commonTypes"
+import {LastNotificationStateType, NotificationUpdate} from "@psu-common/commonTypes"
 
 import {CallbackResource, CallbackResponse, CallbackType} from "./types"
 
diff --git a/packages/nhsNotifyUpdateCallback/tsconfig.json b/packages/nhsNotifyUpdateCallback/tsconfig.json
@@ -4,7 +4,9 @@
     "rootDir": ".",
     "outDir": "lib"
   },
-  "references": [],
+  "references": [
+    {"path": "../common/testing"}
+  ],
   "include": ["src/**/*", "tests/**/*"],
   "exclude": ["node_modules"]
 }
diff --git a/packages/psuRestoreValidationLambda/package.json b/packages/psuRestoreValidationLambda/package.json
@@ -19,11 +19,11 @@
     "@aws-sdk/client-dynamodb": "^3.902.0",
     "@aws-sdk/lib-dynamodb": "^3.917.0",
     "@middy/input-output-logger": "^6.3.0",
-    "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0",
+    "@psu-common/middyErrorHandler": "^1.0.0",
     "aws-lambda": "^1.0.7"
   },
   "devDependencies": {
     "@middy/core": "^6.2.3",
-    "@PrescriptionStatusUpdate_common/testing": "^1.0.0"
+    "@psu-common/testing": "^1.0.0"
   }
 }
diff --git a/packages/psuRestoreValidationLambda/src/handler.ts b/packages/psuRestoreValidationLambda/src/handler.ts
@@ -6,7 +6,7 @@ import {DynamoDBClient} from "@aws-sdk/client-dynamodb"
 import {DynamoDBDocumentClient} from "@aws-sdk/lib-dynamodb"
 import middy from "@middy/core"
 import inputOutputLogger from "@middy/input-output-logger"
-import {MiddyErrorHandler} from "@PrescriptionStatusUpdate_common/middyErrorHandler"
+import {MiddyErrorHandler} from "@psu-common/middyErrorHandler"
 import {compareTables} from "./compareTable"
 import {backupEventCompletedDetail} from "./types"
 
diff --git a/packages/psuRestoreValidationLambda/tests/handler.test.ts b/packages/psuRestoreValidationLambda/tests/handler.test.ts
diff --git a/packages/psuRestoreValidationLambda/tsconfig.json b/packages/psuRestoreValidationLambda/tsconfig.json
diff --git a/packages/statusLambda/package.json b/packages/statusLambda/package.json
diff --git a/packages/statusLambda/tests/test-handler.test.ts b/packages/statusLambda/tests/test-handler.test.ts
diff --git a/packages/statusLambda/tsconfig.json b/packages/statusLambda/tsconfig.json
diff --git a/packages/updatePrescriptionStatus/src/updatePrescriptionStatus.ts b/packages/updatePrescriptionStatus/src/updatePrescriptionStatus.ts
diff --git a/packages/updatePrescriptionStatus/src/utils/databaseClient.ts b/packages/updatePrescriptionStatus/src/utils/databaseClient.ts
diff --git a/packages/updatePrescriptionStatus/src/utils/sqsClient.ts b/packages/updatePrescriptionStatus/src/utils/sqsClient.ts
diff --git a/packages/updatePrescriptionStatus/src/validation/notificationSiteAndSystemFilters.ts b/packages/updatePrescriptionStatus/src/validation/notificationSiteAndSystemFilters.ts
diff --git a/packages/updatePrescriptionStatus/tests/utils/testUtils.ts b/packages/updatePrescriptionStatus/tests/utils/testUtils.ts
diff --git a/tsconfig.defaults.json b/tsconfig.defaults.json

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,8 @@`
`49`	`49`	`"typescript-eslint": "^8.46.2"`
`50`	`50`	`},`
`51`	`51`	`"dependencies": {`
`52`		`- "@PrescriptionStatusUpdate_common/commonTypes": "^1.0.0",`
`53`		`- "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0",`
	`52`	`+ "@psu-common/commonTypes": "^1.0.0",`
	`53`	`+ "@psu-common/middyErrorHandler": "^1.0.0",`
`54`	`54`	`"esbuild": "^0.25.11"`
`55`	`55`	`}`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,6 @@`
`21`	`21`	`"@nhs/fhir-middy-error-handler": "^2.1.55"`
`22`	`22`	`},`
`23`	`23`	`"devDependencies": {`
`24`		`- "@PrescriptionStatusUpdate_common/testing": "^1.0.0"`
	`24`	`+ "@psu-common/testing": "^1.0.0"`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,9 @@`
`21`	`21`	`"@middy/core": "^6.4.5",`
`22`	`22`	`"@middy/http-header-normalizer": "^6.4.5",`
`23`	`23`	`"@middy/input-output-logger": "^6.4.5",`
`24`		`- "@PrescriptionStatusUpdate_common/middyErrorHandler": "^1.0.0"`
	`24`	`+ "@psu-common/middyErrorHandler": "^1.0.0"`
`25`	`25`	`},`
`26`	`26`	`"devDependencies": {`
`27`		`- "@PrescriptionStatusUpdate_common/testing": "^1.0.0"`
	`27`	`+ "@psu-common/testing": "^1.0.0"`
`28`	`28`	`}`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "name": "@PrescriptionStatusUpdate_common/commonTypes",`
	`2`	`+ "name": "@psu-common/commonTypes",`
`3`	`3`	`"version": "1.0.0",`
`4`	`4`	`"description": "Common type resources",`
`5`	`5`	`"author": "NHS Digital",`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "name": "@PrescriptionStatusUpdate_common/middyErrorHandler",`
	`2`	`+ "name": "@psu-common/middyErrorHandler",`
`3`	`3`	`"version": "1.0.0",`
`4`	`4`	`"description": "Common module for a partial middyErrorHandler",`
`5`	`5`	`"author": "NHS Digital",`
`@@ -18,6 +18,6 @@`
`18`	`18`	`},`
`19`	`19`	`"devDependencies": {`
`20`	`20`	`"@middy/core": "^6.4.5",`
`21`		`- "@PrescriptionStatusUpdate_common/testing": "^1.0.0"`
	`21`	`+ "@psu-common/testing": "^1.0.0"`
`22`	`22`	`}`
`23`	`23`	`}`