chore: msg code as structured data not text

Author: tstephen-nhs

packages/common/utilities/src/index.ts

@@ -1,7 +1,7 @@
 export {testPrescriptionsConfig, TestPrescriptionsConfig, getTestPrescriptions} from "./testConfig.js"
 export const LOG_MESSAGES = {
   PSU0001: "Transitioning item status.",
-  PSU0002: "PSU0002 Notify request",
+  PSU0002: "Notify request",
   PSU0003: "Updated notification state"
 } as const
 

packages/nhsNotifyLambda/src/utils/notify.ts

@@ -124,9 +124,12 @@ function logNotificationRequest(logger: Logger,
     messageStatus: messageStatus
   })
   // Log each message individually for less memory intensive reporting
+  const code = Object.keys(LOG_MESSAGES)
+    .find(key => LOG_MESSAGES[key as keyof typeof LOG_MESSAGES] === LOG_MESSAGES.PSU0002)
   messages.forEach((message, index) => {
     const correspondingData = data.find(item => item.messageReference === message.messageReference)
     logger.info(LOG_MESSAGES.PSU0002, {
+      reportCode: code,
       messageBatchReference,
       messageIndex: index,
       nhsNumber: message.recipient.nhsNumber,

packages/nhsNotifyLambda/tests/testUtils.test.ts

@@ -845,8 +845,9 @@ describe("NHS notify lambda helper functions", () => {
         })
       )
       expect(infoSpy).toHaveBeenCalledWith(
-        "PSU0002 Notify request",
+        LOG_MESSAGES.PSU0002,
         expect.objectContaining({
+          reportCode: "PSU0002",
           messageBatchReference: expect.any(String),
           messageIndex: expect.any(Number)
         })