Fix: [AEA-5861] - Temp fully disable activity code B0401 (#1429)

## Summary
- Routine Change
- ⚠️ Potential issues that might be caused by this change

### Details
- Temporarily fully disabled access for activity code B0401, any
associated baseline role codes and any child activity codes
- Updates regression test tag

---------

Co-authored-by: jonathanwelch1-nhs <[email protected]>

Author: Orkastrated

.github/workflows/run_regression_tests.yml

@@ -68,37 +68,37 @@ jobs:
           VERSION_NUMBER: ${{ inputs.VERSION_NUMBER }}
           GITHUB-TOKEN: ${{ steps.generate-token.outputs.token }}
         run: |
-              if [[ "$TARGET_ENVIRONMENT" != "prod" && "$TARGET_ENVIRONMENT" != "ref" ]]; then
-                REGRESSION_TEST_REPO_TAG="v3.4.12" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name
-                REGRESSION_TEST_WORKFLOW_TAG="v3.4.12" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG
+          if [[ "$TARGET_ENVIRONMENT" != "prod" && "$TARGET_ENVIRONMENT" != "ref" ]]; then
+            REGRESSION_TEST_REPO_TAG="v3.4.24" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name
+            REGRESSION_TEST_WORKFLOW_TAG="v3.4.24" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG
 
-                if [[ -z "$REGRESSION_TEST_REPO_TAG" || -z "$REGRESSION_TEST_WORKFLOW_TAG" ]]; then
-                  echo "Error: One or both tag variables are not set" >&2
-                  exit 1
-                fi
+            if [[ -z "$REGRESSION_TEST_REPO_TAG" || -z "$REGRESSION_TEST_WORKFLOW_TAG" ]]; then
+              echo "Error: One or both tag variables are not set" >&2
+              exit 1
+            fi
 
-                # HELPER IF STATEMENT - It will automatically determine the correct Git URL to use based on the REGRESSION_TEST_WORKFLOW_TAG value
-                if [[ "$REGRESSION_TEST_WORKFLOW_TAG" =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)$ ]]; then
-                  echo "REGRESSION_TEST_WORKFLOW_TAG is a version tag, using tag link"
-                  curl "https://raw.githubusercontent.com/NHSDigital/electronic-prescription-service-api-regression-tests/refs/tags/${REGRESSION_TEST_WORKFLOW_TAG}/scripts/run_regression_tests.py" -o run_regression_tests.py
-                else
-                  echo "REGRESSION_TEST_WORKFLOW_TAG doesn't look like a version tag, using branch link"
-                  curl "https://raw.githubusercontent.com/NHSDigital/electronic-prescription-service-api-regression-tests/refs/heads/${REGRESSION_TEST_REPO_TAG}/scripts/run_regression_tests.py" -o run_regression_tests.py
-                fi
+            # HELPER IF STATEMENT - It will automatically determine the correct Git URL to use based on the REGRESSION_TEST_WORKFLOW_TAG value
+            if [[ "$REGRESSION_TEST_WORKFLOW_TAG" =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)$ ]]; then
+              echo "REGRESSION_TEST_WORKFLOW_TAG is a version tag, using tag link"
+              curl "https://raw.githubusercontent.com/NHSDigital/electronic-prescription-service-api-regression-tests/refs/tags/${REGRESSION_TEST_WORKFLOW_TAG}/scripts/run_regression_tests.py" -o run_regression_tests.py
+            else
+              echo "REGRESSION_TEST_WORKFLOW_TAG doesn't look like a version tag, using branch link"
+              curl "https://raw.githubusercontent.com/NHSDigital/electronic-prescription-service-api-regression-tests/refs/heads/${REGRESSION_TEST_REPO_TAG}/scripts/run_regression_tests.py" -o run_regression_tests.py
+            fi
 
-                if [[ ! -f run_regression_tests.py ]]; then
-                  echo "Error: run_regression_tests.py not found" >&2
-                  exit 1
-                fi
+            if [[ ! -f run_regression_tests.py ]]; then
+              echo "Error: run_regression_tests.py not found" >&2
+              exit 1
+            fi
 
-                poetry install
-                echo Running regression tests in the "$TARGET_ENVIRONMENT" environment
-                poetry run python -u run_regression_tests.py \
-                --env="$TARGET_ENVIRONMENT" \
-                --pr_label="$VERSION_NUMBER" \
-                --token=${{ steps.generate-token.outputs.token }} \
-                --is_called_from_github=true \
-                --product=CPTS-UI \
-                --regression_test_repo_tag "${REGRESSION_TEST_REPO_TAG}" \
-                --regression_test_workflow_tag "${REGRESSION_TEST_WORKFLOW_TAG}"
-              fi
+            poetry install
+            echo Running regression tests in the "$TARGET_ENVIRONMENT" environment
+            poetry run python -u run_regression_tests.py \
+            --env="$TARGET_ENVIRONMENT" \
+            --pr_label="$VERSION_NUMBER" \
+            --token=${{ steps.generate-token.outputs.token }} \
+            --is_called_from_github=true \
+            --product=CPTS-UI \
+            --regression_test_repo_tag "${REGRESSION_TEST_REPO_TAG}" \
+            --regression_test_workflow_tag "${REGRESSION_TEST_WORKFLOW_TAG}"
+          fi

packages/common/dynamoFunctions/src/rbacHierarchy.ts

@@ -226,6 +226,7 @@ const B0429: ActivityCode = {
   childActivityCodes: {}
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const B0401: ActivityCode = {
   baselineRoleCodes: [
     "R0260", "R0270", "R6200", "R6300", "R0370",
@@ -245,7 +246,7 @@ const B0401: ActivityCode = {
   }
 }
 
-export const rbacHierarchy: RBACHierarchy = {B0570, B0278, B0401}
+export const rbacHierarchy: RBACHierarchy = {B0570, B0278/*, B0401*/} // temp disable all of B0401
 
 const extractAccessCodes = (activityCode: ActivityCode): Array<Array<string>> => {
   let acceptedRoleCodes: Array<string> = []

packages/common/dynamoFunctions/tests/userUtils.test.ts

@@ -289,14 +289,15 @@ describe("extractRoleInformation", () => {
           role_name: "User Role",
           activity_codes: ["B0278"] // Also has access
         },
-        {
-          org_code: "ORG2",
-          person_orgid: "PORG2",
-          person_roleid: "ROLE2",
-          role_code: "S000:G000:RC3",
-          role_name: "User Role",
-          activity_codes: ["B0401"] // Also has access
-        },
+        //TODO: remove or reinstate depending on decision on B0401
+        // {
+        //   org_code: "ORG2",
+        //   person_orgid: "PORG2",
+        //   person_roleid: "ROLE2",
+        //   role_code: "S000:G000:RC3",
+        //   role_name: "User Role",
+        //   activity_codes: ["B0401"] // Also has access
+        // },
         {
           org_code: "ORG3",
           person_orgid: "PORG3",
@@ -326,7 +327,8 @@ describe("extractRoleInformation", () => {
     const result = extractRoleInformation(mockUserInfo, selectedRoleId, mockLogger as Logger)
 
     // Verify roles with access (should include B0570, B0278 and B0401)
-    expect(result.roles_with_access).toHaveLength(3)
+    // expect(result.roles_with_access).toHaveLength(3) //TODO: remove or reinstate depending on decision on B0401
+    expect(result.roles_with_access).toHaveLength(2)
     expect(result.roles_without_access).toHaveLength(1)
   })