Skip to content

Commit a18c659

Browse files
committed
Misc. fixes
1 parent 51a594f commit a18c659

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.devcontainer/devcontainer.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
"source=${env:HOME}${env:USERPROFILE}/.gnupg,target=/home/vscode/.gnupg,type=bind",
1515
"source=${env:HOME}${env:USERPROFILE}/.npmrc,target=/home/vscode/.npmrc,type=bind"
1616
],
17+
"runArgs": [
18+
"--network=host"
19+
],
1720
"remoteEnv": { "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" },
1821
"postAttachCommand": "docker build -f https://raw.githubusercontent.com/NHSDigital/eps-workflow-quality-checks/refs/tags/v4.0.4/dockerfiles/nhsd-git-secrets.dockerfile -t git-secrets . && poetry run pre-commit install --install-hooks -f",
1922
"features": {

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,12 @@ export NEXT_PUBLIC_userPoolId="eu-west-2_deadbeef"
9898
export LOCAL_DEV=true
9999
100100
# DON'T TOUCH!
101-
export BASE_PATH="/site"
102-
export API_DOMAIN_OVERRIDE=https://${SERVICE_NAME}.dev.eps.national.nhs.uk/
101+
export NEXT_PUBLIC_TARGET_ENVIRONMENT=dev # enables mock auth
102+
export BASE_PATH="/site" # Hosts the site at `localhost:3000/site`
103+
export API_DOMAIN_OVERRIDE=https://${SERVICE_NAME}.dev.eps.national.nhs.uk/ # Proxies the actual deployed backend for this PR
103104
104105
export NEXT_PUBLIC_hostedLoginDomain=${SERVICE_NAME}.auth.eu-west-2.amazoncognito.com
105-
export NEXT_PUBLIC_redirectSignIn=http://localhost:3000/site/login
106+
export NEXT_PUBLIC_redirectSignIn=http://localhost:3000/site/selectyourrole
106107
export NEXT_PUBLIC_redirectSignOut=http://localhost:3000/site/logout
107108
108109
export NEXT_PUBLIC_COMMIT_ID="Local Development Server"

0 commit comments

Comments
 (0)