Skip to content

Commit da483c7

Browse files
committed
[AEA-5681] fix role code not stipping categories
1 parent b9927f9 commit da483c7

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

packages/common/dynamoFunctions/src/userUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export const extractRoleInformation = (
182182
const roleInfo: RoleDetails = {
183183
role_name: removeRoleCategories(role.role_name),
184184
role_id: role.person_roleid,
185-
role_code: role.role_code,
185+
role_code: removeRoleCategories(role.role_code),
186186
activity_codes: role.activity_codes || [],
187187
org_code: role.org_code,
188188
org_name: getOrgNameFromOrgCode(data, role.org_code)

packages/common/dynamoFunctions/tests/userUtils.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe("extractRoleInformation", () => {
5555
org_code: "ORG1",
5656
person_orgid: "PORG1",
5757
person_roleid: "ROLE1",
58-
role_code: "RC1", // Role code does not have access
58+
role_code: "S000:G000:RC1", // Role code does not have access
5959
role_name: "Perform Pharmacy Activities Role",
6060
activity_codes: ["B0570"] // Parent activity code has access
6161
}
@@ -96,7 +96,7 @@ describe("extractRoleInformation", () => {
9696
org_code: "ORG1",
9797
person_orgid: "PORG1",
9898
person_roleid: "ROLE1",
99-
role_code: "RC1", // Role code does not have access
99+
role_code: "S000:G000:RC1", // Role code does not have access
100100
role_name: "Perform Pharmacy Activities Role",
101101
activity_codes: ["B0572"] // Child activity code of B0570, has access
102102
}
@@ -137,7 +137,7 @@ describe("extractRoleInformation", () => {
137137
org_code: "ORG1",
138138
person_orgid: "PORG1",
139139
person_roleid: "ROLE1",
140-
role_code: "R6300", // Baseline role code has access
140+
role_code: "S000:G000:R6300", // Baseline role code has access
141141
role_name: "Perform Pharmacy Activities Role",
142142
activity_codes: ["AC1"] // activity code does not have access
143143
}
@@ -179,15 +179,15 @@ describe("extractRoleInformation", () => {
179179
org_code: "ORG1",
180180
person_orgid: "PORG1",
181181
person_roleid: "ROLE1",
182-
role_code: "RC1",
182+
role_code: "S000:G000:RC1",
183183
role_name: "Admin Role",
184184
activity_codes: ["B0570"] // Has access
185185
},
186186
{
187187
org_code: "ORG2",
188188
person_orgid: "PORG2",
189189
person_roleid: "ROLE2",
190-
role_code: "RC2",
190+
role_code: "S000:G000:RC2",
191191
role_name: "User Role",
192192
activity_codes: ["OTHER"] // No access
193193
}
@@ -241,7 +241,7 @@ describe("extractRoleInformation", () => {
241241
org_code: "ORG1",
242242
person_orgid: "PORG1",
243243
person_roleid: "ROLE1",
244-
role_code: "RC1",
244+
role_code: "S000:G000:RC1",
245245
role_name: "Admin Role",
246246
activity_codes: ["B0570"] // Has access
247247
}
@@ -277,31 +277,31 @@ describe("extractRoleInformation", () => {
277277
org_code: "ORG1",
278278
person_orgid: "PORG1",
279279
person_roleid: "ROLE1",
280-
role_code: "RC1",
280+
role_code: "S000:G000:RC1",
281281
role_name: "Admin Role",
282282
activity_codes: ["B0570"] // Has access
283283
},
284284
{
285285
org_code: "ORG2",
286286
person_orgid: "PORG2",
287287
person_roleid: "ROLE2",
288-
role_code: "RC2",
288+
role_code: "S000:G000:RC2",
289289
role_name: "User Role",
290290
activity_codes: ["B0278"] // Also has access
291291
},
292292
{
293293
org_code: "ORG2",
294294
person_orgid: "PORG2",
295295
person_roleid: "ROLE2",
296-
role_code: "RC3",
296+
role_code: "S000:G000:RC3",
297297
role_name: "User Role",
298298
activity_codes: ["B0401"] // Also has access
299299
},
300300
{
301301
org_code: "ORG3",
302302
person_orgid: "PORG3",
303303
person_roleid: "ROLE3",
304-
role_code: "RC3",
304+
role_code: "S000:G000:RC3",
305305
role_name: "Guest Role",
306306
activity_codes: ["OTHER"] // No access
307307
}
@@ -371,7 +371,7 @@ describe("extractRoleInformation", () => {
371371
org_code: "ORG1",
372372
person_orgid: "PORG1",
373373
person_roleid: "ROLE1",
374-
role_code: "RC1",
374+
role_code: "S000:G000:RC1",
375375
role_name: "Admin Role",
376376
activity_codes: ["B0570"]
377377
}
@@ -409,7 +409,7 @@ describe("extractRoleInformation", () => {
409409
org_code: "ORG2",
410410
person_orgid: "PORG2",
411411
person_roleid: "ROLE2",
412-
role_code: "RC2",
412+
role_code: "S000:G000:RC2",
413413
role_name: "Valid Role",
414414
activity_codes: ["B0570"]
415415
}
@@ -445,7 +445,7 @@ describe("extractRoleInformation", () => {
445445
org_code: "ORG1",
446446
person_orgid: "PORG1",
447447
person_roleid: "ROLE1",
448-
role_code: "RC1",
448+
role_code: "S000:G000:RC1",
449449
role_name: '"Admin":"Level1":"Super Admin"',
450450
activity_codes: ["B0570"]
451451
}

0 commit comments

Comments
 (0)