Skip to content

Commit dadf0e4

Browse files
committed
do not deploy code on pr
1 parent c578a02 commit dadf0e4

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ jobs:
102102
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
103103
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
104104
LOG_RETENTION_IN_DAYS: 30
105+
DEPLOY_CHANGE: true
105106
secrets:
106107
CDK_PULL_IMAGE_ROLE: ${{ secrets.DEV_CDK_PULL_IMAGE_ROLE }}
107108
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -130,6 +131,7 @@ jobs:
130131
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
131132
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
132133
LOG_RETENTION_IN_DAYS: 30
134+
DEPLOY_CHANGE: true
133135
secrets:
134136
CDK_PULL_IMAGE_ROLE: ${{ secrets.QA_CDK_PULL_IMAGE_ROLE }}
135137
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.QA_CLOUD_FORMATION_DEPLOY_ROLE }}

.github/workflows/pull_request.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,21 @@ jobs:
5353
echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
5454
5555
package_code:
56-
needs: [get_issue_number, get_commit_id]
56+
needs: [quality_checks, get_issue_number, get_commit_id]
5757
uses: ./.github/workflows/cdk_package_code.yml
5858
with:
5959
VERSION_NUMBER: ${{needs.get_issue_number.outputs.issue_number}}
6060
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
6161

62-
release_dev:
63-
needs: [get_issue_number, package_code, get_commit_id]
62+
show_dev_changes:
63+
needs: [quality_checks, get_issue_number, package_code, get_commit_id]
6464
uses: ./.github/workflows/cdk_release_code.yml
6565
with:
6666
TARGET_ENVIRONMENT: dev
6767
VERSION_NUMBER: ${{needs.get_issue_number.outputs.issue_number}}
6868
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
6969
LOG_RETENTION_IN_DAYS: 30
70-
DEPLOY_CHANGE: true
70+
DEPLOY_CHANGE: false
7171
secrets:
7272
CDK_PULL_IMAGE_ROLE: ${{ secrets.DEV_CDK_PULL_IMAGE_ROLE }}
7373
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}

.github/workflows/release.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ jobs:
121121
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
122122
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
123123
LOG_RETENTION_IN_DAYS: 30
124+
DEPLOY_CHANGE: true
124125
secrets:
125126
CDK_PULL_IMAGE_ROLE: ${{ secrets.DEV_CDK_PULL_IMAGE_ROLE }}
126127
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -148,6 +149,7 @@ jobs:
148149
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
149150
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
150151
LOG_RETENTION_IN_DAYS: 30
152+
DEPLOY_CHANGE: true
151153
secrets:
152154
CDK_PULL_IMAGE_ROLE: ${{ secrets.REF_CDK_PULL_IMAGE_ROLE }}
153155
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.REF_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -160,6 +162,7 @@ jobs:
160162
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
161163
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
162164
LOG_RETENTION_IN_DAYS: 30
165+
DEPLOY_CHANGE: true
163166
secrets:
164167
CDK_PULL_IMAGE_ROLE: ${{ secrets.QA_CDK_PULL_IMAGE_ROLE }}
165168
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.QA_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -172,6 +175,7 @@ jobs:
172175
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
173176
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
174177
LOG_RETENTION_IN_DAYS: 30
178+
DEPLOY_CHANGE: true
175179
secrets:
176180
CDK_PULL_IMAGE_ROLE: ${{ secrets.INT_CDK_PULL_IMAGE_ROLE }}
177181
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.INT_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -184,6 +188,7 @@ jobs:
184188
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
185189
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
186190
LOG_RETENTION_IN_DAYS: 30
191+
DEPLOY_CHANGE: true
187192
secrets:
188193
CDK_PULL_IMAGE_ROLE: ${{ secrets.PROD_CDK_PULL_IMAGE_ROLE }}
189194
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_DEPLOY_ROLE }}

0 commit comments

Comments
 (0)