Skip to content

Commit 3ce8a1e

Browse files
committed
feat(dos-search): FTRS-9999 tidy up and pr comments
1 parent de84cfb commit 3ce8a1e

File tree

6 files changed

+5
-7
lines changed

6 files changed

+5
-7
lines changed

infrastructure/stacks/account_wide/vpce.tf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,3 @@ resource "aws_vpc_endpoint" "interface_vpce" {
4747
Name = "${local.resource_prefix}-${each.key}-vpc-endpoint"
4848
}
4949
}
50-
51-

infrastructure/stacks/slack_notifier/security_group.tf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,3 @@ resource "aws_vpc_security_group_egress_rule" "to_slack" {
3030
from_port = var.https_port
3131
to_port = var.https_port
3232
}
33-
34-
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
"""Slack notification package for CloudWatch alarms.""" # noqa: N999
1+
"""Slack notification package for CloudWatch alarms."""

services/slack-notifier/functions/slack_formatter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ def build_slack_message(alarm_data: dict[str, Any]) -> dict[str, Any]:
111111
lambda_logs_url = build_lambda_logs_url(lambda_name, aws_region)
112112
lambda_metrics_url = build_lambda_metrics_url(lambda_name, aws_region)
113113

114+
#TODO: Will be updated as part of FTRS-765
114115
api_path = "/Organization" # Needs to be fetched from relevant data source
115116
api_service = "DoS Search" # Needs to be fetched from relevant data source
116117

services/slack-notifier/pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ authors = [
88
readme = "README.md"
99
requires-python = ">=3.12,<3.13"
1010
dependencies = [
11-
"boto3 (>=1.37.24,<2.0.0)",
11+
"aws-lambda-powertools (>=3.12.0,<3.13.0)",
12+
"urllib3 (>=2.0.0,<3.0.0)",
1213
]
1314

1415
[build-system]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
# noqa: N999
1+

0 commit comments

Comments
 (0)