-
Notifications
You must be signed in to change notification settings - Fork 4
Expand file tree
/
Copy pathtest_convert_to_flat_json.py
More file actions
1299 lines (1118 loc) · 54.5 KB
/
test_convert_to_flat_json.py
File metadata and controls
1299 lines (1118 loc) · 54.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import json
import unittest
from copy import deepcopy
from unittest.mock import patch, Mock
from moto import mock_dynamodb, mock_sqs
from boto3 import resource as boto3_resource
from tests.utils_for_converter_tests import ValuesForTests, ErrorValuesForTests
from SchemaParser import SchemaParser
from Converter import Converter
from ConversionChecker import ConversionChecker, RecordError
from common.mappings import ActionFlag, Operation, EventName
import ExceptionMessages
MOCK_ENV_VARS = {
"AWS_SQS_QUEUE_URL": "https://sqs.eu-west-2.amazonaws.com/123456789012/test-queue",
"DELTA_TABLE_NAME": "immunisation-batch-internal-dev-audit-test-table",
"SOURCE": "test-source",
}
request_json_data = ValuesForTests.json_data
with patch.dict("os.environ", MOCK_ENV_VARS):
from delta import handler, Converter
class TestRecordError(unittest.TestCase):
def test_fields_and_str(self):
err = RecordError(
code=5,
message="Test failed",
details="Something went wrong"
)
# The attributes should round‑trip
self.assertEqual(err.code, 5)
self.assertEqual(err.message, "Test failed")
self.assertEqual(err.details, "Something went wrong")
# __repr__ and __str__ both produce the tuple repr
expected = "(5, 'Test failed', 'Something went wrong')"
self.assertEqual(str(err), expected)
self.assertEqual(repr(err), expected)
def test_default_args(self):
# If you omit arguments they default to None
err = RecordError()
self.assertIsNone(err.code)
self.assertIsNone(err.message)
self.assertIsNone(err.details)
# repr shows three Nones
self.assertEqual(str(err), "(None, None, None)")
@patch.dict("os.environ", MOCK_ENV_VARS, clear=True)
@mock_dynamodb
@mock_sqs
class TestConvertToFlatJson(unittest.TestCase):
maxDiff = None
def setUp(self):
"""Set up mock DynamoDB table."""
self.dynamodb_resource = boto3_resource("dynamodb", "eu-west-2")
self.table = self.dynamodb_resource.create_table(
TableName="immunisation-batch-internal-dev-audit-test-table",
KeySchema=[
{"AttributeName": "PK", "KeyType": "HASH"},
],
AttributeDefinitions=[
{"AttributeName": "PK", "AttributeType": "S"},
{"AttributeName": "Operation", "AttributeType": "S"},
{"AttributeName": "IdentifierPK", "AttributeType": "S"},
{"AttributeName": "SupplierSystem", "AttributeType": "S"},
],
ProvisionedThroughput={"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
GlobalSecondaryIndexes=[
{
"IndexName": "IdentifierGSI",
"KeySchema": [{"AttributeName": "IdentifierPK", "KeyType": "HASH"}],
"Projection": {"ProjectionType": "ALL"},
"ProvisionedThroughput": {"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
},
{
"IndexName": "PatientGSI",
"KeySchema": [
{"AttributeName": "Operation", "KeyType": "HASH"},
{"AttributeName": "SupplierSystem", "KeyType": "RANGE"},
],
"Projection": {"ProjectionType": "ALL"},
"ProvisionedThroughput": {"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
},
],
)
self.logger_info_patcher = patch("logging.Logger.info")
self.mock_logger_info = self.logger_info_patcher.start()
self.logger_exception_patcher = patch("logging.Logger.exception")
self.mock_logger_exception = self.logger_exception_patcher.start()
self.firehose_logger_patcher = patch("delta.firehose_logger")
self.mock_firehose_logger = self.firehose_logger_patcher.start()
def tearDown(self):
self.logger_exception_patcher.stop()
self.logger_info_patcher.stop()
self.mock_firehose_logger.stop()
@staticmethod
def get_event(event_name=EventName.CREATE, operation="operation", supplier="EMIS"):
"""Returns test event data."""
return ValuesForTests.get_event(event_name, operation, supplier)
def assert_dynamodb_record(self, operation_flag, action_flag, items, expected_values, expected_imms, response):
"""
Asserts that a record with the expected structure exists in DynamoDB.
Ignores dynamically generated fields like PK, DateTimeStamp, and ExpiresAt.
Ensures that the 'Imms' field matches exactly.
"""
self.assertTrue(response)
filtered_items = [
{k: v for k, v in item.items() if k not in ["PK", "DateTimeStamp", "ExpiresAt"]}
for item in items
if item.get("Operation") == operation_flag
and item.get("Imms", {}).get("ACTION_FLAG") == action_flag
]
self.assertGreater(len(filtered_items), 0, f"No matching item found for {operation_flag}")
imms_data = filtered_items[0]["Imms"]
self.assertIsInstance(imms_data, dict)
self.assertGreater(len(imms_data), 0)
for key, expected_value in expected_values.items():
self.assertIn(key, filtered_items[0], f"{key} is missing")
if (filtered_items[0][key] != expected_value):
print (f"{key} mismatch {filtered_items[0][key]} != {expected_value}")
# Check Imms JSON structure matches exactly
self.assertEqual(imms_data, expected_imms, "Imms data does not match expected JSON structure")
for key, expected_value in expected_values.items():
self.assertIn(key, filtered_items[0], f"{key} is missing")
self.assertEqual(filtered_items[0][key], expected_value, f"{key} mismatch")
def test_fhir_converter_json_direct_data(self):
"""it should convert fhir json data to flat json"""
json_data = json.dumps(ValuesForTests.json_data)
FHIRConverter = Converter(json_data)
FlatFile = FHIRConverter.runConversion(ValuesForTests.json_data, False, True)
flatJSON = json.dumps(FlatFile)
expected_imms_value = deepcopy(ValuesForTests.expected_imms2) # UPDATE is currently the default action-flag
expected_imms = json.dumps(expected_imms_value)
self.assertEqual(flatJSON, expected_imms)
errorRecords = FHIRConverter.getErrorRecords()
self.assertEqual(len(errorRecords), 0)
def test_fhir_converter_json_error_scenario(self):
"""it should convert fhir json data to flat json - error scenarios"""
error_test_cases = [ErrorValuesForTests.missing_json, ErrorValuesForTests.json_dob_error]
for test_case in error_test_cases:
json_data = json.dumps(test_case)
FHIRConverter = Converter(json_data)
FHIRConverter.runConversion(ValuesForTests.json_data, False, True)
errorRecords = FHIRConverter.getErrorRecords()
# Check if bad data creates error records
self.assertTrue(len(errorRecords) > 0)
def test_handler_imms_convert_to_flat_json(self):
"""Test that the Imms field contains the correct flat JSON data for CREATE, UPDATE, and DELETE operations."""
expected_action_flags = [
{"Operation": Operation.CREATE, "EXPECTED_ACTION_FLAG": ActionFlag.CREATE},
{"Operation": Operation.UPDATE, "EXPECTED_ACTION_FLAG": ActionFlag.UPDATE},
{"Operation": Operation.DELETE_LOGICAL, "EXPECTED_ACTION_FLAG": ActionFlag.DELETE_LOGICAL},
]
for test_case in expected_action_flags:
with self.subTest(test_case["Operation"]):
event = self.get_event(operation=test_case["Operation"])
response = handler(event, None)
# Retrieve items from DynamoDB
result = self.table.scan()
items = result.get("Items", [])
expected_values = ValuesForTests.expected_static_values
expected_imms = ValuesForTests.get_expected_imms(test_case["EXPECTED_ACTION_FLAG"])
self.assert_dynamodb_record(
test_case["Operation"],
test_case["EXPECTED_ACTION_FLAG"],
items,
expected_values,
expected_imms,
response
)
result = self.table.scan()
items = result.get("Items", [])
self.clear_table()
def test_conversionCount(self):
parser = SchemaParser()
schema_data = {"conversions": [{"conversion": "type1"}, {"conversion": "type2"}, {"conversion": "type3"}]}
parser.parseSchema(schema_data)
self.assertEqual(parser.conversionCount(), 3)
def test_getConversion(self):
parser = SchemaParser()
schema_data = {"conversions": [{"conversion": "type1"}, {"conversion": "type2"}, {"conversion": "type3"}]}
parser.parseSchema(schema_data)
self.assertEqual(parser.getConversion(1), {"conversion": "type2"})
# TODO revisit and amend if necessary
@patch("Converter.FHIRParser")
def test_fhir_parser_exception(self, mock_fhir_parser):
# Mock FHIRParser to raise an exception
mock_fhir_parser.side_effect = Exception("FHIR Parsing Error")
converter = Converter(fhir_data="some_data")
response = converter.runConversion("somedata")
# Check if the error message was added to ErrorRecords
self.assertEqual(len(response), 2)
self.assertIn("FHIR Parser Unexpected exception", converter.getErrorRecords()[0]["message"])
self.assertEqual(converter.getErrorRecords()[0]["code"], 0)
@patch("Converter.FHIRParser")
@patch("Converter.SchemaParser")
def test_schema_parser_exception(self, mock_schema_parser, mock_fhir_parser):
# Mock FHIRParser to return normally
mock_fhir_instance = Mock()
mock_fhir_instance.parseFHIRData.return_value = None
mock_fhir_parser.return_value = mock_fhir_instance
# Mock SchemaParser to raise an exception
mock_schema_parser.side_effect = Exception("Schema Parsing Error")
converter = Converter(fhir_data="{}")
converter.runConversion("some_data")
# Check if the error message was added to ErrorRecords
errors = converter.getErrorRecords()
self.assertEqual(len(errors), 1)
self.assertIn("Schema Parser Unexpected exception", errors[0]["message"])
self.assertEqual(errors[0]["code"], 0)
@patch("Converter.ConversionChecker")
def test_conversion_checker_exception(self, mock_conversion_checker):
# Mock ConversionChecker to raise an exception
mock_conversion_checker.side_effect = Exception("Conversion Checking Error")
converter = Converter(fhir_data="some_data")
response = converter.runConversion(ValuesForTests.json_data)
# Check if the error message was added to ErrorRecords
self.assertEqual(len(converter.getErrorRecords()), 1)
self.assertIn(
"FHIR Parser Unexpected exception [JSONDecodeError]: Expecting value: line 1 column 1 (char 0)",
converter.getErrorRecords()[0]["message"],
)
self.assertEqual(converter.getErrorRecords()[0]["code"], 0)
@patch("Converter.SchemaParser.getConversions")
def test_get_conversions_exception(self, mock_get_conversions):
# Mock getConversions to raise an exception
mock_get_conversions.side_effect = Exception("Error while getting conversions")
converter = Converter(fhir_data="some_data")
response = converter.runConversion(ValuesForTests.json_data)
# Check if the error message was added to ErrorRecords
self.assertEqual(len(converter.getErrorRecords()), 1)
self.assertIn(
"FHIR Parser Unexpected exception [JSONDecodeError]: Expecting value: line 1 column 1 (char 0)",
converter.getErrorRecords()[0]["message"],
)
self.assertEqual(converter.getErrorRecords()[0]["code"], 0)
@patch("Converter.SchemaParser.getConversions")
@patch("Converter.FHIRParser.getKeyValue")
def test_conversion_exceptions(self, mock_get_key_value, mock_get_conversions):
mock_get_conversions.side_effect = Exception("Error while getting conversions")
mock_get_key_value.side_effect = Exception("Key value retrieval failed")
converter = Converter(fhir_data="some_data")
schema = {
"conversions": [
{
"fieldNameFHIR": "some_field",
"fieldNameFlat": "flat_field",
"expression": {"expressionType": "type", "expressionRule": "rule"},
}
]
}
converter.SchemaFile = schema
response = converter.runConversion(ValuesForTests.json_data)
error_records = converter.getErrorRecords()
self.assertEqual(len(error_records), 1)
self.assertIn(
"FHIR Parser Unexpected exception [JSONDecodeError]: Expecting value: line 1 column 1 (char 0)",
error_records[0]["message"],
)
self.assertEqual(error_records[0]["code"], 0)
@patch("ConversionChecker.LookUpData")
def test_log_error(self, MockLookUpData):
# Instantiate ConversionChecker
checker = ConversionChecker(dataParser=None, summarise=False, report_unexpected_exception=True)
# Simulate an exception
exception = ValueError("Invalid value")
# Call the _log_error method twice to also check deduplication
checker._log_error("test_field", "test_value", exception)
checker._log_error("test_field", "test_value", exception)
# Assert that only one error record is added due to deduplication
self.assertEqual(len(checker.errorRecords), 2)
# Assert that one error record is added
self.assertEqual(len(checker.errorRecords), 2)
error = checker.errorRecords[0]
# Assert that the error record contains correct details
self.assertEqual(error["field"], "test_field")
self.assertEqual(error["value"], "test_value")
self.assertIn("Invalid value", error["message"])
self.assertEqual(error["code"], ExceptionMessages.RECORD_CHECK_FAILED)
@patch("ConversionChecker.LookUpData")
def test_convert_to_not_empty(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
result = checker._convertToNotEmpty(None, "fieldName", "Some data", False, True)
self.assertEqual(result, "Some data")
result = checker._convertToNotEmpty(None, "fieldName", "", False, True)
self.assertEqual(result, "")
# Test for value that is not a string
checker._log_error = Mock()
result = checker._convertToNotEmpty(None, "fieldName", 12345, False, True)
self.assertEqual(result, "")
checker._log_error.assert_called_once()
field, value, err = checker._log_error.call_args[0]
self.assertEqual((field, value), ("fieldName",12345))
self.assertIsInstance(err, str)
self.assertIn("Value not a String", err)
checker._log_error.reset_mock()
# Simulate a fieldValue whose .strip() crashes to test exception handling
checker._log_error = Mock()
class BadString(str):
def strip(self):
raise RuntimeError("Simulated crash during strip")
bad_value = BadString("some bad string")
# Make the .strip() method crash
result = checker._convertToNotEmpty(None, "fieldName", bad_value, False, True)
self.assertEqual(result, "") # Should return empty string on exception
checker._log_error.assert_called_once()
field, value, message = checker._log_error.call_args[0]
self.assertEqual((field, value), ("fieldName", bad_value))
self.assertIsInstance(message, str)
self.assertIn("RuntimeError", message)
@patch("ConversionChecker.LookUpData")
def test_convert_to_nhs_number(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
# Test empty NHS number
empty_nhs_number = ""
result = checker._convertToNHSNumber(None, "fieldName", empty_nhs_number, False, True)
self.assertEqual(result, "", "Expected empty string for empty NHS number input")
# Test valid NHS number
valid_nhs_number = "6000000000"
result = checker._convertToNHSNumber("NHSNUMBER", "fieldName", valid_nhs_number, False, True)
self.assertEqual(result, "6000000000", "Valid NHS number should be returned as-is")
# Test invalid NHS number
invalid_nhs_number = "1234567890243"
result = checker._convertToNHSNumber("NHSNUMBER","fieldName", invalid_nhs_number, False, True)
self.assertEqual(result, "", "Invalid NHS number should return empty string")
@patch("ConversionChecker.LookUpData")
def test_convert_to_date(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
# 1. Valid full date
result = checker._convertToDate("%Y%m%d", "fieldName", "2022-01-01", False, True)
self.assertEqual(result, "20220101")
# 2.Full ISO date should be transformed to YYYYMMDD
result = checker._convertToDate("%Y%m%d", "fieldName", "2022-01-01T12:00:00+00:00", False, True)
self.assertEqual(result, "20220101")
# 3. Invalid string date format (should trigger "Date must be in YYYYMMDD format")
result = checker._convertToDate("%Y%m%d", "fieldName", "invalid_date", False, True)
self.assertEqual(result, "")
# 4. None input (should return empty without logging)
result = checker._convertToDate("%Y%m%d", "fieldName", None, False, True)
self.assertEqual(result, "")
# 5. Not a string input (should trigger "Value is not a string")
result = checker._convertToDate("%Y%m%d", "fieldName", 12345678, False, True)
self.assertEqual(result, "")
# 6 Empty string
result = checker._convertToDate("%Y%m%d", "fieldName", "", False, True)
self.assertEqual(result, "")
# 7 Validate all error logs of various responses
messages = [err["message"] for err in checker.errorRecords]
self.assertIn("Value is not a string", messages)
# Confirm Total Errors Per conversion
self.assertEqual(len(checker.errorRecords), 2)
# Test for value Error
checker._log_error = Mock()
# invalid date against the given format → ValueError path
result = checker._convertToDate("format:%Y-%m-%d", "fieldName", "not-a-date", False, True)
self.assertEqual(result, "")
# ensure we logged exactly that ValueError
checker._log_error.assert_called_once()
field, value, err = checker._log_error.call_args[0]
self.assertEqual((field, value), ("fieldName", "not-a-date"))
self.assertIsInstance(err, ValueError)
@patch("ConversionChecker.LookUpData")
def test_convert_to_date_time(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
valid_date_time = "2025-01-01T12:00:00+00:00"
result = checker._convertToDateTime("fhir-date", "fieldName", valid_date_time, False, True)
self.assertEqual(result, "20250101T12000000")
valid_fhir_date = "2025-01-01T13:28:17+00:00"
result = checker._convertToDateTime("fhir-date", "fieldName", valid_fhir_date, False, True)
self.assertEqual(result, "20250101T13281700")
valid_fhir_date = "2022-01-01"
result = checker._convertToDateTime("", "fieldName", valid_fhir_date, False, True)
self.assertEqual(result, "20220101T00000000")
valid_fhir_date = "2025-05-01T13:28:17+01:00"
result = checker._convertToDateTime("fhir-date", "fieldName", valid_fhir_date, False, True)
self.assertEqual(result, "20250501T13281701")
invalid_date_time = "invalid_date_time"
result = checker._convertToDateTime("fhir-date", "fieldName", invalid_date_time, False, True)
self.assertEqual(result, "")
valid_date_time = "2025-01-01T12:00:00+03:00"
result = checker._convertToDateTime("fhir-date", "fieldName", valid_date_time, False, True)
self.assertEqual(result, "")
messages = [err["message"] for err in checker.errorRecords]
self.assertIn("Unexpected exception [ValueError]", messages[0])
self.assertIn("Unsupported Format or offset", messages[1])
# Confirm Total Errors Per conversion
self.assertEqual(len(checker.errorRecords), 2)
# Test for value Error
checker._log_error = Mock()
valid_fhir_date = "2022-01"
result = checker._convertToDateTime("fhir-date", "fieldName", valid_fhir_date, False, True)
self.assertEqual(result, "")
# ensure we logged exactly that ValueError
checker._log_error.assert_called_once()
field, value, err = checker._log_error.call_args[0]
self.assertEqual((field, value), ("fieldName", valid_fhir_date))
self.assertIsInstance(err, ValueError)
@patch("ConversionChecker.LookUpData")
def test_convert_to_boolean(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
# Arrange
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
# 1. Boolean True passes through
result = checker._convertToBoolean(None, "fieldName", True, False, True)
self.assertTrue(result)
# 2. Boolean False passes through
result = checker._convertToBoolean(None, "fieldName", False, False, True)
self.assertFalse(result)
# 3. String "true" variants
for val in ["true", "TRUE", " True ", "\tTrUe\n"]:
result = checker._convertToBoolean(None, "fieldName", val, False, False)
self.assertTrue(result)
# 4. String "false" variants
for val in ["false", "FALSE", " False ", "\nFaLsE\t"]:
result = checker._convertToBoolean(None, "fieldName", val, False, False)
self.assertFalse(result)
# 5. Invalid string with report_unexpected_exception=False → no log
result = checker._convertToBoolean(None, "fieldName", "notbool", False, True)
self.assertEqual(result, "")
# Assert exactly one error was logged
self.assertEqual(len(checker.errorRecords), 1)
err = checker.errorRecords[0]
self.assertEqual(err["field"], "fieldName")
self.assertEqual(err["value"], "notbool")
# message should include our literal
self.assertIn("Invalid String Data", err["message"])
# and code should default to UNEXPECTED_EXCEPTION
self.assertEqual(err["code"], ExceptionMessages.RECORD_CHECK_FAILED)
#check for dose sequence
@patch("ConversionChecker.LookUpData")
def test_convert_to_dose(self, MockLookUpData):
dataParser = Mock()
checker = ConversionChecker(dataParser, summarise=False, report_unexpected_exception=True)
# Valid dose
for dose in [1, 4, 9]:
with self.subTest(dose=dose):
result = checker._convertToDose("DOSESEQUENCE", "DOSE_AMOUNT", dose, False, True)
self.assertEqual(result, dose)
# Invalid dose
invalid_doses = [10, 10.1, 100, 9.0001]
for dose in invalid_doses:
with self.subTest(dose=dose):
result = checker._convertToDose("DOSESEQUENCE", "DOSE_AMOUNT", dose, False, True)
self.assertEqual(result, "", f"Expected empty string for invalid dose {dose}")
def clear_table(self):
scan = self.table.scan()
with self.table.batch_writer() as batch:
for item in scan.get("Items", []):
batch.delete_item(Key={"PK": item["PK"]})
result = self.table.scan()
items = result.get("Items", [])
class TestPersonForeNameToFlatJson(unittest.TestCase):
def test_person_forename_multiple_names_official(self):
"""Test case where multiple name instances exist, and one has use=official with period covering vaccination date"""
request_json_data["contained"][1]["name"] = [
{
"family": "Doe",
"given": ["Johnny"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2022-01-01"},
},
{
"family": "Doe",
"given": ["John"],
"use": "official",
"period": {"start": "2020-01-01", "end": "2021-01-01"},
},
{
"family": "Doe",
"given": ["Manny"],
"use": "official",
"period": {"start": "2021-01-01", "end": "2021-02-09"},
},
{
"family": "Doe",
"given": ["Davis"],
"use": "official",
"period": {"start": "2021-01-01", "end": "2021-02-09"},
},
]
expected_forename = "Manny"
self._run_test(expected_forename)
def test_person_forename_multiple_names_current(self):
"""Test case where no official name is present, but a name is current at the vaccination date"""
request_json_data["contained"][1]["name"] = [
{"family": "Doe", "given": ["John"], "period": {"start": "2020-01-01", "end": "2023-01-01"}},
{"family": "Doe", "given": ["Johnny"], "use": "nickname"},
]
expected_forename = "John"
self._run_test(expected_forename)
def test_person_forename_single_name(self):
"""Test case where only one name instance exists"""
request_json_data["contained"][1]["name"] = [{"family": "Doe", "given": ["Alex"], "use": "nickname"}]
expected_forename = "Alex"
self._run_test(expected_forename)
def test_person_forename_no_official_but_current_not_old(self):
"""Test case where no official name is present, but a current name with use!=old exists at vaccination date"""
request_json_data["contained"][1]["name"] = [
{"family": "Doe", "given": ["John"], "use": "old", "period": {"start": "2018-01-01", "end": "2020-12-31"}},
{
"family": "Doe",
"given": ["Chris"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2023-01-01"},
},
]
expected_forename = "Chris"
self._run_test(expected_forename)
def test_person_forename_fallback_to_first_name(self):
"""Test case where no names match the previous conditions, fallback to first available name"""
request_json_data["contained"][1]["name"] = [
{"family": "Doe", "given": ["Elliot"], "use": "nickname"},
{"family": "Doe", "given": ["John"], "use": "old", "period": {"start": "2018-01-01", "end": "2020-12-31"}},
{
"family": "Doe",
"given": ["Chris"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2023-01-01"},
},
]
expected_forename = "Elliot"
self._run_test(expected_forename)
def test_person_forename_multiple_given_names_concatenation(self):
"""Test case where the selected name has multiple given names"""
request_json_data["contained"][1]["name"] = [
{
"family": "Doe",
"given": ["Chris"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2023-01-01"},
},
{
"family": "Doe",
"given": ["Alice", "Marie"],
"use": "official",
"period": {"start": "2021-01-01", "end": "2022-12-31"},
},
]
expected_forename = "Alice Marie"
self._run_test(expected_forename)
def _run_test(self, expected_forename):
"""Helper function to run the test"""
self.converter = Converter(json.dumps(request_json_data))
flat_json = self.converter.runConversion(request_json_data, False, True)
self.assertEqual(flat_json["PERSON_FORENAME"], expected_forename)
class TestPersonSurNameToFlatJson(unittest.TestCase):
def test_person_surname_multiple_names_official(self):
"""Test case where multiple name instances exist, and one has use=official with period covering vaccination date"""
request_json_data["contained"][1]["name"] = [
{
"family": "Doe",
"given": ["Johnny"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2022-01-01"},
},
{
"family": "Manny",
"given": ["John"],
"use": "official",
"period": {"start": "2020-01-01", "end": "2021-01-01"},
},
{
"family": "Davis",
"given": ["Manny"],
"use": "official",
"period": {"start": "2021-01-01", "end": "2021-02-09"},
},
{
"family": "Johnny",
"given": ["Davis"],
"use": "official",
"period": {"start": "2021-01-01", "end": "2021-02-09"},
},
]
expected_forename = "Davis"
self._run_test_surname(expected_forename)
def test_person_surname_multiple_names_current(self):
"""Test case where no official name is present, but a name is current at the vaccination date"""
request_json_data["contained"][1]["name"] = [
{"family": "Manny", "given": ["John"], "period": {"start": "2020-01-01", "end": "2023-01-01"}},
{"family": "Doe", "given": ["Johnny"], "use": "nickname"},
]
expected_forename = "Manny"
self._run_test_surname(expected_forename)
def test_person_surname_single_name(self):
"""Test case where only one name instance exists"""
request_json_data["contained"][1]["name"] = [{"family": "Doe", "given": ["Alex"], "use": "nickname"}]
expected_forename = "Doe"
self._run_test_surname(expected_forename)
def test_person_surname_no_official_but_current_not_old(self):
"""Test case where no official name is present, but a current name with use!=old exists at vaccination date"""
request_json_data["contained"][1]["name"] = [
{"family": "Doe", "given": ["John"], "use": "old", "period": {"start": "2018-01-01", "end": "2020-12-31"}},
{
"family": "Manny",
"given": ["Chris"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2023-01-01"},
},
]
expected_forename = "Manny"
self._run_test_surname(expected_forename)
def test_person_surname_fallback_to_first_name(self):
"""Test case where no names match the previous conditions, fallback to first available name"""
request_json_data["contained"][1]["name"] = [
{"family": "Doe", "given": ["Elliot"], "use": "nickname"},
{
"family": "Manny",
"given": ["John"],
"use": "old",
"period": {"start": "2018-01-01", "end": "2020-12-31"},
},
{
"family": "Davis",
"given": ["Chris"],
"use": "nickname",
"period": {"start": "2021-01-01", "end": "2023-01-01"},
},
]
expected_forename = "Doe"
self._run_test_surname(expected_forename)
def _run_test_surname(self, expected_forename):
"""Helper function to run the test"""
self.converter = Converter(json.dumps(request_json_data))
flat_json = self.converter.runConversion(request_json_data, False, True)
self.assertEqual(flat_json["PERSON_SURNAME"], expected_forename)
class TestPersonPostalCodeToFlatJson(unittest.TestCase):
def test_person_postal_code_single_address(self):
"""Test case where only one address instance exists"""
request_json_data["contained"][1]["address"] = [{"postalCode": "AB12 3CD"}]
expected_postal_code = "AB12 3CD"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_ignore_address_without_postal_code(self):
"""Test case where multiple addresses exist, but one lacks a postalCode"""
request_json_data["contained"][1]["address"] = [
{"use": "home", "type": "physical"},
{"postalCode": "XY99 8ZZ", "use": "home", "type": "physical"},
]
expected_postal_code = "XY99 8ZZ"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_ignore_non_current_addresses(self):
"""Test case where multiple addresses exist, but some are not current at the vaccination date"""
request_json_data["contained"][1]["address"] = [
{
"postalCode": "AA11 1AA",
"use": "home",
"type": "physical",
"period": {"start": "2018-01-01", "end": "2020-12-31"},
},
{
"postalCode": "BB22 2BB",
"use": "home",
"type": "physical",
"period": {"start": "2021-01-01", "end": "2023-12-31"},
},
{
"postalCode": "BB22 2BC",
"use": "home",
"type": "physical",
"period": {"start": "2021-01-01", "end": "2024-12-31"},
},
]
expected_postal_code = "BB22 2BB"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_select_home_type_not_postal(self):
"""Test case where a home address with type!=postal should be selected"""
request_json_data["contained"][1]["address"] = [
{"postalCode": "CC33 3CC", "use": "old", "type": "physical"},
{"postalCode": "DD44 4DD", "use": "home", "type": "physical"},
{"postalCode": "DD44 4DP", "use": "home", "type": "physical"},
{"postalCode": "EE55 5EE", "use": "temp", "type": "postal"},
]
expected_postal_code = "DD44 4DD"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_select_first_non_old_type_not_postal(self):
"""Test case where an address with use!=old and type!=postal should be selected"""
request_json_data["contained"][1]["address"] = [
{"postalCode": "FF66 6FF", "use": "old", "type": "physical"},
{"postalCode": "GG77 7GG", "use": "temp", "type": "physical"},
{"postalCode": "GG77 7GI", "use": "temp", "type": "physical"},
{"postalCode": "HH88 8HH", "use": "old", "type": "postal"},
]
expected_postal_code = "GG77 7GG"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_fallback_first_non_old(self):
"""Test case where the first address with use!=old is selected"""
request_json_data["contained"][1]["address"] = [
{"postalCode": "II99 9II", "use": "old", "type": "postal"},
{"postalCode": "JJ10 1JJ", "use": "old", "type": "physical"},
{"postalCode": "KK20 2KK", "use": "billing", "type": "postal"},
]
expected_postal_code = "KK20 2KK"
self._run_postal_code_test(expected_postal_code)
def test_person_postal_code_default_to_ZZ99_3CZ(self):
"""Test case where no valid postalCode is found, should default to ZZ99 3CZ"""
request_json_data["contained"][1]["address"] = [
{"use": "old", "type": "postal"},
{"use": "temp", "type": "postal"},
]
expected_postal_code = "ZZ99 3CZ"
self._run_postal_code_test(expected_postal_code)
def _run_postal_code_test(self, expected_postal_code):
"""Helper function to run the test"""
self.converter = Converter(json.dumps(request_json_data))
flat_json = self.converter.runConversion(request_json_data, False, True)
self.assertEqual(flat_json["PERSON_POSTCODE"], expected_postal_code)
class TestPersonSiteCodeToFlatJson(unittest.TestCase):
def test_site_code_single_performer(self):
"""Test case where only one performer instance exists"""
request_json_data["performer"] = [
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "B0C4P"},
}
},
{"actor": {"reference": "#Pract1"}},
]
{"actor": {"value": "OTHER123"}},
expected_site_code = "B0C4P"
self._run_site_code_test(expected_site_code)
def test_site_code_performer_type_organization_only(self):
"""Test case where performer has type=organization and system=https://fhir.nhs.uk/Id/ods-organization-code with more than one instance"""
request_json_data["performer"] = [
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "code1"},
}
},
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "code2"},
}
},
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "code3"},
}
},
{"actor": {"reference": "#Pract1"}},
]
expected_site_code = "code2"
self._run_site_code_test(expected_site_code)
def test_site_code_performer_type_organization(self):
"""Test case where performer has type=organization but no NHS system"""
request_json_data["performer"] = [
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organizatdion-code", "value": "code1"},
}
},
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhs-code", "value": "code2"},
}
},
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhss-code", "value": "code3"},
}
},
{"actor": {"reference": "#Pract1"}},
]
expected_site_code = "code2"
self._run_site_code_test(expected_site_code)
def test_site_code_performer_type_without_oraganisation(self):
"""Test case where performer has type=organization but no NHS system"""
request_json_data["performer"] = [
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhs-code", "value": "code2"},
}
},
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "code1"},
}
},
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "code4"},
}
},
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhss-code", "value": "code3"},
}
},
{"actor": {"reference": "#Pract1"}},
]
expected_site_code = "code1"
self._run_site_code_test(expected_site_code)
def test_site_code_fallback_to_first_performer(self):
"""Test case where no performers match specific criteria, fallback to first instance"""
request_json_data["performer"] = [
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhs-code", "value": "code1"},
}
},
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-nhss-code", "value": "code2"},
}
},
{"actor": {"reference": "#Pract1"}},
]
expected_site_code = "code1"
self._run_site_code_test(expected_site_code)
def _run_site_code_test(self, expected_site_code):
"""Helper function to run the test"""
self.converter = Converter(json.dumps(request_json_data))
flat_json = self.converter.runConversion(request_json_data, False, True)
self.assertEqual(flat_json.get("SITE_CODE"), expected_site_code)
class TestPersonSiteUriToFlatJson(unittest.TestCase):
def test_site_uri_single_performer(self):
"""Test case where only one performer instance exists"""
request_json_data["performer"] = [
{
"actor": {
"type": "Organization",
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-code", "value": "B0C4P"},
}
},
{"actor": {"reference": "#Pract1"}},
]
{"actor": {"value": "OTHER123"}},
expected_site_uri = "https://fhir.nhs.uk/Id/ods-organization-code"
self._run_site_uri_test(expected_site_uri)
def test_site_code_performer_type_organization_only(self):
"""Test case where performer has type=organization and system=https://fhir.nhs.uk/Id/ods-organization-code with more than one instance"""
request_json_data["performer"] = [
{
"actor": {
"identifier": {"system": "https://fhir.nhs.uk/Id/ods-organization-codes", "value": "code1"},
}