immunisation-fhir-api/e2e/test_update_immunization.py at 9b43b173d13c33995434d5d803baa5e3b4a70613 · NHSDigital/immunisation-fhir-api · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
import copy
import uuid
import unittest
from utils.base_test import ImmunizationBaseTest
from utils.immunisation_api import parse_location
from utils.resource import generate_imms_resource
from utils.constants import env_internal_dev


@unittest.skipIf(env_internal_dev, "TestUpdateImmunization for internal-dev environment")
class TestUpdateImmunization(ImmunizationBaseTest):

    def test_update_imms(self):
        """it should update a FHIR Immunization resource"""
        for imms_api in self.imms_apis:
            with self.subTest(imms_api):
                # Given
                immunization_resources = [
                    generate_imms_resource(),
                    generate_imms_resource(sample_data_file_name="completed_rsv_immunization_event")
                ]

                for imms in immunization_resources:
                    # Create the immunization resource
                    response = imms_api.create_immunization(imms)
                    assert response.status_code == 201
                    imms_id = parse_location(response.headers["Location"])

                    # When
                    update_payload = copy.deepcopy(imms)
                    update_payload["id"] = imms_id
                    update_payload["location"]["identifier"]["value"] = "Y11111"
                    response = imms_api.update_immunization(imms_id, update_payload)

                    # Then
                    self.assertEqual(response.status_code, 200, response.text)
                    self.assertEqual(response.text, "")
                    self.assertNotIn("Location", response.headers)

    def test_update_non_existent_identifier(self):
        """update a record should fail if identifier is not present"""
        imms = generate_imms_resource()
        _ = self.create_immunization_resource(self.default_imms_api, imms)
        # NOTE: there is a difference between id and identifier.
        # 422 is expected when identifier is the same across different ids
        # This is why in this test we create a new id but not touching the identifier
        new_imms_id = str(uuid.uuid4())
        imms["id"] = new_imms_id

        # When update the same object (it has the same identifier)
        response = self.default_imms_api.update_immunization(new_imms_id, imms)
        # Then
        self.assert_operation_outcome(response, 404)

    def test_update_inconsistent_id(self):
        """update should fail if id in the path doesn't match with the id in the message"""
        msg_id = str(uuid.uuid4())
        imms = generate_imms_resource()
        imms["id"] = msg_id
        path_id = str(uuid.uuid4())
        response = self.default_imms_api.update_immunization(path_id, imms)
        self.assert_operation_outcome(response, 400, contains=path_id)

    # TODO: Uncomment this test if it is needed
    # def test_update_deleted_imms(self):
    #     """updating deleted record will undo the delete"""
    #     # This behaviour is consistent. Getting a deleted record will result in a 404.
    #     #  An update of a non-existent record should result in creating a new record
    #     #  Therefore, the new resource's id must be different from the original one

    #     imms = self.create_a_deleted_immunization_resource(self.default_imms_api)
    #     deleted_id = imms["id"]

    #     response = self.default_imms_api.update_immunization(deleted_id, imms)

    #     self.assertEqual(response.status_code, 201, response.text)
    #     new_imms_id = parse_location(response.headers["Location"])
    #     self.assertNotEqual(deleted_id, new_imms_id)