comments

Author: nhsdevws

backend/tests/test_parameter_parser.py

@@ -111,16 +111,17 @@ def test_process_search_params_checks_patient_identifier_format(self):
         self.assertIsNotNone(params)
 
     def test_process_search_params_whitelists_immunization_target(self):
-        self.mock_redis_client.hkeys.return_value = ["RSV"]
+        mock_redis_key = "RSV"
+        self.mock_redis_client.hkeys.return_value = [mock_redis_key]
         with self.assertRaises(ParameterException) as e:
             process_search_params(
                 {
                     self.patient_identifier_key: ["https://fhir.nhs.uk/Id/nhs-number|9000000009"],
                     self.immunization_target_key: ["not-a-code"],
                 }
             )
-        self.assertTrue(
-            str(e.exception).startswith("immunization-target must be one or more of the following:"),
+        self.assertEqual(
+            str(e.exception), f"immunization-target must be one or more of the following: {mock_redis_key}",
             f"Unexpected exception message: {str(e.exception)}"
         )
 

backend/tests/test_update_imms.py

@@ -17,7 +17,7 @@ def setUp(self):
         self.mock_logger_info = self.logger_info_patcher.start()
 
     def tearDown(self):
-        self.logger_exception_patcher.stop()
+        patch.stopall()
 
 
     def test_update_immunization(self):