Skip to content

Commit 05530c7

Browse files
committed
resolve security issue
1 parent aed9c22 commit 05530c7

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

backend/src/fhir_service.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,9 +332,6 @@ def search_immunizations(
332332
Bundles the resources with the relevant patient resource and returns the bundle along with a boolean to state
333333
whether the supplier requested vaccine types they were not authorised for.
334334
"""
335-
# TODO: is disease type a mandatory field? (I assumed it is)
336-
# i.e. Should we provide a search option for getting Patient's entire imms history?
337-
338335
permitted_vacc_types = self.authoriser.filter_permitted_vacc_types(
339336
supplier_system, ApiOperationCode.SEARCH, set(vaccine_types)
340337
)

backend/src/parameter_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def process_patient_identifier(identifier_params: ParamContainer) -> str:
4949

5050
patient_identifier_parts = patient_identifier.split("|")
5151
identifier_system = patient_identifier_parts[0]
52-
if len(patient_identifier_parts) != 2 or not identifier_system == patient_identifier_system:
52+
if len(patient_identifier_parts) != 2 or identifier_system != patient_identifier_system:
5353
raise ParameterException("patient.identifier must be in the format of "
5454
f"\"{patient_identifier_system}|{{NHS number}}\" "
5555
f"e.g. \"{patient_identifier_system}|9000000009\"")

0 commit comments

Comments
 (0)