Create one chatbot and topic per account

Author: dlzhry2nhs

terraform/batch_processor_errors_slack_chatbot.tf

@@ -1,17 +1,13 @@
 resource "aws_chatbot_slack_channel_configuration" "batch_processor_errors" {
-  count              = var.batch_error_notifications_enabled ? 1 : 0
-
-  configuration_name = "${local.resource_scope}-batch-processor-errors-slack-channel-config"
-  iam_role_arn       = aws_iam_role.batch_processor_errors_chatbot[0].arn
+  configuration_name = "${var.environment}-batch-processor-errors-slack-channel-config"
+  iam_role_arn       = aws_iam_role.batch_processor_errors_chatbot.arn
   slack_channel_id   = var.environment == "prod" ? "C09EA0HE202" : "C09E48NDP18"
   slack_team_id      = "TJ00QR03U"
-  sns_topic_arns     = [aws_sns_topic.batch_processor_errors[0].arn]
+  sns_topic_arns     = [aws_sns_topic.batch_processor_errors.arn]
 }
 
 resource "aws_iam_role" "batch_processor_errors_chatbot" {
-  count = var.batch_error_notifications_enabled ? 1 : 0
-
-  name               = "${local.resource_scope}-batch-processor-errors-chatbot-channel-role"
+  name               = "${var.environment}-batch-processor-errors-chatbot-channel-role"
   assume_role_policy = jsonencode({
     Version = "2012-10-17"
     Statement = [
@@ -25,5 +21,6 @@ resource "aws_iam_role" "batch_processor_errors_chatbot" {
       },
     ]
   })
+  # To try: could test without this?
   managed_policy_arns = ["arn:aws:iam::aws:policy/AWSResourceExplorerReadOnlyAccess"]
 }

terraform/batch_processor_errors_sns_topic.tf

@@ -1,11 +1,9 @@
 resource "aws_sns_topic" "batch_processor_errors" {
-  count = var.batch_error_notifications_enabled ? 1 : 0
-  name  = "${local.resource_scope}-batch-processor-errors"
+  name  = "${var.environment}-batch-processor-errors"
 }
 
 resource "aws_sns_topic_policy" "batch_processor_errors_topic_policy" {
-  count  = var.batch_error_notifications_enabled ? 1 : 0
-  arn    = aws_sns_topic.batch_processor_errors[0].arn
+  arn    = aws_sns_topic.batch_processor_errors.arn
   policy = jsonencode({
     Version = "2012-10-17",
     Statement = [
@@ -16,7 +14,7 @@ resource "aws_sns_topic_policy" "batch_processor_errors_topic_policy" {
           Service = "cloudwatch.amazonaws.com"
         },
         Action    = "SNS:Publish",
-        Resource  = aws_sns_topic.batch_processor_errors[0].arn
+        Resource  = aws_sns_topic.batch_processor_errors.arn
       }
     ]
   })

terraform/batch_processor_filter_lambda.tf

@@ -328,6 +328,6 @@ resource "aws_cloudwatch_metric_alarm" "batch_processor_filter_error_alarm" {
   statistic           = "Sum"
   threshold           = 1
   alarm_description   = "This sets off an alarm for any error logs found in the batch processor filter Lambda function"
-  alarm_actions       = [aws_sns_topic.batch_processor_errors[0].arn]
+  alarm_actions       = [aws_sns_topic.batch_processor_errors.arn]
   treat_missing_data  = "notBreaching"
 }

terraform/file_name_processor.tf

@@ -345,6 +345,6 @@ resource "aws_cloudwatch_metric_alarm" "file_name_processor_error_alarm" {
   statistic           = "Sum"
   threshold           = 1
   alarm_description   = "This sets off an alarm for any error logs found in the file name processor Lambda function"
-  alarm_actions       = [aws_sns_topic.batch_processor_errors[0].arn]
+  alarm_actions       = [aws_sns_topic.batch_processor_errors.arn]
   treat_missing_data  = "notBreaching"
 }