PDS/MNS secret TODO

Author: JamesW1-NHS

lambdas/mns_subscription/src/mns_setup.py

@@ -13,7 +13,7 @@ def get_mns_service(mns_env: str = "int"):
     cache = Cache(directory="/tmp")
     logging.info("Creating authenticator...")
     authenticator = AppRestrictedAuth(
-        service=Service.PDS,
+        service=Service.MNS,
         secret_manager_client=boto3.client("secretsmanager", config=boto_config),
         environment=mns_env,
         cache=cache,

lambdas/shared/src/common/authentication.py

@@ -12,7 +12,9 @@
 
 
 class Service(Enum):
+    # TODO: PDS and MNS need separate secrets
     PDS = "pds"
+    MNS = "pds"
     IMMUNIZATION = "imms"
 
 
@@ -23,8 +25,8 @@ def __init__(self, service: Service, secret_manager_client, environment, cache:
         self.cache_key = f"{service.value}_access_token"
 
         self.expiry = 30
-        self.secret_name = f"imms/pds/{environment}/jwt-secrets" if service == Service.PDS else \
-            f"imms/immunization/{environment}/jwt-secrets"
+        self.secret_name = f"imms/immunization/{environment}/jwt-secrets" if service == Service.IMMUNIZATION else \
+            f"imms/{service}/{environment}/jwt-secrets"
 
         self.token_url = f"https://{environment}.api.service.nhs.uk/oauth2/token" \
             if environment != "prod" else "https://api.service.nhs.uk/oauth2/token"