Good Tests

Author: nhsdevws

delta_backend/src/delta.py

@@ -145,19 +145,17 @@ def handler(event, context):
                 return {"statusCode": 500, "body": "Records not processed successfully"}
 
     except Exception as e:
-        logger.info(">>>>>> Delta EXCEPTION!!!")
 
         operation_outcome["statusCode"] = "500"
         operation_outcome["statusDesc"] = "Exception"
         if intrusion_check:
-            logger.info(f">>>>>> Delta Lambda failure: {e}")
             operation_outcome["diagnostics"] = "Incorrect invocation of Lambda"
-            # logger.exception("Incorrect invocation of Lambda")
+            logger.exception("Incorrect invocation of Lambda")
         else:
             operation_outcome["diagnostics"] = f"Delta Lambda failure: {e}"
-            logger.info(f">>>>>> Delta Lambda failure: {e}")
+            logger.exception(f"Delta Lambda failure: {e}")
             send_message(event)  # Send failed records to DLQ
         log_data["operation_outcome"] = operation_outcome
         firehose_log["event"] = log_data
         firehose_logger.send_log(firehose_log)
-        # raise Exception(f"Delta Lambda failure: {e}")
+        raise Exception(f"Delta Lambda failure: {e}")

delta_backend/src/log_firehose.py

@@ -19,7 +19,6 @@ def __init__(
         self.delivery_stream_name = stream_name
 
     def send_log(self, log_message):
-        raise Exception(f"XXXXXXX")
         log_to_splunk = log_message
         logger.info(f"Log sent to Firehose for save: {log_to_splunk}")
         encoded_log_data = json.dumps(log_to_splunk).encode("utf-8")