Skip to content

Commit 2a47c9a

Browse files
committed
VED-736: refactor search response to avoid getting no response
1 parent 1f25f4d commit 2a47c9a

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

backend/src/fhir_service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ def get_immunization_by_identifier(
6969
)
7070

7171
patient_full_url = f"urn:uuid:{str(uuid4())}"
72-
filtered_response = [Filter.search(imms, patient_full_url) for imms in (imms_resp or [])]
72+
imms_list = [imms_resp] if isinstance(imms_resp, dict) else list(imms_resp or [])
73+
filtered_response = [Filter.search(imms, patient_full_url) for imms in imms_list]
7374

7475
if not filtered_response:
7576
base_url = f"{get_service_url()}/Immunization"

backend/tests/test_fhir_service.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,11 @@ def tearDown(self):
321321
def test_get_immunization_by_identifier(self):
322322
"""it should find an Immunization by id"""
323323
imms = "an-id#an-id"
324+
imms_ids = ["imms-1", "imms-2"]
324325
identifier = "test"
325-
element = "id,mEta,DDD"
326-
self.imms_repo.get_immunization_by_identifier.return_value = {}
326+
element = "id,meta"
327+
imms_list = [create_covid_19_immunization_dict(imms_id) for imms_id in imms_ids]
328+
self.imms_repo.find_immunizations.return_value = deepcopy(imms_list)
327329

328330
# When
329331
service_resp = self.fhir_service.get_immunization_by_identifier(imms, "COVID19.S", identifier, element)

0 commit comments

Comments
 (0)