comments

Author: nhsdevws

lambdas/id_sync/src/pds_details.py

@@ -1,5 +1,5 @@
 '''
-    record Processor
+    Operations related to PDS (Patient Demographic Service)
 '''
 import tempfile
 from common.clients import logger, secrets_manager_client

lambdas/id_sync/tests/test_record_processor.py

@@ -7,26 +7,18 @@ class TestRecordProcessor(unittest.TestCase):
 
     def setUp(self):
         """Set up test fixtures and mocks"""
-        # Mock logger
         self.logger_patcher = patch('record_processor.logger')
         self.mock_logger = self.logger_patcher.start()
 
-        # Mock external dependencies
         self.pds_get_patient_id_patcher = patch('record_processor.pds_get_patient_id')
         self.mock_pds_get_patient_id = self.pds_get_patient_id_patcher.start()
 
-        # mock record_processor.ieds_check_exist
         self.ieds_check_exist_patcher = patch('record_processor.ieds_check_exist')
         self.mock_ieds_check_exist = self.ieds_check_exist_patcher.start()
 
-        # mock our ieds_update_patient_id
         self.ieds_update_patient_id_patcher = patch('record_processor.ieds_update_patient_id')
         self.mock_ieds_update_patient_id = self.ieds_update_patient_id_patcher.start()
 
-        # # mock out test_ieds_insert_patient
-        # self.ieds_test_insert_patcher = patch('record_processor.test_ieds_insert_patient')  # TODO  TEST code
-        # self.mock_ieds_test_insert = self.ieds_test_insert_patcher.start()
-
     def tearDown(self):
         patch.stopall()
 

lambdas/shared/src/common/log_decorator.py

@@ -1,7 +1,6 @@
 """This module contains the logging decorator for sending the appropriate logs to Cloudwatch and Firehose.
     The decorator log pattern is shared by filenameprocessor, recordprocessor, ack_backend and id_sync modules.
     and therefore could be moved to a common module in the future.
-    TODO: refactor to a common module.
     TODO: Duplication check has been suppressed in sonar-project.properties. Remove once refactored.
 """
 import json

terraform/sqs_id_sync.tf

@@ -1,7 +1,6 @@
 resource "aws_sqs_queue" "id_sync_queue" {
   name                        = "${local.short_prefix}-id-sync-queue"
   kms_master_key_id           = data.aws_kms_key.existing_id_sync_sqs_encryption_key.arn
-  # TODO: visibility_timeout_seconds must not be less than aws_lambda_function.id_sync_lambda_timeout
   visibility_timeout_seconds  = 360
   redrive_policy = jsonencode({
     deadLetterTargetArn = aws_sqs_queue.id_sync_dlq.arn