Skip to content

Commit 2f648bb

Browse files
authored
VED-455: Revert - Vaccine Type in Delta table is populating in lower case (#649)
* vaccine_type -> upper case * remove comments * revert code changes (failed DPS) * revert code changes (failed DPS)
1 parent 2d0caf8 commit 2f648bb

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

delta_backend/src/delta.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def send_message(record, queue_url=failure_queue_url):
6666

6767
def get_vaccine_type(patient_sort_key: str) -> str:
6868
vaccine_type = patient_sort_key.split("#")[0]
69-
return str.strip(str.upper(vaccine_type))
69+
return str.strip(str.lower(vaccine_type))
7070

7171
def get_imms_id(primary_key: str) -> str:
7272
return primary_key.split("#")[1]

delta_backend/tests/utils_for_converter_tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def get_event_record(imms_id, event_name, operation, supplier="EMIS"):
179179
"ApproximateCreationDateTime": 1690896000,
180180
"NewImage": {
181181
"PK": {"S": pk},
182-
"PatientSK": {"S": "Covid19#ca8ba2c6-2383-4465-b456-c1174c21cf31"},
182+
"PatientSK": {"S": "COVID19#ca8ba2c6-2383-4465-b456-c1174c21cf31"},
183183
"IdentifierPK": {"S": "system#1"},
184184
"Operation": {"S": operation},
185185
"SupplierSystem": {"S": supplier},
@@ -195,15 +195,15 @@ def get_event_record(imms_id, event_name, operation, supplier="EMIS"):
195195
"ApproximateCreationDateTime": 1690896000,
196196
"Keys": {
197197
"PK": {"S": pk},
198-
"PatientSK": {"S": "Covid19#ca8ba2c6-2383-4465-b456-c1174c21cf31"},
198+
"PatientSK": {"S": "COVID19#ca8ba2c6-2383-4465-b456-c1174c21cf31"},
199199
"SupplierSystem": {"S": supplier},
200200
"Resource": {"S": ValuesForTests.json_value_for_test},
201201
}
202202
}
203203
}
204204

205205
expected_static_values = {
206-
"VaccineType": "COVID19",
206+
"VaccineType": "covid19",
207207
"SupplierSystem": "EMIS",
208208
"Source": "test-source",
209209
"ImmsID": "12345",

0 commit comments

Comments
 (0)