code overview

Author: Akol125

mns_subscription/models/errors.py

@@ -14,7 +14,7 @@ class Code(str, Enum):
     invalid = "invalid or missing access token"
     server_error = "internal server error"
     invariant = "invariant"
-    not_supported = "not-supported"
+    incomplete = "parameter-incomplete"
     duplicate = "duplicate"
     # Added an unauthorized code its used when returning a response for an unauthorized vaccine type search.
     unauthorized = "unauthorized"
@@ -129,7 +129,7 @@ def to_operation_outcome(self) -> dict:
         return create_operation_outcome(
             resource_id=str(uuid.uuid4()),
             severity=Severity.error,
-            code=Code.server_error,
+            code=Code.incomplete,
             diagnostics=self.__str__(),
         )
 

mns_subscription/src/mns_service.py

@@ -47,13 +47,6 @@ def __init__(self, authenticator: AppRestrictedAuth):
     def subscribe_notification(self) -> dict | None:
 
         response = requests.post(MNS_URL, headers=self.request_headers, data=json.dumps(self.subscription_payload))
-
-        print(f"Access Token: {self.access_token}")
-        print(f"SQS ARN: {SQS_ARN}")
-        print(f"MNS_URL: {MNS_URL}")
-        print(f"Headers: {self.request_headers}")
-        print(f"Payload: {json.dumps(self.subscription_payload, indent=2)}")
-
         if response.status_code in (200, 201):
             return response.json()
         else:

mns_subscription/tests/test_mns_service.py

@@ -241,7 +241,7 @@ def test_check_delete_subscription_no_resource(self, mock_get_subscription):
     @patch.object(MnsService, "get_subscription")
     def test_check_delete_subscription_missing_id(self, mock_get_subscription):
         # Resource with no id field
-        mock_get_subscription.return_value = {"not_id": "nope"}
+        mock_get_subscription.return_value = {"not_id": "not-id"}
         service = MnsService(self.authenticator)
         result = service.check_delete_subcription()
         self.assertEqual(result, "Subscription resource missing 'id' field.")