pass variables to imms event lambdas

Author: Akol125

infrastructure/instance/.terraform.lock.hcl

@@ -59,6 +59,10 @@ data "aws_iam_policy_document" "imms_policy_document" {
   ]
 }
 
+data "aws_sns_topic" "fhir_api_errors" {
+  name = "${var.environment}-fhir-api-errors"
+}
+
 data "aws_iam_policy_document" "imms_data_quality_s3_doc" {
   source_policy_documents = [
     templatefile("${local.policy_path}/s3_data_quality_access.json", {
@@ -77,14 +81,16 @@ module "imms_event_endpoint_lambdas" {
   source = "./modules/lambda"
   count  = length(local.imms_endpoints)
 
-  prefix                 = local.prefix
-  short_prefix           = local.short_prefix
-  function_name          = local.imms_endpoints[count.index]
-  image_uri              = module.docker_image.image_uri
-  policy_json            = data.aws_iam_policy_document.imms_policy_document.json
-  environment_variables  = local.imms_lambda_env_vars
-  vpc_subnet_ids         = local.private_subnet_ids
-  vpc_security_group_ids = [data.aws_security_group.existing_securitygroup.id]
+  prefix                            = local.prefix
+  short_prefix                      = local.short_prefix
+  function_name                     = local.imms_endpoints[count.index]
+  image_uri                         = module.docker_image.image_uri
+  policy_json                       = data.aws_iam_policy_document.imms_policy_document.json
+  environment_variables             = local.imms_lambda_env_vars
+  vpc_subnet_ids                    = local.private_subnet_ids
+  vpc_security_group_ids            = [data.aws_security_group.existing_securitygroup.id]
+  aws_sns_topic                     = data.aws_sns_topic.fhir_api_errors.arn
+  error_alarm_notifications_enabled = var.error_alarm_notifications_enabled
 }
 
 

infrastructure/instance/endpoints.tf

@@ -54,25 +54,25 @@ resource "aws_cloudwatch_log_metric_filter" "max_memory_used_metric" {
 resource "aws_cloudwatch_log_metric_filter" "fhir_api_error_logs" {
   count = var.error_alarm_notifications_enabled ? 1 : 0
 
-  name           = "${local.short_prefix}_${var.function_name}-ErrorLogsFilter"
+  name           = "${var.short_prefix}_${var.function_name}-ErrorLogsFilter"
   pattern        = "{ $.operation_outcome.status = \"500\" || $.operation_outcome.status = \"403\" }"
   log_group_name = module.lambda_function_container_image.lambda_cloudwatch_log_group_name
 
   metric_transformation {
-    name      = "${local.short_prefix}_${var.function_name}-ApiErrorLogs"
-    namespace = "${local.short_prefix}-_${var.function_name}-Lambda"
+    name      = "${var.short_prefix}_${var.function_name}-ApiErrorLogs"
+    namespace = "${var.short_prefix}_${var.function_name}-Lambda"
     value     = "1"
   }
 }
 
 resource "aws_cloudwatch_metric_alarm" "fhir_api_error_alarm" {
   count = var.error_alarm_notifications_enabled ? 1 : 0
 
-  alarm_name          = "${local.short_prefix}_${var.function_name}-lambda-error"
+  alarm_name          = "${var.short_prefix}_${var.function_name}-lambda-error"
   comparison_operator = "GreaterThanOrEqualToThreshold"
   evaluation_periods  = 1
-  metric_name         = "${local.short_prefix}_${var.function_name}-ErrorLogs"
-  namespace           = "${local.short_prefix}_${var.function_name}-Lambda"
+  metric_name         = "${var.short_prefix}_${var.function_name}-ErrorLogs"
+  namespace           = "${var.short_prefix}_${var.function_name}-Lambda"
   period              = 120
   statistic           = "Sum"
   threshold           = 1