terraform

Author: nhsdevws

.github/workflows/sonarcloud.yml

@@ -126,19 +126,10 @@ jobs:
           PYTHONPATH: ${{ env.SHARED_PATH }}
         continue-on-error: true
         run: |
-            echo "shared coverage - Current directory: $(pwd)"
             poetry env use 3.11
             poetry install
             poetry run coverage run --source=src -m unittest discover -s tests -p "test_*.py" -v || echo "shared tests failed" >> ../../failed_tests.txt
             poetry run coverage xml -o ../../shared-coverage.xml
-            ls ../../shared-coverage.xml
-            # show director of ../.. as absolute path
-            echo "Parent directory of shared-coverage.xml: $(pwd)/../../"
-            #check files created
-            if [ ! -f ../../shared-coverage.xml ]; then
-              echo "shared-coverage.xml not found"
-            fi
-            cat ../../shared-coverage.xml
 
       - name: Run unittest with id_sync
         working-directory: lambdas/id_sync
@@ -147,26 +138,14 @@ jobs:
           PYTHONPATH: ${{ env.LAMBDA_PATH }}/id_sync/src:${{ env.LAMBDA_PATH }}/id_sync/tests:${{ env.SHARED_PATH }}
         continue-on-error: true
         run: |
-            echo "id_sync coverage - Current directory: $(pwd)"
             poetry env use 3.11
             poetry install
             poetry run coverage run -m unittest discover || echo "id_sync tests failed" >> ../../failed_tests.txt
             poetry run coverage xml -o ../../id_sync-coverage.xml
-            #check files created
-            if [ ! -f ../../id_sync-coverage.xml ]; then
-              echo "id_sync-coverage.xml not found, exiting with error"
-            fi
-            cat ../../id_sync-coverage.xml
 
       - name: Run Test Failure Summary
         id: check_failure
         run: |
-          # list all coverage xml files
-          echo "Coverage XML files:"
-          find . -name "*.xml" -print
-          echo "Review shared-coverage.xml for shared coverage"
-          cat shared-coverage.xml
-          # Check if failed_tests.txt exists and is not empty
           if [ -s failed_tests.txt ]; then
             echo "The following tests failed:"
             cat failed_tests.txt

.gitignore

@@ -29,6 +29,4 @@ openapi.json
 !**/.vscode/settings.json.default
 
 devtools/volume/
-backend/tests/.coverage
-redis_sync/.vscode/settings.json.default
-lambdas/shared/.coverage
+**/.coverage

redis_sync/.vscode/settings.json.default

@@ -0,0 +1,18 @@
+{
+    "python.analysis.extraPaths": [
+        "./src"
+    ],
+    "python.testing.unittestArgs": [
+        "-v",
+        "-s",
+        "./",
+        "-p",
+        "test_*.py"
+    ],
+    "python.testing.pytestEnabled": false,
+    "python.testing.unittestEnabled": true,
+    "pylint.args": [
+        "--init-hook",
+        "import sys; sys.path.append('./src')"
+    ]
+}

terraform/id_sync_lambda.tf

@@ -33,7 +33,6 @@ output "debug_build_paths" {
 output "debug_file_listing" {
   value = {
     shared_files_sample    = slice(local.shared_files, 0, min(5, length(local.shared_files)))
-    id_sync_files_sample   = slice(local.id_sync_lambda_files, 0, min(5, length(local.id_sync_lambda_files)))
   }
 }