WIP

Author: nhsdevws

delta_backend/src/delta.py

@@ -27,6 +27,7 @@ def send_message(record):
     sqs_client = boto3.client("sqs")
     try:
         # Send the record to the queue
+        print(f"Sending record to DLQ: {message_body}")
         sqs_client.send_message(QueueUrl=failure_queue_url, MessageBody=json.dumps(message_body))
         logger.info("Record saved successfully to the DLQ")
     except ClientError as e:
@@ -58,7 +59,7 @@ def handler(event, context):
             response = str()
             imms_id = str()
             operation = str()
-            if record["eventName"] != "REMOVE":
+            if record["eventName"] != "DELETE":
                 new_image = record["dynamodb"]["NewImage"]
                 imms_id = new_image["PK"]["S"].split("#")[1]
                 supplier_system = new_image["SupplierSystem"]["S"]
@@ -73,15 +74,15 @@ def handler(event, context):
                     logger.info(f"Record from DPS skipped for {imms_id}")
                     return {"statusCode": 200, "body": f"Record from DPS skipped for {imms_id}"}
             else:
-                operation = "REMOVE"
+                operation = "DELETE"
                 new_image = record["dynamodb"]["Keys"]
                 logger.info(f"Record to delta:{new_image}")
                 imms_id = new_image["PK"]["S"].split("#")[1]
                 response = delta_table.put_item(
                     Item={
                         "PK": str(uuid.uuid4()),
                         "ImmsID": imms_id,
-                        "Operation": "REMOVE",
+                        "Operation": "DELETE",
                         "VaccineType": "default",
                         "SupplierSystem": "default",
                         "DateTimeStamp": approximate_creation_time.isoformat(),

delta_backend/src/helpers/delta_data.py

@@ -20,7 +20,7 @@ def get_data(self):
         return self.data
 
 
-    def get_vaccine_type(patientsk) -> str:
+    def get_vaccine_type(self, patientsk) -> str:
         parsed = [str.strip(str.lower(s)) for s in patientsk.split("#")]
         return parsed[0]
 

delta_backend/tests/test_delta.py

@@ -105,6 +105,7 @@ def test_send_message_success(self, mock_boto_client):
         record = {"key": "value"}
 
         # Act
+        print(f"test_send_message_success.Sending record to DLQ: {record}")
         send_message(record)
 
         # Assert
@@ -184,7 +185,7 @@ def test_handler_success_update(self, mock_boto_resource, mock_write_to_db):
     def test_handler_success_remove(self, mock_boto_resource):
         # Arrange
         self.setup_mock_dynamodb(mock_boto_resource)
-        event = self.get_event(event_name="REMOVE", operation=EndpointOperationNames.DELETE)
+        event = self.get_event(event_name="DELETE", operation=EndpointOperationNames.DELETE)
 
         # Act
         result = handler(event, self.context)