Skip to content

Commit 4495561

Browse files
committed
VED-763: Fix lint errors.
1 parent c50158b commit 4495561

File tree

3 files changed

+25
-12
lines changed

3 files changed

+25
-12
lines changed

filenameprocessor/src/file_validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Functions for file key validation"""
22

3-
from re import match
43
from datetime import datetime
4+
55
from constants import VALID_VERSIONS, EMPTY_BATCH_FILE_SIZE_IN_BYTES
66
from elasticache import get_valid_vaccine_types_from_cache, get_supplier_system_from_cache
77
from errors import InvalidFileKeyError, EmptyFileError

filenameprocessor/tests/test_file_key_validation.py

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
class TestFileKeyValidation(TestCase):
2020
"""Tests for file_key_validation functions"""
21+
2122
def test_is_file_in_directory_root(self):
2223
test_cases = [
2324
("test_file.csv", True),
@@ -79,37 +80,48 @@ def test_validate_file_key(self, mock_hkeys, mock_hget):
7980
# File key with no '.'
8081
(VALID_FLU_EMIS_FILE_KEY.replace(".", ""), "Initial file validation failed: missing file extension"),
8182
# File key with additional '.' in vaccine type
82-
(VALID_FLU_EMIS_FILE_KEY[:2] + "." + VALID_FLU_EMIS_FILE_KEY[2:],"Initial file validation failed: unsupported vaccine type"),
83+
(VALID_FLU_EMIS_FILE_KEY[:2] + "." + VALID_FLU_EMIS_FILE_KEY[2:],
84+
"Initial file validation failed: unsupported vaccine type"),
8385
# File key with additional '_' in vaccine type
84-
(VALID_FLU_EMIS_FILE_KEY[:2] + "_" + VALID_FLU_EMIS_FILE_KEY[2:],"Initial file validation failed: unsupported vaccine type"),
86+
(VALID_FLU_EMIS_FILE_KEY[:2] + "_" + VALID_FLU_EMIS_FILE_KEY[2:],
87+
"Initial file validation failed: unsupported vaccine type"),
8588
# File key with missing '_'
86-
(VALID_FLU_EMIS_FILE_KEY.replace("_", "", 1), "Initial file validation failed: not enough parts in file key"),
89+
(VALID_FLU_EMIS_FILE_KEY.replace("_", "", 1),
90+
"Initial file validation failed: not enough parts in file key"),
8791
# File key with missing '_'
8892
(VALID_FLU_EMIS_FILE_KEY.replace("_", ""), "Initial file validation failed: not enough parts in file key"),
8993
# File key with missing extension
9094
(VALID_FLU_EMIS_FILE_KEY.replace(".csv", ""), "Initial file validation failed: missing file extension"),
9195
# File key with invalid vaccine type
92-
(VALID_FLU_EMIS_FILE_KEY.replace("FLU", "Flue"), "Initial file validation failed: unsupported vaccine type"),
96+
(VALID_FLU_EMIS_FILE_KEY.replace("FLU", "Flue"),
97+
"Initial file validation failed: unsupported vaccine type"),
9398
# File key with missing vaccine type
9499
(VALID_FLU_EMIS_FILE_KEY.replace("FLU", ""), "Initial file validation failed: unsupported vaccine type"),
95100
# File key with invalid vaccinations element
96-
(VALID_FLU_EMIS_FILE_KEY.replace("Vaccinations", "Vaccination"),"Initial file validation failed: file key must contain VACCINATIONS"),
101+
(VALID_FLU_EMIS_FILE_KEY.replace("Vaccinations", "Vaccination"),
102+
"Initial file validation failed: file key must contain VACCINATIONS"),
97103
# File key with missing vaccinations element
98-
(VALID_FLU_EMIS_FILE_KEY.replace("Vaccinations", ""), "Initial file validation failed: file key must contain VACCINATIONS"),
104+
(VALID_FLU_EMIS_FILE_KEY.replace("Vaccinations", ""),
105+
"Initial file validation failed: file key must contain VACCINATIONS"),
99106
# File key with invalid version
100107
(VALID_FLU_EMIS_FILE_KEY.replace("v5", "v4"), "Initial file validation failed: unsupported file version"),
101108
# File key with missing version
102109
(VALID_FLU_EMIS_FILE_KEY.replace("v5", ""), "Initial file validation failed: unsupported file version"),
103110
# File key with invalid ODS code
104-
(VALID_FLU_EMIS_FILE_KEY.replace("YGM41", "YGAM"), "Initial file validation failed: unregistered supplier ODS code"),
111+
(VALID_FLU_EMIS_FILE_KEY.replace("YGM41", "YGAM"),
112+
"Initial file validation failed: unregistered supplier ODS code"),
105113
# File key with missing ODS code
106-
(VALID_FLU_EMIS_FILE_KEY.replace("YGM41", ""), "Initial file validation failed: unregistered supplier ODS code"),
114+
(VALID_FLU_EMIS_FILE_KEY.replace("YGM41", ""),
115+
"Initial file validation failed: unregistered supplier ODS code"),
107116
# File key with invalid timestamp
108-
(VALID_FLU_EMIS_FILE_KEY.replace("20000101T00000001", "20200132T12345600"),"Initial file validation failed: invalid timestamp"),
117+
(VALID_FLU_EMIS_FILE_KEY.replace("20000101T00000001", "20200132T12345600"),
118+
"Initial file validation failed: invalid timestamp"),
109119
# File key with missing timestamp
110-
(VALID_FLU_EMIS_FILE_KEY.replace("20000101T00000001", ""),"Initial file validation failed: invalid timestamp"),
120+
(VALID_FLU_EMIS_FILE_KEY.replace("20000101T00000001", ""),
121+
"Initial file validation failed: invalid timestamp"),
111122
# File key with incorrect extension
112-
(VALID_FLU_EMIS_FILE_KEY.replace(".csv", ".xlsx"), "Initial file validation failed: unsupported file extension"),
123+
(VALID_FLU_EMIS_FILE_KEY.replace(".csv", ".xlsx"),
124+
"Initial file validation failed: unsupported file extension"),
113125
]
114126

115127
for file_key, expected_result in test_cases_for_failure_scenarios:

mesh_processor/src/converter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
aws_account_id = sts_client.get_caller_identity()['Account']
1717

18+
1819
def parse_headers(headers_str: str) -> dict[str, str]:
1920
headers = dict(
2021
header_str.split(":", 1)

0 commit comments

Comments
 (0)