VED-740: correcting parseobj response failure

Author: Akol125

backend/src/fhir_controller.py

@@ -102,7 +102,7 @@ def get_immunization_by_identifier(self, aws_event) -> dict:
         try:
             if resource := self.fhir_service.get_immunization_by_identifier(
                 identifiers, imms_vax_type_perms, identifier, element):
-                return FhirController.create_response(200, json.dumps(resource))
+                return FhirController.create_response(200, resource)
         except UnauthorizedVaxError as unauthorized:
             return self.create_response(403, unauthorized.to_operation_outcome())
 

backend/src/models/utils/generic_utils.py

@@ -1,7 +1,7 @@
 """Generic utilities"""
 
 import datetime
-
+import json
 from typing import Literal, Union, Optional, Dict, Any
 from fhir.resources.R4B.bundle import (
     Bundle as FhirBundle,
@@ -179,7 +179,8 @@ def form_json(response, _elements, identifier, baseurl):
         entry=[entry], 
         total=1)
 
-    data = fhir_bundle.dict(by_alias=True)
+
+    data = json.loads(fhir_bundle.json(by_alias=True))
     data["total"] = data.pop("total")
     return data
 

backend/tests/utils/test_generic_utils.py

@@ -1,6 +1,5 @@
 """Generic utils for tests"""
 
-import json
 import unittest
 from src.models.utils.generic_utils import form_json
 from tests.utils.generic_utils import load_json_data
@@ -13,7 +12,7 @@ def setUp(self):
         self.response = {
             "resource": load_json_data("completed_covid19_immunization_event.json"),
             "id": "f10b59b3-fc73-4616-99c9-9e882ab31184",
-            "version": 2,
+            "version": "2",
         }
 
         self.maxDiff = None
@@ -30,7 +29,7 @@ def test_identifier_only_returns_full_resource(self):
         out = form_json(self.response, None, self.identifier, self.baseurl)
         self.assertEqual(out["total"], 1)
         self.assertEqual(out["link"][0]["url"], f"{self.baseurl}?identifier={self.identifier}")
-        self.assertDictEqual(json.loads(out["entry"][0]["resource"]), json.loads(self.response["resource"]))
+        self.assertDictEqual(out["entry"][0]["resource"], self.response["resource"])
         self.assertEqual(out["entry"][0]["fullUrl"], f"{self.baseurl}/{self.response['id']}")
 
     def test_identifier_with_id_element_truncates_to_id(self):