tidy

Author: nhsdevws

lambdas/id_sync/src/id_sync.py

@@ -30,13 +30,13 @@ def handler(event_data, _):
                                       nhs_numbers=nhs_numbers)
 
             else:
-                msg = f"Successfully processed {record_count} records"
-                logger.info(msg)
-                return {"status": "success", "message": msg, "nhs_numbers": nhs_numbers}
+                response = {"status": "success",
+                            "message": f"Successfully processed {record_count} records",
+                            "nhs_numbers": nhs_numbers}
         else:
-            logger.info("No records found in event")
-            return {"status": "success", "message": "No records found in event"}
-
+            response = {"status": "success", "message": "No records found in event"}
+        logger.info("id_sync handler completed: %s", response)
+        return response
     except IdSyncException as e:
         logger.exception(f"id_sync error: {e.message}")
         raise e

lambdas/id_sync/src/junk.json

@@ -15,22 +15,18 @@
 
 def pds_get_patient_details(nhs_number: str) -> dict:
     try:
-        logger.info(f"pds_get_patient_details. nhs_number: {nhs_number}")
+        logger.info(f"get patient details. nhs_number: {nhs_number}")
 
-        logger.info("SAW...1")
         cache = Cache(directory=safe_tmp_dir)
-        logger.info("SAW...2")
         authenticator = AppRestrictedAuth(
             service=Service.PDS,
             secret_manager_client=secrets_manager_client,
             environment=pds_env,
             cache=cache,
         )
-        logger.info("SAW...3")
         pds_service = PdsService(authenticator, pds_env)
-        logger.info("SAW...4")
         patient = pds_service.get_patient_details(nhs_number)
-        logger.info("SAW...5")
+        logger.info("get patient details. response: %s", patient)
         return patient
     except Exception as e:
         msg = f"Error getting PDS patient details for {nhs_number}"

lambdas/id_sync/src/pds_details.py

@@ -12,9 +12,7 @@
 def process_record(event_record):
 
     logger.info("process_record. Processing record: %s", event_record)
-    logger.info("process_record...1")
     body_text = event_record.get('body', '')
-    logger.info("process_record. Body text: %s", body_text)
     # convert body to json
     if isinstance(body_text, str):
         try:
@@ -29,14 +27,12 @@ def process_record(event_record):
                 return {"status": "error", "message": "Invalid body format"}
     else:
         body = body_text
-    logger.info("process_record. Parsed body: %s", body)
     nhs_number = body.get("subject")
-    logger.info("process_record. NHS number: %s", nhs_number)
+    logger.info("process record NHS number: %s", nhs_number)
     if nhs_number:
-        logger.info("process_record. Process NHS number: %s", nhs_number)
         return process_nhs_number(nhs_number)
     else:
-        logger.error("process_record. No NHS number found in event record")
+        logger.info("No NHS number found in event record")
         return {"status": "error", "message": "No NHS number found in event record"}
 
 

lambdas/id_sync/src/record_processor.py

@@ -174,7 +174,6 @@ def test_handler_empty_records(self):
 
         # Assertions
         self.mock_aws_lambda_event.assert_called_once_with(self.empty_event)
-        self.mock_logger.info.assert_any_call("No records found in event")
         self.mock_process_record.assert_not_called()
 
         self.assertEqual(result["status"], "success")
@@ -192,7 +191,6 @@ def test_handler_no_records_key(self):
 
         # Assertions
         self.mock_aws_lambda_event.assert_called_once_with(self.no_records_event)
-        self.mock_logger.info.assert_any_call("No records found in event")
         self.mock_process_record.assert_not_called()
 
         self.assertEqual(result["status"], "success")

lambdas/id_sync/tests/test_id_sync.py

@@ -0,0 +1,55 @@
+{
+  "address": [
+    {
+      "id": "07626C74",
+      "line": ["44 Rathbone Street", "Ventnor", "Sd", "Sd"],
+      "period": { "start": "2025-06-04" },
+      "postalCode": "E14 8AH",
+      "use": "home"
+    }
+  ],
+  "birthDate": "2000-08-11",
+  "gender": "male",
+  "id": "9001063152",
+  "identifier": [
+    {
+      "extension": [
+        {
+          "url": "https://fhir.hl7.org.uk/StructureDefinition/Extension-UKCore-NHSNumberVerificationStatus",
+          "valueCodeableConcept": {
+            "coding": [
+              {
+                "code": "01",
+                "display": "Number present and verified",
+                "system": "https://fhir.hl7.org.uk/CodeSystem/UKCore-NHSNumberVerificationStatus",
+                "version": "1.0.0"
+              }
+            ]
+          }
+        }
+      ],
+      "system": "https://fhir.nhs.uk/Id/nhs-number",
+      "value": "9001063152"
+    }
+  ],
+  "meta": {
+    "security": [
+      {
+        "code": "U",
+        "display": "unrestricted",
+        "system": "http://terminology.hl7.org/CodeSystem/v3-Confidentiality"
+      }
+    ],
+    "versionId": "1"
+  },
+  "name": [
+    {
+      "family": "Draper",
+      "given": ["Oakley"],
+      "id": "C4A640A1",
+      "period": { "start": "2025-06-04" },
+      "use": "usual"
+    }
+  ],
+  "resourceType": "Patient"
+}