Skip to content

Commit 4b953e9

Browse files
committed
get_delta_table
1 parent 9b7e496 commit 4b953e9

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

lambdas/delta_backend/src/delta.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
import time
55
from datetime import UTC, datetime, timedelta
66

7-
import boto3
87
from boto3.dynamodb.conditions import Attr
98
from botocore.exceptions import ClientError
109

10+
from common.aws_dynamodb import get_dynamodb_table
1111
from common.clients import STREAM_NAME, get_sqs_client, logger
1212
from common.log_firehose import send_log_to_firehose
1313
from converter import Converter
@@ -30,8 +30,7 @@ def get_delta_table():
3030
if not delta_table:
3131
try:
3232
logger.info("Initializing Delta Table")
33-
dynamodb = boto3.resource("dynamodb", region_name)
34-
delta_table = dynamodb.Table(delta_table_name)
33+
delta_table = get_dynamodb_table(delta_table_name)
3534
except Exception as e:
3635
logger.error(f"Error initializing Delta Table: {e}")
3736
delta_table = None

lambdas/delta_backend/tests/test_delta.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -641,20 +641,20 @@ def test_returns_table_on_success(self):
641641
# Should cache the table
642642
self.assertIs(delta.delta_table, self.mock_delta_table)
643643

644-
@patch("boto3.resource")
645-
def test_returns_cached_table(self, mock_boto3_resource):
644+
@patch("delta.get_dynamodb_table")
645+
def test_returns_cached_table(self, mock_get_dynamodb_table):
646646
delta.delta_table = self.mock_delta_table
647647

648648
table = delta.get_delta_table()
649649
self.assertIs(table, self.mock_delta_table)
650-
# Should not call boto3 again
651-
mock_boto3_resource.assert_not_called()
650+
# Should not call get_dynamodb_table again
651+
mock_get_dynamodb_table.assert_not_called()
652652

653-
# mock boto3.resource to raise an exception
654-
@patch("boto3.resource")
655-
def test_returns_none_on_exception(self, mock_boto3_resource):
653+
# mock get_dynamodb_table to raise an exception
654+
@patch("delta.get_dynamodb_table")
655+
def test_returns_none_on_exception(self, mock_get_dynamodb_table):
656656
delta.delta_table = None
657-
mock_boto3_resource.side_effect = Exception("fail")
657+
mock_get_dynamodb_table.side_effect = Exception("fail")
658658
table = delta.get_delta_table()
659659
self.assertIsNone(table)
660660
self.mock_logger_error.assert_called()

0 commit comments

Comments
 (0)