VED-755: remove duplication

Author: Akol125

lambdas/id_sync/src/pds_details.py

@@ -55,22 +55,3 @@ def pds_get_patient_id(nhs_number: str) -> str:
         logger.exception(msg)
         raise IdSyncException(message=msg, exception=e)
 
-
-def normalize_name_from_pds(pds_get_patient_details: dict) -> str | None:
-    """Return a normalized full name (given + family) from PDS patient details or None."""
-    try:
-        name = pds_get_patient_details.get("name")
-        if not name:
-            return None
-        name_entry = name[0] if isinstance(name, list) else name
-        given = name_entry.get("given")
-        given_str = None
-        if isinstance(given, list) and given:
-            given_str = given[0]
-        elif isinstance(given, str):
-            given_str = given
-        family = name_entry.get("family")
-        parts = [p for p in [given_str, family] if p]
-        return " ".join(parts).strip().lower() if parts else None
-    except Exception:
-        return None

lambdas/id_sync/src/record_processor.py

@@ -1,6 +1,6 @@
 from common.clients import logger
 from typing import Dict, Any
-from pds_details import pds_get_patient_id, pds_get_patient_details, normalize_name_from_pds
+from pds_details import pds_get_patient_id, pds_get_patient_details
 from ieds_db_operations import (
     ieds_check_exist,
     ieds_update_patient_id,
@@ -138,7 +138,7 @@ def normalize_strings(item: Any) -> str | None:
             return str(item).strip().lower() if item else None
 
         # Retrieve patient resource from PDS
-        pds_name = normalize_strings(normalize_name_from_pds(pds_details))
+        pds_name = normalize_strings(extract_normalized_name_from_patient(pds_details))
         pds_gender = normalize_strings(pds_details.get("gender"))
         pds_birth = normalize_strings(pds_details.get("birthDate"))
 
@@ -149,7 +149,7 @@ def normalize_strings(item: Any) -> str | None:
             return False
 
         # normalize patient name
-        ieds_name = extract_normalized_name_from_patient(patient)
+        ieds_name = normalize_strings(extract_normalized_name_from_patient(patient))
 
         ieds_gender = normalize_strings(patient.get("gender"))
         ieds_birth = patient.get("birthDate")