cleanup

Author: JamesW1-NHS

lambdas/backend/tests/service/test_fhir_service.py

@@ -13,7 +13,6 @@
 
 from authorisation.api_operation_code import ApiOperationCode
 from authorisation.authoriser import Authoriser
-from common.models.constants import NHS_NUMBER_USED_IN_SAMPLE_DATA
 from common.models.errors import (
     CustomValidationError,
     IdentifierDuplicationError,
@@ -34,6 +33,9 @@
     create_covid_immunization_dict_no_id,
 )
 
+# Constants for use within the tests
+NHS_NUMBER_USED_IN_SAMPLE_DATA = "9000000009"
+
 
 class TestFhirServiceBase(unittest.TestCase):
     """Base class for all tests to set up common fixtures"""

lambdas/recordforwarder/README.md

@@ -19,6 +19,6 @@ Note: Paths are relative to this directory, `recordforwarder`.
 
 4. Run `make test` to run unit tests or individual tests by running:
     ```
-    python -m unittest tests.test_fhir_controller.TestSearchImmunizations
-    python -m unittest tests.test_fhir_controller.TestSearchImmunizations.test_search_immunizations
+    python -m unittest tests.test_fhir_batch_controller.TestCreateImmunizationBatchController
+    python -m unittest tests.test_fhir_batch_controller.TestCreateImmunizationBatchController.test_send_request_to_dynamo_create_success
     ```

lambdas/recordforwarder/src/constants.py

@@ -60,12 +60,6 @@ class Constants:
     REINSTATED_RECORD_STATUS = "reinstated"
 
 
-# Constants for use within the test
-VALID_NHS_NUMBER = "1345678940"  # Valid for pre, FHIR and post validators
-NHS_NUMBER_USED_IN_SAMPLE_DATA = "9000000009"
-ADDRESS_UNKNOWN_POSTCODE = "ZZ99 3WZ"
-
-
 class Urls:
     """Urls which are expected to be used within the FHIR Immunization Resource json data"""