VED-79: Resolve sonar issues

Author: Akol125

.github/workflows/sonarcloud.yml

@@ -112,6 +112,7 @@ jobs:
         run: |
           poetry install
           poetry run coverage run -m unittest discover || echo "mns_subscription tests failed" >> ../failed_tests.txt
+          poetry run coverage report -m
           poetry run coverage xml -o ../mns_subscription-coverage.xml
 
       - name: Run unittest with redis_sync

azure/azure-pr-pipeline.yml

@@ -40,10 +40,6 @@ extends:
           - template: ./templates/post-deploy.yml
             parameters:
               aws_account_type: 'dev'
-          - script: |
-              echo "Creating MNS subscription..."
-              python3 backend/src/mns/subscribe.py
-            displayName: "Subscribe SQS to MNS signal"
       - environment: internal-dev-sandbox
         proxy_path: sandbox
         jinja_templates:

azure/templates/post-deploy.yml

@@ -77,10 +77,6 @@ steps:
     displayName: Apply Terraform
     workingDirectory: "$(Pipeline.Workspace)/s/$(SERVICE_NAME)/$(SERVICE_ARTIFACT_NAME)"
     retryCountOnTaskFailure: 2
-  - bash: |
-      echo "Creating MNS subscription..."
-      python3 mns_subscription/src/subscribe_mns.py
-      displayName: "Subscribe SQS to MNS signal"
 
   - bash: |
       set -ex

mns_subscription/pyproject.toml

@@ -1,15 +1,8 @@
-[project]
-name = "mns-subscription"
-version = "0.1.0"
-description = "subscription to nhs number change event"
-
-
 [tool.poetry]
 name        = "mns-subscription"
 version     = "0.1.0"
 description = ""
 authors     = ["Your Name <[email protected]>"]
-license     = "MIT"
 packages    = [{include = "src"}]
 
 [tool.poetry.dependencies]

sonar-project.properties

@@ -5,7 +5,7 @@ sonar.host.url=https://sonarcloud.io
 sonar.python.version=3.11
 sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**,redis_sync/src/log_decorator.py
 sonar.python.coverage.reportPaths=backend-coverage.xml,delta-coverage.xml,ack-lambda-coverage.xml,filenameprocessor-coverage.xml,recordforwarder-coverage.xml,recordprocessor-coverage.xml,mesh_processor-coverage.xml,redis_sync-coverage.xml,mns_subscription-coverage.xml
-sonar.cpd.exclusions=**/cache.py,**/authentication.py,**/test_cache.py,**/test_authentication.py
+sonar.cpd.exclusions=**/cache.py,**/authentication.py,**/test_cache.py,**/test_authentication.py,**/mns_service.py,**/errors.py
 sonar.issue.ignore.multicriteria=exclude_snomed_urls,exclude_hl7_urls
 sonar.issue.ignore.multicriteria.exclude_snomed_urls.ruleKey=python:S5332
 sonar.issue.ignore.multicriteria.exclude_snomed_urls.resourceKey=**http://snomed\.info/sct**