remock test imm post valid

Author: nhsdevws

backend/tests/test_immunization_post_validator.py

@@ -6,7 +6,6 @@
 from copy import deepcopy
 from pydantic import ValidationError
 from jsonpath_ng.ext import parse
-from utils.mock_redis import mock_redis_hget
 
 
 from models.fhir_immunization import ImmunizationValidator
@@ -18,7 +17,8 @@
 from tests.utils.mandation_test_utils import MandationTests
 from tests.utils.values_for_tests import NameInstances
 from tests.utils.generic_utils import update_contained_resource_field
-from utils.mock_redis import MOCK_REDIS_D2V_RESPONSE, MOCK_REDIS_V2D_RESPONSE
+# import redis mock functions
+from utils.mock_redis import mock_redis_hget, mock_redis_hkeys
 
 class TestImmunizationModelPostValidationRules(unittest.TestCase):
     """Test immunization post validation rules on the FHIR model"""
@@ -42,13 +42,16 @@ def setUp(self):
         ]
         self.redis_patcher = patch("models.utils.validation_utils.redis_client")
         self.mock_redis_client = self.redis_patcher.start()
-        self.mock_redis_client.hget.side_effect = mock_redis_hget
+
+    def tearDown(self):
+        """Tear down after each test. This runs after every test"""
+        self.redis_patcher.stop()
 
     def test_collected_errors(self):
         """Test that when passed multiple validation errors, it returns a list of all expected errors"""
 
         covid_19_json_data = deepcopy(self.completed_json_data["COVID19"])
-
+        self.mock_redis_client.hget.return_value = 'COVID19'
         for patient in covid_19_json_data["contained"]:
             if patient["resourceType"] == "Patient":
                 for name in patient["name"]:
@@ -80,6 +83,7 @@ def test_collected_errors(self):
 
     def test_sample_data(self):
         """Test that each piece of valid sample data passes post validation"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         for json_data in list(self.completed_json_data.values()):
             self.assertIsNone(self.validator.validate(json_data))
 
@@ -95,6 +99,11 @@ def test_post_validate_and_set_vaccine_type(self):
             "protocolApplied[0].targetDisease[0].coding[?(@.system=='http://snomed.info/sct')].code"
         )
 
+        # self.mock_redis_client.hget.side_effect = mock_redis_hget
+        self.mock_redis_client.hget.side_effect = [ "COVID19", "FLU",
+            "HPV",
+            "MMR",
+            "RSV", None]
         # Test that a valid combination of disease codes is accepted
         for vaccine_type in [
             "COVID19",
@@ -115,6 +124,8 @@ def test_post_validate_and_set_vaccine_type(self):
             + " - ['INVALID_VALUE'] is not a valid combination of disease codes for this service",
         )
 
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.hget.return_value = None
         # Test that an invalid combination of disease codes is rejected
         invalid_target_disease = [
             {"coding": [{"system": "http://snomed.info/sct", "code": "14189004", "display": "Measles"}]},
@@ -138,6 +149,7 @@ def test_post_validate_and_set_vaccine_type(self):
 
     def test_post_vaccination_procedure_code(self):
         """Test that the JSON data is rejected if it does not contain vaccination_procedure_code"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         field_location = (
             "extension[?(@.url=='https://fhir.hl7.org.uk/StructureDefinition/Extension-UKCore-VaccinationProcedure')]"
             + ".valueCodeableConcept.coding[?(@.system=='http://snomed.info/sct')].code"
@@ -160,10 +172,12 @@ def test_post_patient_identifier_value(self):
         Test that the JSON data is accepted when it does not contain patient_identifier_value
         """
         field_location = "contained[?(@.resourceType=='Patient')].identifier[0].value"
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_field_accepted(self, field_location)
 
     def test_post_patient_name_given(self):
         """Test that the JSON data is rejected if it does not contain patient_name_given"""
+        self.mock_redis_client.hget.return_value = "RSV"
         valid_json_data = deepcopy(self.completed_json_data["RSV"])
         patient_name_given_field_location = "contained[?(@.resourceType=='Patient')].name[0].given"
         expected_error_message = f"Validation errors: {patient_name_given_field_location} is a mandatory field"
@@ -206,6 +220,7 @@ def test_post_patient_name_given(self):
     def test_post_patient_name_family(self):
         """Test that the JSON data is rejected if it does not contain patient_name_family"""
         valid_json_data = deepcopy(self.completed_json_data["RSV"])
+        self.mock_redis_client.hget.return_value = "COVID19"
         patient_name_family_field_location = "contained[?(@.resourceType=='Patient')].name[0].family"
         expected_error_message = f"{patient_name_family_field_location} is a mandatory field"
 
@@ -236,14 +251,17 @@ def test_post_patient_name_family(self):
 
     def test_post_patient_birth_date(self):
         """Test that the JSON data is rejected if it does not contain patient_birth_date"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "contained[?(@.resourceType=='Patient')].birthDate")
 
     def test_post_patient_gender(self):
         """Test that the JSON data is rejected if it does not contain patient_gender"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "contained[?(@.resourceType=='Patient')].gender")
 
     def test_post_patient_address_postal_code(self):
         """Test that the JSON data is rejected if it does not contain patient_address_postal_code"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         field_location = "contained[?(@.resourceType=='Patient')].address[0].postalCode"
         MandationTests.test_missing_mandatory_field_rejected(self, field_location)
 
@@ -260,20 +278,24 @@ def test_post_occurrence_date_time(self):
 
     def test_post_organization_identifier_value(self):
         """Test that the JSON data is rejected if it does not contain organization_identifier_value"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(
             self, "performer[?(@.actor.type=='Organization')].actor.identifier.value"
         )
 
     def test_post_identifer_value(self):
         """Test that the JSON data is rejected if it does not contain identifier_value"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "identifier[0].value")
 
     def test_post_identifer_system(self):
         """Test that the JSON data is rejected if it does not contain identifier_system"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "identifier[0].system")
 
     def test_post_practitioner_name_given(self):
         """Test that the JSON data is rejected if it does not contain practitioner_name_given"""
+        self.mock_redis_client.hget.return_value = "RSV"
         valid_json_data = deepcopy(self.completed_json_data["RSV"])
         practitioner_name_given_field_location = "contained[?(@.resourceType=='Practitioner')].name[0].given"
 
@@ -297,6 +319,7 @@ def test_post_practitioner_name_given(self):
 
     def test_post_practitioner_name_family(self):
         """Test that the JSON data is rejected if it does not contain practitioner_name_family"""
+        self.mock_redis_client.hget.return_value = "RSV"
         valid_json_data = deepcopy(self.completed_json_data["RSV"])
         practitioner_name_family_field_location = "contained[?(@.resourceType=='Practitioner')].name[0].family"
 
@@ -320,10 +343,12 @@ def test_post_practitioner_name_family(self):
 
     def test_post_recorded(self):
         """Test that the JSON data is rejected if it does not contain recorded"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "recorded")
 
     def test_post_primary_source(self):
         """Test that the JSON data is rejected if it does not contain primary_source"""
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(self, "primarySource")
 
     # TODO: To confirm with imms if dose number string validation is correct (current working assumption is yes)
@@ -365,6 +390,8 @@ def test_post_dose_number_positive_int(self):
 
             # dose_number_positive_int exists, dose_number_string does not exist
             valid_json_data = deepcopy(self.completed_json_data[vaccine_type])
+            self.mock_redis_client.hget.side_effect = None
+            self.mock_redis_client.hget.return_value = 'COVID19'
             MandationTests.test_present_field_accepted(self, valid_json_data)
 
             # dose_number_positive_int does not exist, dose_number_string exists
@@ -390,12 +417,15 @@ def test_post_manufacturer_display(self):
         Test that present or absent manufacturer_display is accepted or rejected
         as appropriate dependent on other fields
         """
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.hget.return_value = "COVID19"
         field_location = "manufacturer.display"
         for vaccine_type in self.all_vaccine_types:
             MandationTests.test_missing_field_accepted(self, field_location, self.completed_json_data[vaccine_type])
 
     def test_post_lot_number(self):
         """Test that present or absent lot_number is accepted or rejected as appropriate dependent on other fields"""
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "lotNumber"
         for vaccine_type in self.all_vaccine_types:
             MandationTests.test_missing_field_accepted(self, field_location, self.completed_json_data[vaccine_type])
@@ -405,6 +435,7 @@ def test_post_expiration_date(self):
         Test that present or absent expiration_date is accepted or rejected
         as appropriate dependent on other fields
         """
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "expirationDate"
         for vaccine_type in self.all_vaccine_types:
             MandationTests.test_missing_field_accepted(self, field_location, self.completed_json_data[vaccine_type])
@@ -442,6 +473,7 @@ def test_post_dose_quantity_value(self):
         """
         Test that present or absent dose_quantity_value is accepted or rejected as appropriate dependent on other fields
         """
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "doseQuantity.value"
         for vaccine_type in self.all_vaccine_types:
             MandationTests.test_missing_field_accepted(self, field_location, self.completed_json_data[vaccine_type])
@@ -450,12 +482,15 @@ def test_post_dose_quantity_code(self):
         """
         Test that present or absent dose_quantity_code is accepted or rejected as appropriate dependent on other fields
         """
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "doseQuantity.code"
         for vaccine_type in self.all_vaccine_types:
             MandationTests.test_missing_field_accepted(self, field_location, self.completed_json_data[vaccine_type])
 
     def test_post_dose_quantity_unit(self):
         """Test that the JSON data is accepted when dose_quantity_unit is absent"""
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.hget.return_value = 'COVID19'
         MandationTests.test_missing_field_accepted(self, "doseQuantity.unit")
 
     # NOTE: THIS TEST IS COMMENTED OUT AS IT IS TESTING A REQUIRED ELEMENT (VALIDATION SHOULD ALWAYS PASS),
@@ -467,6 +502,8 @@ def test_post_dose_quantity_unit(self):
 
     def test_post_organization_identifier_system(self):
         """Test that the JSON data is rejected if it does not contain organization_identifier_system"""
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.hget.return_value = "COVID19"
         MandationTests.test_missing_mandatory_field_rejected(
             self, "performer[?(@.actor.type=='Organization')].actor.identifier.system"
         )
@@ -479,8 +516,8 @@ def test_post_pre_validate_extension_url(self):
         and get passed only with the snomed url.
         """
         # Test case: missing "extension"
-        self.mock_redis_client.hget.return_value = MOCK_REDIS_D2V_RESPONSE
-
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.hget.return_value = "COVID19"
         invalid_json_data = deepcopy(self.completed_json_data["COVID19"])
         invalid_json_data["extension"][0]["valueCodeableConcept"]["coding"][0]["system"]='https://xyz/Extension-UKCore-VaccinationProcedure'
 
@@ -496,6 +533,7 @@ def test_post_location_identifier_value(self):
         Test that the JSON data is rejected if it does and does not contain
         location_identifier_value as appropriate
         """
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "location.identifier.value"
         # Test cases for COVID-19, FLU, HPV and MMR where it is mandatory
         for vaccine_type in (
@@ -512,6 +550,7 @@ def test_post_location_identifier_system(self):
         """
         Test that the JSON data is rejected if it does and does not contain location_identifier_system as appropriate
         """
+        self.mock_redis_client.hget.side_effect = ['COVID19', 'FLU', 'HPV', 'MMR', 'RSV']
         field_location = "location.identifier.system"
         # Test cases for COVID-19, FLU, HPV and MMR where it is mandatory
         for vaccine_type in (
@@ -526,6 +565,8 @@ def test_post_location_identifier_system(self):
 
     def test_post_no_snomed_code(self):
         """test that only snomed system is accepted"""
+        self.mock_redis_client.hget.side_effect = None
+        self.mock_redis_client.return_value = "COVID19"
         covid_19_json_data = deepcopy(self.completed_json_data["COVID19"])
 
         invalid_target_disease_value = [

backend/tests/utils/mock_redis.py

@@ -25,9 +25,39 @@
     "FLU": "[{\"code\": \"6142004\", \"term\": \"Influenza caused by seasonal influenza virus (disorder)\"}]",
     "MENACWY": "[{\"code\": \"23511006\", \"term\": \"Meningococcal infectious disease\"}]"
 }
+last = None
+def get_data(name):
+    # extract name of calling unit test and print to console
+    import inspect
+    # static variable to keep track of last printed message
+    global last
+    # get the name of the calling unit test
+    # this is useful for debugging and understanding which test is calling this mock
+    # function, especially when multiple tests are using the same mock
+    test_name = None
+    for frame_info in inspect.stack():
+        if frame_info.function.startswith("test_"):
+            test_name = frame_info.function
+            # Optionally, get the class name if available
+            test_self = frame_info.frame.f_locals.get("self", None)
+            msg = ''
+            if test_self:
+                test_class = type(test_self).__name__
+                msg = f"Mocking redis call for: {test_class} - {test_name}"
+            else:
+                msg = f"Mocking redis call for: {test_name}"
 
+            if msg != last:
+                print(msg)
+                last = msg
 
-def get_data(name):
+            break
+    else:
+        print("Mocking redis call: test function not found in stack.")
+
+    
+    
+    
     if name == "diseases_to_vacc":
         return MOCK_REDIS_D2V_RESPONSE
     elif name == "vacc_to_diseases":
@@ -37,7 +67,10 @@ def get_data(name):
 def mock_redis_hget(name, key):
     ret = get_data(name)
     if key in ret:
+        print(f"Mocking redis hget({name},{key}): {ret[key]}")
         return ret[key]
+    
+    print(f"Mocking redis hget({name},{key}): None")
     return {}
 
 def mock_redis_hkeys(name):