cleanup

Author: JamesW1-NHS

lambdas/recordprocessor/src/audit_table.py

@@ -67,21 +67,21 @@ def set_audit_table_ingestion_started(
     expression_attr_values = {f":{AuditTableKeys.INGESTION_STARTED}": {"S": ingestion_started}}
 
     try:
-        # Update the status in the audit table to "Processed"
-        dynamodb_client.update_item(
+        response = dynamodb_client.update_item(
             TableName=AUDIT_TABLE_NAME,
             Key={AuditTableKeys.MESSAGE_ID: {"S": message_id}},
             UpdateExpression=update_expression,
             ExpressionAttributeNames=expression_attr_names,
             ExpressionAttributeValues=expression_attr_values,
             ConditionExpression=f"attribute_exists({AuditTableKeys.MESSAGE_ID})",
+            ReturnValues="UPDATED_NEW",
         )
-
+        result = response.get("Attributes", {}).get(AuditTableKeys.INGESTION_STARTED).get("S")
         logger.info(
             "ingestion_started for %s file, with message id %s, was successfully updated to %s in the audit table",
             file_key,
             message_id,
-            ingestion_started,
+            result,
         )
 
     except Exception as error:  # pylint: disable = broad-exception-caught

lambdas/recordprocessor/tests/test_audit_table.py

@@ -129,8 +129,6 @@ def test_update_audit_table_status_throws_exception_with_invalid_id(self):
 
     def test_set_audit_table_ingestion_started(self):
         """Checks audit table correctly sets ingestion_started to the requested value"""
-        # Test case 1: file should be updated with status of 'Processed'.
-
         add_entry_to_table(MockFileDetails.rsv_ravs, file_status=FileStatus.PROCESSING)
 
         ravs_rsv_test_file = FileDetails("RSV", "RAVS", "X26")