unit tests

Author: JamesW1-NHS

ack_backend/tests/utils/values_for_ack_backend_tests.py

@@ -7,12 +7,18 @@
 class DefaultValues:
     """Class to hold default values for tests"""
 
+    fixed_datetime = datetime(2024, 10, 29, 12, 0, 0)
+    fixed_datetime_str = fixed_datetime.strftime("%Y-%m-%d %H:%M:%S")
+
     message_id = "test_file_id"
     row_id = "test_file_id#1"
     local_id = "test_system_uri^testabc"
     imms_id = "test_imms_id"
     operation_requested = "CREATE"
     created_at_formatted_string = "20211120T12000000"
+    batch_start_time = fixed_datetime_str
+    operation_start_time = fixed_datetime_str
+    operation_end_time = fixed_datetime_str
 
 
 class DiagnosticsDictionaries:
@@ -90,6 +96,9 @@ def __init__(
         local_id: str = DefaultValues.local_id,
         imms_id: str = DefaultValues.imms_id,
         created_at_formatted_string: str = DefaultValues.created_at_formatted_string,
+        batch_start_time: str = DefaultValues.batch_start_time,
+        operation_start_time: str = DefaultValues.operation_start_time,
+        operation_end_time: str = DefaultValues.operation_end_time,
     ):
         self.name = f"{vaccine_type.upper()}/ {supplier.upper()} {operation_requested} message"
         self.file_key = f"{vaccine_type}_Vaccinations_v5_{ods_code}_20210730T12000000.csv"
@@ -108,6 +117,9 @@ def __init__(
         self.local_id = local_id
         self.imms_id = imms_id
         self.created_at_formatted_string = created_at_formatted_string
+        self.batch_start_time= batch_start_time
+        self.operation_start_time = operation_start_time
+        self.operation_end_time = operation_end_time
 
         self.queue_name = f"{supplier}_{vaccine_type}"
 
@@ -116,6 +128,9 @@ def __init__(
             "supplier": self.supplier,
             "vaccine_type": self.vaccine_type,
             "created_at_formatted_string": self.created_at_formatted_string,
+            "batch_start_time": self.batch_start_time,
+            "operation_start_time": self.operation_start_time,
+            "operation_end_time": self.operation_end_time,
             "row_id": self.row_id,
             "local_id": self.local_id,
             "operation_requested": self.operation_requested,
@@ -151,6 +166,9 @@ class ValidValues:
     mock_message_expected_log_value = {
         "function_name": "ack_processor_convert_message_to_ack_row",
         "date_time": fixed_datetime.strftime("%Y-%m-%d %H:%M:%S"),
+        "batch_start_time": MOCK_MESSAGE_DETAILS.batch_start_time,
+        "operation_start_time": MOCK_MESSAGE_DETAILS.operation_start_time,
+        "operation_end_time": MOCK_MESSAGE_DETAILS.operation_end_time,
         "status": "success",
         "supplier": MOCK_MESSAGE_DETAILS.supplier,
         "file_key": MOCK_MESSAGE_DETAILS.file_key,
@@ -242,6 +260,9 @@ class InvalidValues:
     Logging_with_no_values = {
         "function_name": "ack_processor_convert_message_to_ack_row",
         "date_time": fixed_datetime.strftime("%Y-%m-%d %H:%M:%S"),
+        "batch_start_time": "unknown",
+        "operation_start_time": "unknown",
+        "operation_end_time": "unknown",
         "status": "fail",
         "supplier": "unknown",
         "file_key": "file_key_missing",

backend/tests/test_forwarding_batch_lambda.py

@@ -455,6 +455,9 @@ def test_forward_lambda_handler_groups_and_sends_events_by_filename(self, mock_s
         self.assertDictEqual(json.loads(first_call_kwargs["MessageBody"])[0], {
             "created_at_formatted_string": "2025-01-24T12:00:00Z",
             "file_key": "supplier_1_rsv_test_file",
+            "batch_start_time": ANY,
+            "operation_start_time": ANY,
+            "operation_end_time": ANY,
             "imms_id": ANY,
             "local_id": "local-1",
             "operation_requested": "CREATE",
@@ -465,6 +468,9 @@ def test_forward_lambda_handler_groups_and_sends_events_by_filename(self, mock_s
         self.assertDictEqual(json.loads(second_call_kwargs["MessageBody"])[0], {
             "created_at_formatted_string": "2025-01-24T12:00:00Z",
             "file_key": "supplier_2_rsv_test_file",
+            "batch_start_time": ANY,
+            "operation_start_time": ANY,
+            "operation_end_time": ANY,
             "imms_id": ANY,
             "local_id": "local-2",
             "operation_requested": "CREATE",