VED-457: improve coverage for services and repository

Author: Akol125

backend/tests/test_fhir_controller.py

@@ -1518,6 +1518,34 @@ def test_update_immunization_missing_id(self):
         }
         with self.assertRaises(KeyError):
             self.controller.update_immunization(aws_event)
+    
+    @patch("fhir_controller.get_supplier_permissions")
+    def test_update_reinstated_immunization_with_diagnostics_error(self, mock_get_permissions):
+        """it should return 400 if patient validation error is present"""
+        mock_get_permissions.return_value = ["COVID19.CRUD"]
+        imms_id = "valid-id"
+        imms = '{"id": "valid-id"}'
+        aws_event = {
+            "headers": {"E-Tag": 1, "SupplierSystem": "Test"},
+            "body": imms,
+            "pathParameters": {"id": imms_id},
+        }
+        # Simulate reinstated record
+        self.service.get_immunization_by_id_all.return_value = {
+            "resource": "existing",
+            "Version": 1,
+            "DeletedAt": True,
+            "Reinstated": False,
+            "VaccineType": "COVID19",
+        }
+        self.service.reinstate_immunization.return_value = (None, {
+            "diagnostics": "Patient NHS number has been superseded"
+        }, None)
+
+        response = self.controller.update_immunization(aws_event)
+
+        self.assertEqual(response["statusCode"], 400)
+        self.assertIn("superseded", json.loads(response["body"])["issue"][0]["diagnostics"])
 
 
 class TestDeleteImmunization(unittest.TestCase):

backend/tests/test_fhir_repository.py

@@ -476,6 +476,50 @@ def test_update_throws_error_when_identifier_already_in_dynamodb(self):
             self.repository.update_immunization(imms_id, imms, self.patient, 1, ["COVID19.CRUD"], "Test")
 
         self.assertEqual(str(e.exception), f"The provided identifier: {identifier} is duplicated")
+    
+    def test_reinstate_immunization_success(self):
+        """it should reinstate an immunization successfully"""
+        self.mock_redis_client.hget.return_value = "COVID19"
+        imms_id = "reinstate-id"
+        imms = create_covid_19_immunization_dict(imms_id)
+        imms["patient"] = self.patient
+        resource = {"reinstate": "ok"}
+        self.table.query.return_value = {}
+
+        self.table.update_item.return_value = {
+            "ResponseMetadata": {"HTTPStatusCode": 200},
+            "Attributes": {"Resource": json.dumps(resource)},
+        }
+
+        with patch("time.time", return_value=123456):
+            result, version = self.repository.reinstate_immunization(
+                imms_id, imms, self.patient, 1, ["COVID19.CRUD"], "Test"
+            )
+
+        self.assertEqual(result, resource)
+        self.assertEqual(version, 2)
+    
+    def test_update_reinstated_immunization_success(self):
+        """it should update a reinstated immunization successfully"""
+        self.mock_redis_client.hget.return_value = "COVID19"
+        imms_id = "reinstated-id"
+        imms = create_covid_19_immunization_dict(imms_id)
+        imms["patient"] = self.patient
+        resource = {"reinstated": "ok"}
+        self.table.query.return_value = {}
+
+        self.table.update_item.return_value = {
+            "ResponseMetadata": {"HTTPStatusCode": 200},
+            "Attributes": {"Resource": json.dumps(resource)},
+        }
+
+        with patch("time.time", return_value=123456):
+            result, version = self.repository.update_reinstated_immunization(
+                imms_id, imms, self.patient, 1, ["COVID19.CRUD"], "Test"
+            )
+
+        self.assertEqual(result, resource)
+        self.assertEqual(version, 2)
 
 
 class TestDeleteImmunization(unittest.TestCase):

backend/tests/test_fhir_service.py

@@ -3,6 +3,7 @@
 import uuid
 import datetime
 import unittest
+from unittest.mock import MagicMock
 from copy import deepcopy
 from unittest.mock import create_autospec, patch
 from unittest import skip
@@ -538,6 +539,64 @@ def test_patient_error(self):
         # Then
         self.assertEqual(e.exception.patient_identifier, invalid_nhs_number)
         self.imms_repo.update_immunization.assert_not_called()
+    
+    def test_reinstate_immunization_returns_updated_version(self):
+        """it should return updated version from reinstate"""
+        imms_id = "an-id"
+        req_imms = create_covid_19_immunization_dict(imms_id)
+        self.fhir_service._validate_patient = MagicMock(return_value={})
+        self.imms_repo.reinstate_immunization.return_value = (req_imms, 5)
+
+        outcome, resource, version = self.fhir_service.reinstate_immunization(
+            imms_id, req_imms, 1, ["COVID19:CRUD"], "Test"
+        )
+
+        self.assertEqual(outcome, UpdateOutcome.UPDATE)
+        self.assertEqual(version, 5)
+
+    def test_update_reinstated_immunization_returns_updated_version(self):
+        """it should return updated version from update_reinstated"""
+        imms_id = "an-id"
+        req_imms = create_covid_19_immunization_dict(imms_id)
+        self.fhir_service._validate_patient = MagicMock(return_value={})
+        self.imms_repo.update_reinstated_immunization.return_value = (req_imms, 9)
+
+        outcome, resource, version = self.fhir_service.update_reinstated_immunization(
+            imms_id, req_imms, 1, ["COVID19:CRUD"], "Test"
+        )
+
+        self.assertEqual(outcome, UpdateOutcome.UPDATE)
+        self.assertEqual(version, 9)
+
+    def test_reinstate_immunization_with_diagnostics(self):
+        """it should return error if patient has diagnostics in reinstate"""
+        imms_id = "an-id"
+        req_imms = create_covid_19_immunization_dict(imms_id)
+        self.fhir_service._validate_patient = MagicMock(return_value={"diagnostics": "invalid patient"})
+
+        outcome, resource, version = self.fhir_service.reinstate_immunization(
+            imms_id, req_imms, 1, ["COVID19:CRUD"], "Test"
+        )
+
+        self.assertIsNone(outcome)
+        self.assertEqual(resource, {"diagnostics": "invalid patient"})
+        self.assertIsNone(version)
+        self.imms_repo.reinstate_immunization.assert_not_called()
+
+    def test_update_reinstated_immunization_with_diagnostics(self):
+        """it should return error if patient has diagnostics in update_reinstated"""
+        imms_id = "an-id"
+        req_imms = create_covid_19_immunization_dict(imms_id)
+        self.fhir_service._validate_patient = MagicMock(return_value={"diagnostics": "invalid patient"})
+
+        outcome, resource, version = self.fhir_service.update_reinstated_immunization(
+            imms_id, req_imms, 1, ["COVID19:CRUD"], "Test"
+        )
+
+        self.assertIsNone(outcome)
+        self.assertEqual(resource, {"diagnostics": "invalid patient"})
+        self.assertIsNone(version)
+        self.imms_repo.update_reinstated_immunization.assert_not_called()
 
 
 class TestDeleteImmunization(unittest.TestCase):