resolve log issues

Author: Akol125

lambdas/id_sync/src/id_sync.py

@@ -24,11 +24,24 @@ def handler(event_data: Dict[str, Any], _context) -> Dict[str, Any]:
 
         logger.info("id_sync processing event with %d records", len(records))
 
-        results = [process_record(record) for record in records]
-        nhs_numbers = [result["nhs_number"] for result in results]
-        error_count = sum(1 for result in results if result.get("status") == "error")
+        # Use explicit loops instead of list comprehensions so we can more
+        # easily inspect intermediate results and avoid building temporary
+        # comprehension constructs.
+        results = []
+        nhs_numbers = []
+        error_count = 0
 
-        if error_count:
+        for record in records:
+            result = process_record(record)
+            results.append(result)
+
+            if "nhs_number" in result:
+                nhs_numbers.append(result["nhs_number"])
+
+            if result.get("status") == "error":
+                error_count += 1
+
+        if error_count > 0:
             raise IdSyncException(message=f"Processed {len(records)} records with {error_count} errors",
                                   nhs_numbers=nhs_numbers)
 

lambdas/id_sync/tests/test_id_sync.py

@@ -235,29 +235,30 @@ def test_handler_process_record_exception(self):
         self.assertEqual(exception.message, "Error processing id_sync event")
 
     def test_handler_process_record_missing_nhs_number(self):
-        """Test handler when process_record returns incomplete data"""
+        """Test handler when process_record returns error and missing NHS number"""
+
         # Setup mocks
         mock_event = MagicMock()
         mock_event.records = [MagicMock()]
         self.mock_aws_lambda_event.return_value = mock_event
 
-        # Missing "nhs_number" in response
+        # Return result without 'nhs_number' but with an 'error' status
         self.mock_process_record.return_value = {
-            "status": "success"
-            # Missing "nhs_number"
+            "status": "error",
+            "message": "Missing NHS number"
+            # No 'nhs_number'
         }
 
-        # Call handler
+        # Call handler and expect exception
         with self.assertRaises(IdSyncException) as exception_context:
             handler(self.single_sqs_event, None)
 
         exception = exception_context.exception
 
-        # convert exception payload to json
         self.assertIsInstance(exception, IdSyncException)
-        self.assertEqual(exception.nhs_numbers, None)
-        self.assertEqual(exception.message, "Error processing id_sync event")
-        self.mock_logger.exception.assert_called_once_with("Error processing id_sync event")
+        self.assertEqual(exception.nhs_numbers, [])  # Since no nhs_number was collected
+        self.assertEqual(exception.message, "Processed 1 records with 1 errors")
+        self.mock_logger.exception.assert_called_once_with(f"id_sync error: {exception.message}")
 
     def test_handler_context_parameter_ignored(self):
         """Test that context parameter is properly ignored"""