TODO Code

Author: nhsdevws

lambdas/id_sync/src/record_processor.py

@@ -6,7 +6,7 @@
 from pds_details import get_pds_patient_details
 import json
 from typing import Optional
-# sonarcloud: disable=S2589
+from to_do_code import check_records_exist, update_patient_index
 
 
 def process_record(event_record: AwsLambdaSqsEventRecord):
@@ -37,19 +37,6 @@ def process_record(event_record: AwsLambdaSqsEventRecord):
     else:
         return {"status": "error", "message": "No ID found in event record"}
 
-
-def check_records_exist(id: str) -> bool:
-    # TODO: Implement logic to check if records exist in the database
-    logger.info(f"TODO Check if records exist for {id}")
-    return True
-
-
-def update_patient_index(old_id: str, new_id: str):
-    # TODO: Implement logic to update patient index in Redis or other data store
-    logger.info(f"TODO Update patient index from {old_id} to {new_id}")
-    return {"status": "success", "message": f"Updated patient idx from {old_id} to {new_id}", "TODO": "Implement logic"}
-
-
 def get_id(event_body) -> Optional[str]:
     """Extract subject identifier from FHIR Bundle notification event"""
     try:

lambdas/id_sync/src/to_do_code.py

@@ -0,0 +1,13 @@
+'''
+    record Processor
+'''
+
+
+def check_records_exist(id: str) -> bool:
+    # TODO: Implement logic to check if records exist in the database
+    return True
+
+
+def update_patient_index(old_id: str, new_id: str):
+    # TODO: Implement logic to update patient index in Redis or other data store
+    return {"status": "success", "message": f"Updated patient idx from {old_id} to {new_id}", "TODO": "Implement logic"}

lambdas/id_sync/tests/test_record_processor.py

@@ -211,7 +211,6 @@ def test_update_patient_index_success(self):
             "TODO": "Implement logic"
         }
         self.assertEqual(result, expected_result)
-        self.mock_logger.info.assert_called_once_with(f"TODO Update patient index from {old_id} to {new_id}")
 
     def test_update_patient_index_with_empty_strings(self):
         """Test update with empty string IDs"""

sonar-project.properties

@@ -4,7 +4,7 @@ sonar.organization=nhsdigital
 sonar.host.url=https://sonarcloud.io
 sonar.python.version=3.11
 sonar.cpd.exclusions=redis_sync/src/log_decorator.py,lambdas/shared/**,**/Dockerfile
-sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**
+sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**/**/to_do_code.py,**/tests/**/**/record_processor.py,**/tests/**/**/ack_lambda.py,**/tests/**/**/filenameprocessor.py,**/tests/**/**/recordforwarder.py,**/tests/**/**/mesh_processor.py,**/tests/**/**/redis_sync.py,**/tests/**/**/id_sync.py,**/tests/**/**/shared.py
 sonar.python.coverage.reportPaths=backend-coverage.xml,delta-coverage.xml,ack-lambda-coverage.xml,filenameprocessor-coverage.xml,recordforwarder-coverage.xml,recordprocessor-coverage.xml,mesh_processor-coverage.xml,redis_sync-coverage.xml,id_sync-coverage.xml,shared-coverage.xml
 sonar.issue.ignore.multicriteria=exclude_snomed_urls,exclude_hl7_urls
 sonar.issue.ignore.multicriteria.exclude_snomed_urls.ruleKey=python:S5332