|
| 1 | +import unittest |
| 2 | + |
| 3 | +from common.validator.expression_checker import ExpressionChecker |
| 4 | +from common.validator.record_error import ErrorReport |
| 5 | + |
| 6 | + |
| 7 | +class DummyParser: |
| 8 | + def __init__(self, data=None, raise_on_get=False): |
| 9 | + self._data = data or {} |
| 10 | + self._raise = raise_on_get |
| 11 | + |
| 12 | + def get_key_value(self, field_name): |
| 13 | + if self._raise: |
| 14 | + raise RuntimeError("boom") |
| 15 | + return [self._data.get(field_name, "")] |
| 16 | + |
| 17 | + |
| 18 | +class StubLookup: |
| 19 | + def __init__(self, raise_on_call=False): |
| 20 | + self.raise_on_call = raise_on_call |
| 21 | + |
| 22 | + def find_lookup(self, value): |
| 23 | + if self.raise_on_call: |
| 24 | + raise RuntimeError("boom") |
| 25 | + return "" # force error path |
| 26 | + |
| 27 | + |
| 28 | +class StubKeyData: |
| 29 | + def __init__(self, raise_on_call=False): |
| 30 | + self.raise_on_call = raise_on_call |
| 31 | + |
| 32 | + def findKey(self, key_source, field_value): |
| 33 | + if self.raise_on_call: |
| 34 | + raise RuntimeError("boom") |
| 35 | + return False # force error path |
| 36 | + |
| 37 | + |
| 38 | +class TestExpressionCheckerExceptions(unittest.TestCase): |
| 39 | + def make_checker(self, data=None, report=True, raise_on_get=False): |
| 40 | + return ExpressionChecker(DummyParser(data, raise_on_get), False, report) |
| 41 | + |
| 42 | + def test_regex_unexpected_true_false(self): |
| 43 | + # expression_rule None causes re.search to raise |
| 44 | + ec = self.make_checker(report=True) |
| 45 | + self.assertIsInstance(ec.validate_expression("REGEX", None, "r", "abc", 1), ErrorReport) |
| 46 | + ec2 = self.make_checker(report=False) |
| 47 | + self.assertIsNone(ec2.validate_expression("REGEX", None, "r", "abc", 1)) |
| 48 | + |
| 49 | + def test_in_unexpected_true_false(self): |
| 50 | + ec = self.make_checker(report=True) |
| 51 | + self.assertIsInstance(ec.validate_expression("IN", "ab", "f", None, 1), ErrorReport) |
| 52 | + ec2 = self.make_checker(report=False) |
| 53 | + self.assertIsNone(ec2.validate_expression("IN", "ab", "f", None, 1)) |
| 54 | + |
| 55 | + def test_length_unexpected_true_false(self): |
| 56 | + ec = self.make_checker(report=True) |
| 57 | + self.assertIsInstance(ec.validate_expression("LENGTH", "x", "s", "abcd", 1), ErrorReport) |
| 58 | + ec2 = self.make_checker(report=False) |
| 59 | + self.assertIsNone(ec2.validate_expression("LENGTH", "x", "s", "abcd", 1)) |
| 60 | + |
| 61 | + def test_float_unexpected_true_false(self): |
| 62 | + ec = self.make_checker(report=True) |
| 63 | + self.assertIsInstance(ec.validate_expression("FLOAT", None, "f", "abc", 1), ErrorReport) |
| 64 | + ec2 = self.make_checker(report=False) |
| 65 | + self.assertIsNone(ec2.validate_expression("FLOAT", None, "f", "abc", 1)) |
| 66 | + |
| 67 | + def test_uuid_unexpected_true_false(self): |
| 68 | + ec = self.make_checker(report=True) |
| 69 | + self.assertIsInstance(ec.validate_expression("UUID", None, "u", "not-a-uuid", 1), ErrorReport) |
| 70 | + ec2 = self.make_checker(report=False) |
| 71 | + self.assertIsNone(ec2.validate_expression("UUID", None, "u", "not-a-uuid", 1)) |
| 72 | + |
| 73 | + def test_maxobjects_unexpected_true_false(self): |
| 74 | + class NoLen: |
| 75 | + pass |
| 76 | + |
| 77 | + ec = self.make_checker(report=True) |
| 78 | + self.assertIsInstance(ec.validate_expression("MAXOBJECTS", "1", "m", NoLen(), 1), ErrorReport) |
| 79 | + ec2 = self.make_checker(report=False) |
| 80 | + self.assertIsNone(ec2.validate_expression("MAXOBJECTS", "1", "m", NoLen(), 1)) |
| 81 | + |
| 82 | + def test_onlyif_unexpected_true_false(self): |
| 83 | + ec = self.make_checker(report=True, raise_on_get=True) |
| 84 | + self.assertIsInstance(ec.validate_expression("ONLYIF", "loc|VAL", "f", "x", 1), ErrorReport) |
| 85 | + ec2 = self.make_checker(report=False, raise_on_get=True) |
| 86 | + self.assertIsNone(ec2.validate_expression("ONLYIF", "loc|VAL", "f", "x", 1)) |
| 87 | + |
| 88 | + def test_lookup_unexpected_true_false(self): |
| 89 | + ec = self.make_checker(report=True) |
| 90 | + ec.data_look_up = StubLookup(raise_on_call=True) |
| 91 | + self.assertIsInstance(ec.validate_expression("LOOKUP", None, "l", "x", 1), ErrorReport) |
| 92 | + ec2 = self.make_checker(report=False) |
| 93 | + ec2.data_look_up = StubLookup(raise_on_call=True) |
| 94 | + self.assertIsNone(ec2.validate_expression("LOOKUP", None, "l", "x", 1)) |
| 95 | + |
| 96 | + def test_keycheck_unexpected_true_false(self): |
| 97 | + ec = self.make_checker(report=True) |
| 98 | + ec.key_data = StubKeyData(raise_on_call=True) |
| 99 | + self.assertIsInstance(ec.validate_expression("KEYCHECK", "Site", "k", "val", 1), ErrorReport) |
| 100 | + ec2 = self.make_checker(report=False) |
| 101 | + ec2.key_data = StubKeyData(raise_on_call=True) |
| 102 | + self.assertIsNone(ec2.validate_expression("KEYCHECK", "Site", "k", "val", 1)) |
| 103 | + |
| 104 | + def test_date_alias_and_upper_lower_edges(self): |
| 105 | + ec = self.make_checker({"d": "2025-01-01"}) |
| 106 | + self.assertIsNone(ec.validate_expression("DATE", None, "d", "2025-01-01", 1)) |
| 107 | + # unexpected exceptions for .isupper/.islower/St/E |
| 108 | + ec2 = self.make_checker() |
| 109 | + self.assertIsInstance(ec2.validate_expression("UPPER", None, "u", None, 1), ErrorReport) |
| 110 | + self.assertIsInstance(ec2.validate_expression("LOWER", None, "l", None, 1), ErrorReport) |
| 111 | + self.assertIsInstance(ec2.validate_expression("STARTSWITH", "a", "s", None, 1), ErrorReport) |
| 112 | + self.assertIsInstance(ec2.validate_expression("ENDSWITH", "a", "e", None, 1), ErrorReport) |
| 113 | + |
| 114 | + def test_nrange_out_of_range(self): |
| 115 | + ec = self.make_checker() |
| 116 | + self.assertIsInstance(ec.validate_expression("NRANGE", "1,10", "n", "11", 1), ErrorReport) |
| 117 | + |
| 118 | + def test_postcode_valid_and_unexpected(self): |
| 119 | + ec = self.make_checker() |
| 120 | + self.assertIsNone(ec.validate_expression("POSTCODE", None, "p", "EC1A 1BB", 1)) |
| 121 | + self.assertIsInstance(ec.validate_expression("POSTCODE", None, "p", None, 1), ErrorReport) |
| 122 | + |
| 123 | + def test_nhsnumber_valid_and_unexpected(self): |
| 124 | + ec = self.make_checker() |
| 125 | + self.assertIsNone(ec.validate_expression("NHSNUMBER", None, "n", "61234567890", 1)) |
| 126 | + self.assertIsInstance(ec.validate_expression("NHSNUMBER", None, "n", None, 1), ErrorReport) |
| 127 | + |
| 128 | + def test_in_pass_fail(self): |
| 129 | + ec = self.make_checker() |
| 130 | + self.assertIsNone(ec.validate_expression("IN", "ab", "f", "zzabzz", 1)) |
| 131 | + self.assertIsInstance(ec.validate_expression("IN", "ab", "f", "zz", 1), ErrorReport) |
| 132 | + |
| 133 | + |
| 134 | +if __name__ == "__main__": |
| 135 | + unittest.main() |
0 commit comments