VED-81 NHS number change notification Lambda (#653)

* lambda, terraform, lambda & shared folder

Author: nhsdevws

.github/dependabot.yml

@@ -58,6 +58,8 @@ updates:
       - "/mesh_processor"
       - "/recordprocessor"
       - "/redis_sync"
+      - "/lambdas/id_sync"
+      - "/lambdas/shared"
     schedule:
       interval: "daily"
     open-pull-requests-limit: 1

.github/workflows/sonarcloud.yml

@@ -7,6 +7,10 @@ on:
   pull_request:
     types: [labeled, opened, synchronize, reopened, unlabeled]
 
+env:
+  SHARED_PATH: ${{ github.workspace }}/lambdas/shared
+  LAMBDA_PATH: ${{ github.workspace }}/lambdas
+
 jobs:
   sonarcloud:
     name: SonarCloud
@@ -126,6 +130,30 @@ jobs:
             poetry run coverage run -m unittest discover || echo "redis_sync tests failed" >> ../failed_tests.txt
             poetry run coverage xml -o ../redis_sync-coverage.xml
 
+      - name: Run unittest with shared
+        working-directory: lambdas/shared
+        id: shared
+        env:
+          PYTHONPATH: ${{ env.SHARED_PATH }}/src
+        continue-on-error: true
+        run: |
+            poetry env use 3.11
+            poetry install
+            poetry run coverage run --rcfile=.coveragerc --source=src -m unittest discover -s tests -p "test_*.py" -v || echo "shared tests failed" >> ../../failed_tests.txt
+            poetry run coverage xml -o ../../shared-coverage.xml
+
+      - name: Run unittest with id_sync
+        working-directory: lambdas/id_sync
+        id: id_sync
+        env:
+          PYTHONPATH: ${{ env.LAMBDA_PATH }}/id_sync/src:${{ env.SHARED_PATH }}/src
+        continue-on-error: true
+        run: |
+            poetry env use 3.11
+            poetry install
+            poetry run coverage run --rcfile=.coveragerc --source=src -m unittest discover || echo "id_sync tests failed" >> ../../failed_tests.txt
+            poetry run coverage xml -o ../../id_sync-coverage.xml
+
       - name: Run Test Failure Summary
         id: check_failure
         run: |

.gitignore

@@ -29,4 +29,4 @@ openapi.json
 !**/.vscode/settings.json.default
 
 devtools/volume/
-backend/tests/.coverage
+**/.coverage

Makefile

@@ -1,6 +1,6 @@
 SHELL=/usr/bin/env bash -euo pipefail
 
-PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS = ack_backend backend delta_backend filenameprocessor mesh_processor recordprocessor redis_sync mns_subscription
+PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS = ack_backend backend delta_backend filenameprocessor mesh_processor recordprocessor redis_sync lambdas/id_sync lambdas/shared mns_subscription
 PYTHON_PROJECT_DIRS = e2e e2e_batch $(PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS)
 
 #Installs dependencies using poetry.
@@ -41,7 +41,7 @@ build-proxy:
 	scripts/build_proxy.sh
 
 #Files to loop over in release
-_dist_include="pytest.ini poetry.lock poetry.toml pyproject.toml Makefile build/. specification sandbox terraform scripts $(PYTHON_PROJECT_DIRS)"
+_dist_include="pytest.ini poetry.lock poetry.toml pyproject.toml Makefile build/. specification sandbox terraform scripts $(PYTHON_PROJECT_DIRS) $(PYTHON_LAMBDA_DEPENDENCIES)"
 
 
 #Create /dist/ sub-directory and copy files into directory

README.md

@@ -24,6 +24,8 @@ See https://nhsd-confluence.digital.nhs.uk/display/APM/Glossary.
 | `mesh_processor`    | **Imms Batch** – MESH-specific batch processing functionality. |
 | `recordprocessor`   | **Imms Batch** – Handles batch record processing. |
 | `redis_sync`        | **Imms Redis** – Handles sync s3 to REDIS. |
+| `id_sync`           | **Imms Redis** – Handles sync SQS to IEDS. |
+| `shared`            | **Imms Redis** – Not a lambda but Shared Code for lambdas |
 ---
 
 ### Pipelines

azure/templates/deploy-stage.yml

@@ -16,7 +16,7 @@ parameters:
     default: ''
   - name: proxy_path
     type: string
-    default: 'internal-dev'    
+    default: 'internal-dev'
   - name: secret_file_ids
     type: object
     default: []
@@ -150,10 +150,9 @@ jobs:
               echo "##vso[task.setvariable variable=FULLY_QUALIFIED_SERVICE_NAME]${FULLY_QUALIFIED_SERVICE_NAME}"
             fi
           displayName: Override FULLY_QUALIFIED_SERVICE_NAME
-        
+
       - checkout: self
         path: "s/${{ parameters.service_name }}"
-        submodules: true
 
       - task: UsePythonVersion@0
         displayName: "Use Python ${{ parameters.python_version }}"
@@ -174,4 +173,4 @@ jobs:
           parameters:
             state: failure
             on_failure: true
-            description: "Deploy failed"
+            description: "Deploy failed"

immunisation-fhir-api.code-workspace

@@ -32,7 +32,13 @@
         },
 		{
             "path": "mns_subscription"
-        }
+        },
+		{
+			"path": "lambdas/id_sync"
+		},
+		{
+			"path": "lambdas/shared"
+		}
 	],
-	"settings": {},
+	"settings": {}
 }

lambdas/.coveragerc

@@ -0,0 +1,8 @@
+[report]
+omit =
+    shared/tests/*
+    shared/tests/*/*
+    shared/tests/*/*/*
+    id_sync/tests/*
+    id_sync/tests/*/*
+    id_sync/tests/*/*/*

lambdas/id_sync/.coveragerc

@@ -0,0 +1,14 @@
+[report]
+omit =
+    tests/*
+    tests/*/*
+    tests/*/*/*
+    tests/test_*.py
+    tests/*/test_*.py
+    tests/*/*/test_*.py
+    id_sync/tests/*
+    id_sync/tests/*/*
+    id_sync/tests/*/*/*
+    ../shared/tests/*
+    ../shared/tests/*/*
+    ../shared/tests/*/*/*

lambdas/id_sync/.vscode/settings.json.default

@@ -0,0 +1,27 @@
+{
+    "python.analysis.extraPaths": [
+        "./src"
+    ],
+    "python.testing.unittestArgs": [
+        "-v",
+        "-s",
+        "./",
+        "-p",
+        "test_*.py"
+    ],
+    "python.testing.pytestEnabled": false,
+    "python.testing.unittestEnabled": true,
+    "pylint.args": [
+        "--init-hook",
+        "import sys; sys.path.append('./src')"
+    ],
+    "[makefile]": {
+        "editor.insertSpaces": false,
+        "editor.detectIndentation": false
+    },
+    "files.trimTrailingWhitespace": true,
+    "[python]": {
+        "files.trimTrailingWhitespace": true
+    },
+    "files.insertFinalNewline": true
+}