get_items_to_update try catch

Author: nhsdevws

lambdas/id_sync/src/ieds_db_operations.py

@@ -150,13 +150,21 @@ def ieds_update_patient_id(old_id: str, new_id: str) -> dict:
 def get_items_to_update(old_patient_pk: str) -> list:
     """Get items that need to be updated in the IEDS table."""
     logger.info(f"Getting items to update for old patient PK: {old_patient_pk}")
-    response = get_ieds_table().query(
-        KeyConditionExpression=Key('PatientPK').eq(old_patient_pk),
-        Limit=BATCH_SIZE
-    )
+    try:
+        response = get_ieds_table().query(
+            KeyConditionExpression=Key('PatientPK').eq(old_patient_pk),
+            Limit=BATCH_SIZE
+        )
 
-    if 'Items' not in response or not response['Items']:
-        logger.warning(f"No items found for old patient PK: {old_patient_pk}")
-        return []
+        if 'Items' not in response or not response['Items']:
+            logger.warning(f"No items found for old patient PK: {old_patient_pk}")
+            return []
 
-    return response['Items']
+        return response['Items']
+    except Exception as e:
+        logger.exception(f"Error querying items for old patient PK: {old_patient_pk}")
+        raise IdSyncException(
+            message=f"Error querying items for old patient PK: {old_patient_pk}",
+            nhs_numbers=[old_patient_pk],
+            exception=e
+        )

lambdas/id_sync/tests/test_ieds_db_operations.py

@@ -625,3 +625,54 @@ def test_ieds_update_patient_id_special_characters(self):
 
         # Verify transact_write_items was called with special characters
         self.mock_table.transact_write_items.assert_called_once()
+
+
+class TestGetItemsToUpdate(TestIedsDbOperations):
+
+    def setUp(self):
+        super().setUp()
+        # Mock get_ieds_table()
+        self.mock_get_ieds_table = patch('ieds_db_operations.get_ieds_table')
+        self.mock_get_ieds_table_patcher = self.mock_get_ieds_table.start()
+        self.mock_table = MagicMock()
+        self.mock_get_ieds_table_patcher.return_value = self.mock_table
+
+    def tearDown(self):
+        patch.stopall()
+
+    def test_get_items_to_update_success(self):
+        """Test successful retrieval of items to update"""
+        # Arrange
+        patient_id = "test-patient-123"
+        expected_items = [
+            {'PK': f'Patient#{patient_id}', 'PatientPK': f'Patient#{patient_id}'},
+            {'PK': f'Patient#{patient_id}#record1', 'PatientPK': f'Patient#{patient_id}'}
+        ]
+        self.mock_table.query.return_value = {
+            'Items': expected_items,
+            'Count': len(expected_items)
+        }
+
+        # Act
+        result = ieds_db_operations.get_items_to_update(f"Patient#{patient_id}")
+
+        # Assert
+        self.assertEqual(result, expected_items)
+
+        # Verify query was called with correct parameters
+        self.mock_table.query.assert_called_once()
+
+    def test_get_items_to_update_no_records(self):
+        """Test when no records are found for the patient ID"""
+        # Arrange
+        patient_id = "test-patient-no-records"
+        self.mock_table.query.return_value = {
+            'Items': [],
+            'Count': 0
+        }
+
+        # Act
+        result = ieds_db_operations.get_items_to_update(f"Patient#{patient_id}")
+
+        # Assert
+        self.assertEqual(result, [])