VED-740b: review

Author: Akol125

backend/src/fhir_service.py

@@ -29,10 +29,11 @@
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()
 
-def get_service_url(service_env: str = None, service_base_path: str = None
+def get_service_url(service_env: str = os.getenv("IMMUNIZATION_ENV"), service_base_path: str = os.getenv("IMMUNIZATION_BASE_PATH")
  ) -> str:
-    service_env: str = service_env if service_env is not None else os.getenv("IMMUNIZATION_ENV", "")
-    base_path: str = service_base_path or os.getenv("IMMUNIZATION_BASE_PATH")
+    
+    if not service_base_path:
+        service_base_path = "immunisation-fhir-api/FHIR/R4"
 
     non_prod = ["internal-dev", "int", "sandbox"]
     if service_env in non_prod:
@@ -42,7 +43,7 @@ def get_service_url(service_env: str = None, service_base_path: str = None
     else:
         subdomain = "internal-dev."
 
-    return f"https://{subdomain}api.service.nhs.uk/{base_path}"
+    return f"https://{subdomain}api.service.nhs.uk/{service_base_path}"
 
 
 class UpdateOutcome(Enum):