refactor mns

Author: Akol125

mns_subscription/src/mns_service.py

@@ -94,7 +94,7 @@ def delete_subscription(self, subscription_id: str) -> bool:
         """Delete the subscription by ID."""
         url = f"{MNS_URL}/{subscription_id}"
         response = requests.delete(url, headers=self.request_headers, timeout=10)
-        if response.status_code in (200, 204):
+        if response.status_code == 204:
             logging.info(f"Deleted subscription {subscription_id}")
             return True
         else:

mns_subscription/src/mns_setup.py

@@ -19,5 +19,5 @@ def get_mns_service(mns_env: str = "int"):
         cache=cache,
     )
 
-    logging.info("Creating MNS service...")
+    logging.info("Authentication Initiated...")
     return MnsService(authenticator)

mns_subscription/tests/test_mns_service.py

@@ -148,19 +148,18 @@ def test_check_subscription_creates_if_not_found(self, mock_get, mock_post):
 
     @patch("mns_service.requests.delete")
     def test_delete_subscription_success(self, mock_delete):
-        for code in (200, 204):
-            mock_response = MagicMock()
-            mock_response.status_code = code
-            mock_delete.return_value = mock_response
-
-            service = MnsService(self.authenticator)
-            result = service.delete_subscription("sub-id-123")
-            self.assertTrue(result)
-            mock_delete.assert_called_with(
-                f"{MNS_URL}/sub-id-123",
-                headers=service.request_headers,
-                timeout=10
-            )
+        mock_response = MagicMock()
+        mock_response.status_code = 204
+        mock_delete.return_value = mock_response
+
+        service = MnsService(self.authenticator)
+        result = service.delete_subscription("sub-id-123")
+        self.assertTrue(result)
+        mock_delete.assert_called_with(
+            f"{MNS_URL}/sub-id-123",
+            headers=service.request_headers,
+            timeout=10
+        )
 
     @patch("mns_service.requests.delete")
     def test_delete_subscription_401(self, mock_delete):