fix sonar issues

Author: Akol125

lambdas/shared/src/common/validator/parsers/csv_line_parser.py

@@ -26,7 +26,7 @@ def parse_csv_line(self, csv_row: str, csv_header: str) -> None:
         # create a key value mapping
         keys = list(csv.reader([csv_header]))[0]
         values = list(csv.reader([csv_row]))[0]
-        self.csv_file_data = dict(map(lambda i, j: (i, j), keys, values))
+        self.csv_file_data = dict(zip(keys, values, strict=False))
 
     # Retrieves the value of a specific column name as a list.
     def get_key_value(self, field_name: str) -> list[str]:

lambdas/shared/src/common/validator/parsers/fhir_parser.py

@@ -29,7 +29,7 @@ def _locate_fhir_item_in_dict(self, fhir_resource: dict, fhir_field: str) -> boo
         except Exception:
             return False
 
-    def _locate_fhir_item_in_list(self, fhir_resource: list, fhir_field: str) -> dict:
+    def _locate_fhir_item_in_list(self, fhir_resource: list, fhir_field: str) -> dict | str:
         """
         Locates and returns the first FHIR item (dictionary) in a list that contains
         the specified FHIR field name or value.
@@ -43,13 +43,14 @@ def _locate_fhir_item_in_list(self, fhir_resource: list, fhir_field: str) -> dic
         try:
             while index < len(fhir_resource):
                 for key in fhir_resource[index]:
-                    if (fhir_resource[index][key] == field_list[1]) or (key == field_list[1]):
+                    fhir_value = fhir_resource[index][key]
+                    if (
+                        fhir_value == field_list[1]
+                        or key == field_list[1]
+                        or self._locate_fhir_item_in_dict(fhir_value, field_list[1])
+                    ):
                         node_id = index
                         break
-                    else:
-                        if self._locate_fhir_item_in_dict(fhir_resource[index][key], field_list[1]):
-                            node_id = index
-                            break
                 index += 1
         except Exception:
             return ""