AMB-1741 add bare controller and service

Author: artronics

lambda_code/src/fhir_controller.py

@@ -0,0 +1,29 @@
+from dataclasses import dataclass
+
+from fhir.resources.resource import Resource
+
+
+@dataclass
+class FhirResponse:
+    headers: dict
+    body: Resource
+    status_code: int
+
+
+class FhirController:
+
+    def __init__(self, fhir_service):
+        self.fhir_service = fhir_service
+
+    def get_immunisation_by_id(self, aws_event) -> FhirResponse:
+        pass
+
+    @staticmethod
+    def _create_response(status_code, body):
+        return {
+            "statusCode": status_code,
+            "headers": {
+                "Content-Type": "application/fhir+json",
+            },
+            "body": body
+        }

lambda_code/src/fhir_service.py

@@ -0,0 +1,2 @@
+class FhirService:
+    pass

lambda_code/src/get_imms_handler.py

@@ -3,7 +3,7 @@
 import uuid
 
 from dynamodb import EventTable
-from immunisation_api import create_response
+from fhir_controller import FhirController
 
 
 def create_operation_outcome(event_id, message, code):
@@ -51,12 +51,12 @@ def is_valid_id(_event_id):
             create_operation_outcome(str(uuid.uuid4()),
                                      "he provided event ID is either missing or not in the expected format.",
                                      "invalid"))
-        return create_response(400, body)
+        return FhirController._create_response(400, body)
 
     query_result = dynamo_service.get_event_by_id(event_id)
     if query_result is None:
         body = json.dumps(
             create_operation_outcome(str(uuid.uuid4()), "The requested resource was not found.", "not-found"))
-        return create_response(404, body)
+        return FhirController._create_response(404, body)
 
-    return create_response(200, json.dumps(query_result))
+    return FhirController._create_response(200, json.dumps(query_result))

lambda_code/src/immunisation_api.py

@@ -1,16 +1,6 @@
 import requests
 
 
-def create_response(status_code, body):
-    return {
-        "statusCode": status_code,
-        "headers": {
-            "Content-Type": "application/fhir+json",
-        },
-        "body": body
-    }
-
-
 class ImmunisationApi:
     def __init__(self, url):
         self.url = url

lambda_code/tests/test_fhir_controller.py

@@ -0,0 +1,26 @@
+import os
+import sys
+import unittest
+from unittest.mock import create_autospec
+
+sys.path.append(f"{os.path.dirname(os.path.abspath(__file__))}/../src")
+
+from fhir_controller import FhirController
+from fhir_service import FhirService
+
+
+class TestFhirController(unittest.TestCase):
+    def setUp(self):
+        self.service = create_autospec(FhirService)
+        self.controller = FhirController(self.service)
+
+    def test_create_response(self):
+        """it should return application/fhir+json with correct status code"""
+        res = self.controller._create_response(42, "a body")
+        headers = res["headers"]
+
+        self.assertEqual(res["statusCode"], 42)
+        self.assertDictEqual(headers, {
+            "Content-Type": "application/fhir+json",
+        })
+        self.assertEqual(res["body"], "a bodys")

lambda_code/tests/test_get_imms.py

@@ -11,7 +11,7 @@
 from get_imms_handler import get_imms, create_operation_outcome
 
 
-class TestGetImms(unittest.TestCase):
+class TestGetImmunisationById(unittest.TestCase):
     def setUp(self):
         self.dynamodb_service = create_autospec(EventTable)
 
@@ -26,7 +26,6 @@ def test_get_imms_happy_path(self):
         # Assert
         self.dynamodb_service.get_event_by_id.assert_called_once_with(lambda_event["pathParameters"]["id"])
         self.assertEqual(result['statusCode'], 200)
-        self.assertEqual(result['headers']['Content-Type'], "application/fhir+json")
         self.assertDictEqual(json.loads(result['body']), {"message": "Mocked event data"})
 
     def test_get_imms_handler_sad_path_400(self):
@@ -37,7 +36,6 @@ def test_get_imms_handler_sad_path_400(self):
 
         # Assert
         assert result['statusCode'] == 400
-        self.assertEqual(result['headers']['Content-Type'], "application/fhir+json")
         act_body = json.loads(result['body'])
         exp_body = create_operation_outcome(str(uuid.uuid4()),
                                             "he provided event ID is either missing or not in the expected format.",

lambda_code/tests/test_immunisation_api.py

@@ -7,19 +7,7 @@
 
 sys.path.append(f"{os.path.dirname(os.path.abspath(__file__))}/../src")
 
-from immunisation_api import ImmunisationApi, create_response
-
-
-class TestRequestResponseHelpers(unittest.TestCase):
-    def test_create_response(self):
-        res = create_response(42, "a body")
-        headers = res["headers"]
-        self.assertEqual(res["statusCode"], 42)
-
-        self.assertDictEqual(headers, {
-            "Content-Type": "application/fhir+json",
-        })
-        self.assertEqual(res["body"], "a body")
+from immunisation_api import ImmunisationApi
 
 
 class TestImmsApiService(unittest.TestCase):