unit tests, mock dynamodb, refactoring II

Author: JamesW1-NHS

ack_backend/tests/utils/generic_setup_and_teardown_for_ack_backend.py

@@ -1,6 +1,13 @@
 """Generic setup and teardown for ACK backend tests"""
 
-from tests.utils.mock_environment_variables import BucketNames, Firehose, REGION_NAME
+from unittest.mock import patch
+
+from tests.utils.mock_environment_variables import BucketNames, MOCK_ENVIRONMENT_DICT, Firehose
+
+# Ensure environment variables are mocked before importing from src files
+with patch.dict("os.environ", MOCK_ENVIRONMENT_DICT):
+    from clients import REGION_NAME
+    from constants import AuditTableKeys, AUDIT_TABLE_NAME, AUDIT_TABLE_QUEUE_NAME_GSI, AUDIT_TABLE_FILENAME_GSI
 
 
 class GenericSetUp:
@@ -11,7 +18,7 @@ class GenericSetUp:
     * If firehose_client is provided, creates a firehose delivery stream
     """
 
-    def __init__(self, s3_client=None, firehose_client=None):
+    def __init__(self, s3_client=None, firehose_client=None, dynamodb_client=None):
 
         if s3_client:
             for bucket_name in [BucketNames.SOURCE, BucketNames.DESTINATION, BucketNames.MOCK_FIREHOSE]:
@@ -30,11 +37,41 @@ def __init__(self, s3_client=None, firehose_client=None):
                 },
             )
 
+        if dynamodb_client:
+            dynamodb_client.create_table(
+                TableName=AUDIT_TABLE_NAME,
+                KeySchema=[{"AttributeName": AuditTableKeys.MESSAGE_ID, "KeyType": "HASH"}],
+                AttributeDefinitions=[
+                    {"AttributeName": AuditTableKeys.MESSAGE_ID, "AttributeType": "S"},
+                    {"AttributeName": AuditTableKeys.FILENAME, "AttributeType": "S"},
+                    {"AttributeName": AuditTableKeys.QUEUE_NAME, "AttributeType": "S"},
+                    {"AttributeName": AuditTableKeys.STATUS, "AttributeType": "S"},
+                ],
+                ProvisionedThroughput={"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
+                GlobalSecondaryIndexes=[
+                    {
+                        "IndexName": AUDIT_TABLE_FILENAME_GSI,
+                        "KeySchema": [{"AttributeName": AuditTableKeys.FILENAME, "KeyType": "HASH"}],
+                        "Projection": {"ProjectionType": "KEYS_ONLY"},
+                        "ProvisionedThroughput": {"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
+                    },
+                    {
+                        "IndexName": AUDIT_TABLE_QUEUE_NAME_GSI,
+                        "KeySchema": [
+                            {"AttributeName": AuditTableKeys.QUEUE_NAME, "KeyType": "HASH"},
+                            {"AttributeName": AuditTableKeys.STATUS, "KeyType": "RANGE"},
+                        ],
+                        "Projection": {"ProjectionType": "ALL"},
+                        "ProvisionedThroughput": {"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
+                    },
+                ],
+            )
+
 
 class GenericTearDown:
     """Performs generic tear down of mock resources"""
 
-    def __init__(self, s3_client=None, firehose_client=None):
+    def __init__(self, s3_client=None, firehose_client=None, dynamodb_client=None):
 
         if s3_client:
             for bucket_name in [BucketNames.SOURCE, BucketNames.DESTINATION, BucketNames.MOCK_FIREHOSE]:
@@ -44,3 +81,6 @@ def __init__(self, s3_client=None, firehose_client=None):
 
         if firehose_client:
             firehose_client.delete_delivery_stream(DeliveryStreamName=Firehose.STREAM_NAME)
+
+        if dynamodb_client:
+            dynamodb_client.delete_table(TableName=AUDIT_TABLE_NAME)

ack_backend/tests/utils/values_for_ack_backend_tests.py

@@ -219,6 +219,20 @@ class ValidValues:
         "|MESSAGE_DELIVERY\n"
     )
 
+    upload_ack_file_expected_log = {
+        "function_name": "ack_processor_upload_ack_file",
+        "date_time": fixed_datetime.strftime("%Y-%m-%d %H:%M:%S"),
+        "status": "success",
+        "supplier": MOCK_MESSAGE_DETAILS.supplier,
+        "file_key": MOCK_MESSAGE_DETAILS.file_key,
+        "vaccine_type": MOCK_MESSAGE_DETAILS.vaccine_type,
+        "message_id": MOCK_MESSAGE_DETAILS.row_id,
+        "row_count": 100,
+        "statusCode": 200,
+        "message": "Record processing complete",
+    }
+
+
 
 class InvalidValues:
     """Invalid values for use in tests"""