tests

Author: nhsdevws

backend/src/models/constants.py

@@ -39,3 +39,5 @@ class Constants:
     }
 
     ALLOWED_CONTAINED_RESOURCES = {"Practitioner", "Patient"}
+
+    SUPPLIER_PERMISSIONS_KEY = "supplier_permissions"

backend/src/models/utils/permissions.py

@@ -1,8 +1,9 @@
 from clients import redis_client
+from models.constants import Constants
 import json
 
 def get_supplier_permissions(supplier: str) -> list[str]:
-    permissions_data = redis_client.hget("supplier_permissions", supplier)
+    permissions_data = redis_client.hget(Constants.SUPPLIER_PERMISSIONS_KEY, supplier)
     if not permissions_data:
         return []
     return json.loads(permissions_data)

backend/tests/test_update_imms.py

@@ -1,6 +1,6 @@
 import json
 import unittest
-from unittest.mock import create_autospec
+from unittest.mock import create_autospec, patch
 
 from fhir_controller import FhirController
 from models.errors import Severity, Code, create_operation_outcome
@@ -10,7 +10,18 @@
 
 class TestUpdateImmunizations(unittest.TestCase):
     def setUp(self):
+        # self.controller = create_autospec(FhirController)
+        self.logger_exception_patcher = patch("logging.Logger.exception")
+        self.mock_logger_exception = self.logger_exception_patcher.start()
+        # patch FhirController
         self.controller = create_autospec(FhirController)
+        self.controller.update_immunization = FhirController.update_immunization        
+
+        
+
+    def tearDown(self):
+        self.logger_exception_patcher.stop()
+
 
     def test_update_immunization(self):
         """it should call service update method"""
@@ -26,7 +37,8 @@ def test_update_immunization(self):
         self.controller.update_immunization.assert_called_once_with(lambda_event)
         self.assertDictEqual(exp_res, act_res)
 
-    def test_handle_exception(self):
+    @patch("update_imms_handler.FhirController.create_response")
+    def test_update_imms_exception(self, mock_create_response):
         """unhandled exceptions should result in 500"""
         lambda_event = {"pathParameters": {"id": "an-id"}}
         error_msg = "an unhandled error"
@@ -38,16 +50,26 @@ def test_handle_exception(self):
             code=Code.server_error,
             diagnostics=GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE,
         )
+        mock_response = "controller-response-error"
+        mock_create_response.return_value = mock_response
 
         # When
         act_res = update_imms(lambda_event, self.controller)
 
         # Then
-        act_body = json.loads(act_res["body"])
-        act_body["id"] = None
+        # check parameters used to call create_response
+        args, kwargs = mock_create_response.call_args
+        self.assertEqual(args[0], 500)
+        issue = args[1]["issue"][0]
+        severity = issue["severity"]
+        code = issue["code"]
+        diagnostics = issue["diagnostics"]
+        self.assertEqual(severity, "error")
+        self.assertEqual(code, "exception")
+        self.assertEqual(diagnostics, GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE)
+        self.assertEqual(act_res, mock_response)
 
-        self.assertDictEqual(act_body, exp_error)
-        self.assertEqual(act_res["statusCode"], 500)
+        
 
     def test_update_imms_with_duplicated_identifier_returns_error(self):
         """Should return an IdentifierDuplication error"""

backend/tests/utils/test_permissions.py

@@ -1,17 +1,44 @@
 import unittest
 from unittest.mock import patch
-from src.models.utils.permissions import get_supplier_permissions
+from models.constants import Constants
 
-class TestPermissions(unittest.TestCase):
+from models.utils.permissions import get_supplier_permissions
 
-    @patch("clients.redis_client.hget")
-    def test_returns_list_if_permissions_exist(self, mock_hget):
-        mock_hget.return_value = '["COVID19_FULL", "FLU_CREATE"]'
-        result = get_supplier_permissions("DPSFULL")
-        self.assertEqual(result, ["COVID19_FULL", "FLU_CREATE"])
+class TestGetSupplierPermissions(unittest.TestCase):
+    
+    def setUp(self):
+        self.redis_client_patcher = patch("models.utils.permissions.redis_client")
+        self.mock_redis_client = self.redis_client_patcher.start()
+    
+    def tearDown(self):
+        patch.stopall()
+    
+    def test_returns_permissions_list(self):
+        # Arrange
+        supplier = "supplier-1"
+        self.mock_redis_client.hget.return_value = '["perm1", "perm2"]'
+        # Act
+        result = get_supplier_permissions(supplier)
+        # Assert
+        self.assertEqual(result, ["perm1", "perm2"])
+        self.mock_redis_client.hget.assert_called_once_with(Constants.SUPPLIER_PERMISSIONS_KEY, supplier)
 
-    @patch("clients.redis_client.hget")
-    def test_returns_empty_list_if_no_permissions(self, mock_hget):
-        mock_hget.return_value = None
-        result = get_supplier_permissions("UNKNOWN")
-        self.assertEqual(result, [])
+    def test_returns_empty_list_when_no_permissions(self):
+        # Arrange
+        supplier = "supplier-2"
+        self.mock_redis_client.hget.return_value = None
+        # Act
+        result = get_supplier_permissions(supplier)
+        # Assert
+        self.assertEqual(result, [])
+        self.mock_redis_client.hget.assert_called_once_with(Constants.SUPPLIER_PERMISSIONS_KEY, supplier)
+
+    def test_returns_empty_list_when_empty_string(self):
+        # Arrange
+        supplier = "supplier-3"
+        self.mock_redis_client.hget.return_value = ""
+        # Act
+        result = get_supplier_permissions(supplier)
+        # Assert
+        self.assertEqual(result, [])
+        self.mock_redis_client.hget.assert_called_once_with(Constants.SUPPLIER_PERMISSIONS_KEY, supplier)