refactor for duplicates

Author: nhsdevws

lambdas/id_sync/.vscode/settings.json.default

@@ -14,5 +14,14 @@
     "pylint.args": [
         "--init-hook",
         "import sys; sys.path.append('./src')"
-    ]
+    ],
+    "[makefile]": {
+        "editor.insertSpaces": false,
+        "editor.detectIndentation": false
+    },
+    "files.trimTrailingWhitespace": true,
+    "[python]": {
+        "files.trimTrailingWhitespace": true
+    },
+    "files.insertFinalNewline": true
 }

lambdas/id_sync/src/id_sync.py

@@ -4,11 +4,9 @@
 from common.aws_lambda_event import AwsLambdaEvent
 from common.aws_lambda_sqs_event_record import AwsLambdaSqsEventRecord
 from record_processor import process_record
-
 '''
-    Event Processor
-    The Business Logic for the Redis Sync Lambda Function.
-    This module processes S3 events and iterates through each record to process them individually.'''
+Lambda function handler for processing SQS events.Lambda for ID Sync. Fired by SQS
+'''
 
 
 @logging_decorator(prefix="id_sync", stream_name=STREAM_NAME)
@@ -40,5 +38,6 @@ def handler(event_data, _):
             return {"status": "success", "message": "No records found in event"}
 
     except Exception:
-        logger.exception("Error processing S3 event")
-        return {"status": "error", "message": "Error processing S3 event"}
+        msg = "Error processing id_sync event"
+        logger.exception(msg)
+        return {"status": "error", "message": msg}

lambdas/id_sync/tests/test_id_sync.py

@@ -247,11 +247,11 @@ def test_handler_aws_lambda_event_exception(self):
 
         # Assertions
         self.mock_aws_lambda_event.assert_called_once_with(self.single_sqs_event)
-        self.mock_logger.exception.assert_called_once_with("Error processing S3 event")
+        self.mock_logger.exception.assert_called_once_with("Error processing id_sync event")
         self.mock_process_record.assert_not_called()
 
         self.assertEqual(result["status"], "error")
-        self.assertEqual(result["message"], "Error processing S3 event")
+        self.assertEqual(result["message"], "Error processing id_sync event")
 
     def test_handler_process_record_exception(self):
         """Test handler when process_record raises exception"""
@@ -267,10 +267,10 @@ def test_handler_process_record_exception(self):
 
         # Assertions
         self.mock_process_record.assert_called_once_with(mock_event.records[0], None)
-        self.mock_logger.exception.assert_called_once_with("Error processing S3 event")
+        self.mock_logger.exception.assert_called_once_with("Error processing id_sync event")
 
         self.assertEqual(result["status"], "error")
-        self.assertEqual(result["message"], "Error processing S3 event")
+        self.assertEqual(result["message"], "Error processing id_sync event")
 
     def test_handler_process_record_missing_file_key(self):
         """Test handler when process_record returns incomplete data"""
@@ -289,9 +289,9 @@ def test_handler_process_record_missing_file_key(self):
         result = handler(self.single_sqs_event, None)
 
         # Should catch KeyError and return error
-        self.mock_logger.exception.assert_called_once_with("Error processing S3 event")
+        self.mock_logger.exception.assert_called_once_with("Error processing id_sync event")
         self.assertEqual(result["status"], "error")
-        self.assertEqual(result["message"], "Error processing S3 event")
+        self.assertEqual(result["message"], "Error processing id_sync event")
 
     def test_handler_process_record_missing_status(self):
         """Test handler when process_record returns missing status"""
@@ -310,9 +310,8 @@ def test_handler_process_record_missing_status(self):
         result = handler(self.single_sqs_event, None)
 
         # Should catch KeyError and return error
-        self.mock_logger.exception.assert_called_once_with("Error processing S3 event")
+        self.mock_logger.exception.assert_called_once_with("Error processing id_sync event")
         self.assertEqual(result["status"], "error")
-        self.assertEqual(result["message"], "Error processing S3 event")
 
     def test_handler_file_keys_order_preserved(self):
         """Test that file_keys are returned in the same order as processed"""