Test Assertions

Author: nhsdevws

delta_backend/tests/test_convert_to_flat_json.py

@@ -27,33 +27,33 @@
 with patch.dict("os.environ", MOCK_ENV_VARS):
     from delta import handler, Converter
 
-class TestRecordError(unittest.TestCase):
-    def test_fields_and_str(self):
-        err = RecordError(
-            code=5,
-            message="Test failed",
-            details="Something went wrong"
-        )
-
-        # The attributes should round‑trip
-        self.assertEqual(err.code, 5)
-        self.assertEqual(err.message, "Test failed")
-        self.assertEqual(err.details, "Something went wrong")
-
-        # __repr__ and __str__ both produce the tuple repr
-        expected = "(5, 'Test failed', 'Something went wrong')"
-        self.assertEqual(str(err),   expected)
-        self.assertEqual(repr(err),  expected)
-
-    def test_default_args(self):
-        # If you omit arguments they default to None
-        err = RecordError()
-        self.assertIsNone(err.code)
-        self.assertIsNone(err.message)
-        self.assertIsNone(err.details)
-
-        # repr shows three Nones
-        self.assertEqual(str(err), "(None, None, None)")
+# class TestRecordError(unittest.TestCase):
+#     def test_fields_and_str(self):
+#         err = RecordError(
+#             code=5,
+#             message="Test failed",
+#             details="Something went wrong"
+#         )
+
+#         # The attributes should round‑trip
+#         self.assertEqual(err.code, 5)
+#         self.assertEqual(err.message, "Test failed")
+#         self.assertEqual(err.details, "Something went wrong")
+
+#         # __repr__ and __str__ both produce the tuple repr
+#         expected = "(5, 'Test failed', 'Something went wrong')"
+#         self.assertEqual(str(err),   expected)
+#         self.assertEqual(repr(err),  expected)
+
+#     def test_default_args(self):
+#         # If you omit arguments they default to None
+#         err = RecordError()
+#         self.assertIsNone(err.code)
+#         self.assertIsNone(err.message)
+#         self.assertIsNone(err.details)
+
+#         # repr shows three Nones
+#         self.assertEqual(str(err), "(None, None, None)")
 
 @patch.dict("os.environ", MOCK_ENV_VARS, clear=True)
 @mock_dynamodb
@@ -99,9 +99,13 @@ def setUp(self):
         self.logger_exception_patcher = patch("logging.Logger.exception")
         self.mock_logger_exception = self.logger_exception_patcher.start()
 
+        self.firehose_logger_patcher = patch("delta.firehose_logger")
+        self.mock_firehose_logger = self.firehose_logger_patcher.start()
+
     def tearDown(self):
         self.logger_exception_patcher.stop()
         self.logger_info_patcher.stop()
+        self.mock_firehose_logger.stop()
 
     @staticmethod
     def get_event(event_name="INSERT", operation="operation", supplier="EMIS"):
@@ -140,8 +144,6 @@ def test_fhir_converter_json_direct_data(self):
         """it should convert fhir json data to flat json"""
         json_data = json.dumps(ValuesForTests.json_data)
 
-        start = time.time()
-
         FHIRConverter = Converter(json_data)
         FlatFile = FHIRConverter.runConversion(ValuesForTests.json_data, False, True)
 
@@ -151,15 +153,8 @@ def test_fhir_converter_json_direct_data(self):
         self.assertEqual(flatJSON, expected_imms)
 
         errorRecords = FHIRConverter.getErrorRecords()
-        # print(flatJSON)
-
-        if len(errorRecords) > 0:
-            print("Converted With Errors")
-        else:
-            print("Converted Successfully")
-
-        end = time.time()
-        print(end - start)
+        
+        self.assertEqual(len(errorRecords), 0)
 
     def test_fhir_converter_json_error_scenario(self):
         """it should convert fhir json data to flat json - error scenarios"""
@@ -168,23 +163,13 @@ def test_fhir_converter_json_error_scenario(self):
         for test_case in error_test_cases:
             json_data = json.dumps(test_case)
 
-            start = time.time()
-
             FHIRConverter = Converter(json_data)
-            FlatFile = FHIRConverter.runConversion(ValuesForTests.json_data, False, True)
-
-            flatJSON = json.dumps(FlatFile)
+            FHIRConverter.runConversion(ValuesForTests.json_data, False, True)
 
             errorRecords = FHIRConverter.getErrorRecords()
 
-            if len(errorRecords) > 0:
-                print("Converted With Errors")
-                print(f"Error records -error scenario {errorRecords}")
-            else:
-                print("Converted Successfully")
-
-            end = time.time()
-            print(end - start)
+            # Check if bad data creates error records
+            self.assertEqual(len(errorRecords) > 0)
 
     def test_handler_imms_convert_to_flat_json(self):
         """Test that the Imms field contains the correct flat JSON data for CREATE, UPDATE, and DELETE operations."""