Refactored get imms by identifier and the search endpoint

Author: dlzhry2nhs

infrastructure/instance/oas.yaml

@@ -128,28 +128,6 @@ paths:
         httpMethod: "POST"
         timeoutInMillis: 30000
         type: "AWS_PROXY"
-      parameters:
-        - name: patient.identifier
-          in: query
-          required: true
-          schema:
-            type: string
-        - name: -immunization.target
-          in: query
-          schema:
-            type: string
-        - name: -date.from
-          in: query
-          schema:
-            type: string
-        - name: -date.to
-          in: query
-          schema:
-            type: string
-        - name: _include
-          in: query
-          schema:
-            type: string
       responses:
         "201":
           description: An Immunisation search event

lambdas/backend/src/controller/aws_apig_event_utils.py

@@ -9,6 +9,10 @@
 from utils import dict_utils
 
 
+def get_multi_value_query_params(event: APIGatewayProxyEventV1) -> dict:
+    return dict_utils.get_field(dict(event), "multiValueQueryStringParameters", default={})
+
+
 def get_path_parameter(event: APIGatewayProxyEventV1, param_name: str) -> str:
     return dict_utils.get_field(event["pathParameters"], param_name, default="")
 

lambdas/backend/src/controller/constants.py

@@ -1,4 +1,34 @@
 """FHIR Controller constants"""
 
+from enum import StrEnum
+
 SUPPLIER_SYSTEM_HEADER_NAME = "SupplierSystem"
 E_TAG_HEADER_NAME = "E-Tag"
+
+SEARCH_USING_POST_PATH = "/Immunization/_search"
+
+# TODO - could create string enum for different parameters
+# Once parameter parser is tidier, consider moving it there
+
+
+class IdentifierSearchParameterName(StrEnum):
+    IDENTIFIER = "identifier"
+    ELEMENTS = "_elements"
+
+
+class ImmunizationSearchParameterName(StrEnum):
+    PATIENT_IDENTIFIER = "patient.identifier"
+    IMMUNIZATION_TARGET = "-immunization.target"
+    DATE_FROM = "-date.from"
+    DATE_TO = "-date.to"
+    INCLUDE = "_include"
+
+
+class IdentifierSearchElement(StrEnum):
+    """Valid elements which can be requested to include in the identifier search response"""
+
+    ID = "id"
+    META = "meta"
+
+
+IMMUNIZATION_TARGET_LEGACY_KEY_NAME = "immunization-target"

lambdas/backend/src/controller/fhir_api_exception_handler.py

@@ -20,8 +20,10 @@
     InvalidImmunizationId,
     InvalidJsonError,
     InvalidResourceVersion,
+    ParameterException,
     ResourceVersionNotProvided,
     Severity,
+    TooManyResultsError,
     UnauthorizedError,
     UnauthorizedVaxError,
     UnhandledResponseError,
@@ -36,7 +38,9 @@
     InvalidJsonError: 400,
     InvalidResourceVersion: 400,
     CustomValidationError: 400,
+    ParameterException: 400,
     ResourceVersionNotProvided: 400,
+    TooManyResultsError: 400,
     UnauthorizedError: 403,
     UnauthorizedVaxError: 403,
     ResourceNotFoundError: 404,