VED-303: Delete existing hash fields not present in the new mapping. (#603)

Author: mfjarvis

redis_sync/src/redis_cacher.py

@@ -30,7 +30,14 @@ def upload(bucket_name: str, file_key: str) -> dict:
                     k: json.dumps(v) if isinstance(v, list) else v
                     for k, v in mapping.items()
                 }
+                existing_mapping = redis_client.hgetall(key)
+                logger.info("Existing mapping for %s: %s", key, existing_mapping)
                 redis_client.hmset(key, safe_mapping)
+                logger.info("New mapping for %s: %s", key, safe_mapping)
+                fields_to_delete = [k for k in existing_mapping if k not in safe_mapping]
+                if fields_to_delete:
+                    redis_client.hdel(key, fields_to_delete)
+                    logger.info("Deleted mapping fields for %s: %s", key, fields_to_delete)
 
             return {"status": "success", "message": f"File {file_key} uploaded to Redis cache."}
         except Exception:

redis_sync/tests/test_redis_cacher.py

@@ -39,5 +39,29 @@ def test_upload(self):
 
         self.mock_s3_reader.read.assert_called_once_with(bucket_name, file_key)
         self.mock_transform_map.assert_called_once_with(mock_data, file_key)
-        self.mock_redis_client.hmset.assert_called()
+        self.mock_redis_client.hmset.assert_any_call("vacc_to_diseases", {"b": "c"})
+        self.mock_redis_client.hmset.assert_any_call("diseases_to_vacc", {"c": "b"})
+        self.mock_redis_client.hdel.assert_not_called()
+        self.assertEqual(result, {"status": "success", "message": f"File {file_key} uploaded to Redis cache."})
+
+    def test_deletes_extra_fields(self):
+        mock_data = {"input_key": "input_val"}
+        mock_transformed_data = {
+            "hash_name": {"transformed_key": "transformed_val"},
+        }
+
+        self.mock_s3_reader.read = unittest.mock.Mock()
+        self.mock_s3_reader.read.return_value = mock_data
+        self.mock_transform_map.return_value = mock_transformed_data
+        self.mock_redis_client.hgetall.return_value = {"old_key": "old_val"}
+
+        bucket_name = "bucket"
+        file_key = "file-key"
+        result = RedisCacher.upload(bucket_name, file_key)
+
+        self.mock_s3_reader.read.assert_called_once_with(bucket_name, file_key)
+        self.mock_transform_map.assert_called_once_with(mock_data, file_key)
+        self.mock_redis_client.hgetall.assert_called_once_with("hash_name")
+        self.mock_redis_client.hmset.assert_called_once_with("hash_name", {"transformed_key": "transformed_val"})
+        self.mock_redis_client.hdel.assert_called_once_with("hash_name", ["old_key"])
         self.assertEqual(result, {"status": "success", "message": f"File {file_key} uploaded to Redis cache."})