PR comments

Author: dlzhry2nhs

lambdas/shared/src/common/data_quality/timeliness.py

@@ -17,4 +17,4 @@ def parse_csv_datetime(d: str) -> datetime.datetime:
         case 15:
             return datetime.datetime.strptime(d, "%Y%m%dT%H%M%S").replace(tzinfo=datetime.timezone.utc)
         case _:
-            raise ValueError("Unhandled datetime format")
+            raise ValueError("Invalid datetime format provided")

lambdas/shared/tests/test_common/data_quality/test_checker.py

@@ -19,9 +19,6 @@ def setUp(self):
         self.batch_dq_checker = DataQualityChecker(completeness_checker, is_batch_csv=True)
         self.fhir_json_dq_checker = DataQualityChecker(completeness_checker, is_batch_csv=False)
 
-    def test_something(self):
-        self.assertEqual(True, True)  # add assertion here
-
     def test_check_validity_returns_empty_list_when_data_is_valid(self):
         validation_result = self.batch_dq_checker._check_validity(VALID_BATCH_IMMUNISATION)