add missing tests

Author: Akol125

infrastructure/instance/file_name_processor.tf

@@ -166,10 +166,7 @@ resource "aws_iam_policy" "filenameprocessor_lambda_exec_policy" {
       {
         "Effect" : "Allow",
         "Action" : [
-          "s3:GetObject",
-          "s3:PutObject",
-          "s3:DeleteObject",
-          "s3:ListBucket"
+          "s3:PutObject"
         ],
         "Resource" : [
           "arn:aws:s3:::nhsd-dspp-core-ref-extended-attributes-gdp",

lambdas/filenameprocessor/src/constants.py

@@ -12,7 +12,7 @@
 
 SOURCE_BUCKET_NAME = os.getenv("SOURCE_BUCKET_NAME")
 
-# We have used an internal temporary bucket here and an actual dps bucket will replace this
+
 DPS_DESTINATION_BUCKET_NAME = os.getenv("DPS_BUCKET_NAME")
 EXPECTED_SOURCE_BUCKET_ACCOUNT = os.getenv("ACCOUNT_ID")
 EXPECTED_DPS_DESTINATION_ACCOUNT = os.getenv("DPS_ACCOUNT_ID")

lambdas/filenameprocessor/tests/test_lambda_handler.py

@@ -270,12 +270,6 @@ def test_lambda_handler_extended_attributes_success(self, mock_get_redis_client)
         mock_redis.hkeys = Mock(return_value=["COVID", *all_vaccine_types_in_this_test_file])
         mock_get_redis_client.return_value = mock_redis
 
-        # Ensure DPS destination bucket exists in moto so copy succeeds
-        try:
-            s3_client.create_bucket(Bucket=BucketNames.DPS_DESTINATION)
-        except Exception:
-            pass
-
         # Patch uuid4 (message id), and prevent external copy issues by simulating move
         with (
             patch("file_name_processor.validate_permissions_for_extended_attributes_files", return_value="X8E5B_COVID"),

lambdas/filenameprocessor/tests/utils_for_tests/mock_environment_variables.py

@@ -37,7 +37,7 @@ class Sqs:
 MOCK_ENVIRONMENT_DICT = {
     "SOURCE_BUCKET_NAME": BucketNames.SOURCE,
     "ACK_BUCKET_NAME": BucketNames.DESTINATION,
-    "DPS_BUCKET_NAME": BucketNames.DESTINATION,
+    "DPS_BUCKET_NAME": BucketNames.DPS_DESTINATION,
     "ACCOUNT_ID": MOCK_ACCOUNT_ID,
     "DPS_ACCOUNT_ID": MOCK_ACCOUNT_ID,
     "QUEUE_URL": "https://sqs.eu-west-2.amazonaws.com/123456789012/imms-batch-file-created-queue.fifo",